Fix restarting test failures (#12324)

7.4.3 was used as old binary and the error is invalid_tuple_data_type.

Author: jzhou77

fdbserver/include/fdbserver/DDTeamCollection.h

@@ -681,11 +681,11 @@ class DDTeamCollection : public ReferenceCounted<DDTeamCollection> {
 	std::map<Standalone<StringRef>, Reference<TCMachineInfo>> machine_info;
 	std::vector<Reference<TCMachineTeamInfo>> machineTeams; // all machine teams
 
-	// IMPORTANT: teams and teamsByServerIDs MUST be consistency, so any time we
+	// IMPORTANT: teams and teamsByServerIDs MUST be consistent, so any time we
 	// mutate teams, we must also mutate teamsByServerIDs
 	std::vector<Reference<TCTeamInfo>> teams;
-	// O(1) lookup index for getTeamByServers; key is the sorted server IDs string
-	// from TCTeamInfo::getServerIDsStr()
+	// O(1) hash map from server ID string to team information
+	// Currently used by getTeamByServers
 	std::unordered_map<std::string, Reference<TCTeamInfo>> teamsByServerIDs;
 
 	std::vector<DDTeamCollection*> teamCollections;

tests/CMakeLists.txt

@@ -426,14 +426,14 @@ if(WITH_PYTHON)
     TEST_FILES restarting/from_7.3.50_until_7.4.0/SnapTestRestart-1.toml
     restarting/from_7.3.50_until_7.4.0/SnapTestRestart-2.toml)
   add_fdb_test(
-    TEST_FILES restarting/from_7.3.50/ClientTransactionProfilingCorrectness-1.toml
-    restarting/from_7.3.50/ClientTransactionProfilingCorrectness-2.toml)
+    TEST_FILES restarting/from_7.3.50_until_7.4.0/ClientTransactionProfilingCorrectness-1.toml
+    restarting/from_7.3.50_until_7.4.0/ClientTransactionProfilingCorrectness-2.toml)
   add_fdb_test(
     TEST_FILES restarting/from_7.3.50/CycleTestRestart-1.toml
     restarting/from_7.3.50/CycleTestRestart-2.toml)
   add_fdb_test(
-    TEST_FILES restarting/from_7.3.50/StorefrontTestRestart-1.toml
-    restarting/from_7.3.50/StorefrontTestRestart-2.toml)
+    TEST_FILES restarting/from_7.3.50_until_7.4.0/StorefrontTestRestart-1.toml
+    restarting/from_7.3.50_until_7.4.0/StorefrontTestRestart-2.toml)
   add_fdb_test(
     TEST_FILES restarting/from_7.3.50/ClientMetricRestart-1.toml
     restarting/from_7.3.50/ClientMetricRestart-2.toml)