Skip to content

Improper use of onReadable in HTTPServer within fdbrpc #12401

@gc87

Description

@gc87

I see in the documentation for conn->onReadable() that a prior conn->read() which returns 0 is required before calling conn->onReadable(). Does this imply that the HTTP server implementation in fdbrpc is incorrect?

// Precondition: read() has been called and last returned 0
// returns when read() can read at least one byte (or may throw an error if the connection dies)
virtual Future<Void> onReadable() = 0;

There is no conn->read() call before conn->onReadable in the connectionHandler implementation.

wait(readPrevRequest);
wait(delay(0));
wait(conn->onReadable());

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions