-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Open
Description
I see in the documentation for conn->onReadable() that a prior conn->read() which returns 0 is required before calling conn->onReadable(). Does this imply that the HTTP server implementation in fdbrpc is incorrect?
foundationdb/flow/include/flow/IConnection.h
Lines 58 to 60 in e130005
// Precondition: read() has been called and last returned 0 | |
// returns when read() can read at least one byte (or may throw an error if the connection dies) | |
virtual Future<Void> onReadable() = 0; |
There is no conn->read() call before conn->onReadable in the connectionHandler implementation.
foundationdb/fdbrpc/HTTPServer.actor.cpp
Lines 89 to 91 in e130005
wait(readPrevRequest); | |
wait(delay(0)); | |
wait(conn->onReadable()); |
Metadata
Metadata
Assignees
Labels
No labels