From d75cdd4dbd0e69fae4ab2d0f17924d5ba1aa5ff6 Mon Sep 17 00:00:00 2001 From: Dan Lambright Date: Tue, 14 Oct 2025 18:00:14 -0400 Subject: [PATCH] Track temp tag message counts in TLogMetrics --- fdbserver/TLogServer.actor.cpp | 22 ++++++++++++---------- 1 file changed, 12 insertions(+), 10 deletions(-) diff --git a/fdbserver/TLogServer.actor.cpp b/fdbserver/TLogServer.actor.cpp index a42642da913..ae12078bb00 100644 --- a/fdbserver/TLogServer.actor.cpp +++ b/fdbserver/TLogServer.actor.cpp @@ -567,6 +567,7 @@ struct LogData : NonCopyable, public ReferenceCounted { CounterCollection cc; Counter bytesInput; + Counter tempTagMessageCount; Counter bytesDurable; Counter blockingPeeks; Counter blockingPeekTimeouts; @@ -664,16 +665,16 @@ struct LogData : NonCopyable, public ReferenceCounted { : initialized(false), queueCommittingVersion(0), knownCommittedVersion(0), durableKnownCommittedVersion(0), minKnownCommittedVersion(0), queuePoppedVersion(0), minPoppedTagVersion(0), minPoppedTag(invalidTag), unpoppedRecoveredTagCount(0), cc("TLog", interf.id().toString()), bytesInput("BytesInput", cc), - bytesDurable("BytesDurable", cc), blockingPeeks("BlockingPeeks", cc), - blockingPeekTimeouts("BlockingPeekTimeouts", cc), emptyPeeks("EmptyPeeks", cc), - nonEmptyPeeks("NonEmptyPeeks", cc), persistentDataUpdateBatches("PersistentDataUpdateBatches", cc), - dirtyTagsProcessed("DirtyTagsProcessed", cc), logId(interf.id()), protocolVersion(protocolVersion), - newPersistentDataVersion(invalidVersion), tLogData(tLogData), unrecoveredBefore(1), recoveredAt(1), - recoveryTxnVersion(1), logSystem(new AsyncVar>()), remoteTag(remoteTag), - isPrimary(isPrimary), logRouterTags(logRouterTags), logRouterPoppedVersion(0), logRouterPopToVersion(0), - locality(tagLocalityInvalid), recruitmentID(recruitmentID), logSpillType(logSpillType), - allTags(tags.begin(), tags.end()), terminated(tLogData->terminated.getFuture()), execOpCommitInProgress(false), - txsTags(txsTags) { + tempTagMessageCount("TempTagMessageCount", cc), bytesDurable("BytesDurable", cc), + blockingPeeks("BlockingPeeks", cc), blockingPeekTimeouts("BlockingPeekTimeouts", cc), + emptyPeeks("EmptyPeeks", cc), nonEmptyPeeks("NonEmptyPeeks", cc), + persistentDataUpdateBatches("PersistentDataUpdateBatches", cc), dirtyTagsProcessed("DirtyTagsProcessed", cc), + logId(interf.id()), protocolVersion(protocolVersion), newPersistentDataVersion(invalidVersion), + tLogData(tLogData), unrecoveredBefore(1), recoveredAt(1), recoveryTxnVersion(1), + logSystem(new AsyncVar>()), remoteTag(remoteTag), isPrimary(isPrimary), + logRouterTags(logRouterTags), logRouterPoppedVersion(0), logRouterPopToVersion(0), locality(tagLocalityInvalid), + recruitmentID(recruitmentID), logSpillType(logSpillType), allTags(tags.begin(), tags.end()), + terminated(tLogData->terminated.getFuture()), execOpCommitInProgress(false), txsTags(txsTags) { startRole(Role::TRANSACTION_LOG, interf.id(), tLogData->workerID, @@ -1532,6 +1533,7 @@ void commitMessages(TLogData* self, if (!taggedMessages.size()) { return; } + logData->tempTagMessageCount += taggedMessages.size(); int msgSize = 0; for (auto& i : taggedMessages) {