B Update Boost.ut, to fix exit status if any Approval Tests failed.

Now using boost-ext/ut@dde2cba
This fixes #87.
Docs and release notes updated.

Author: claremacrae

build/relnotes_x.y.z.md

@@ -5,6 +5,6 @@
 * **New features**
     * None
 * **Bug fixes**
-    * None
+    * Boost.UT tests now correctly return non-zero exit status if any Approval Tests failed. (#87)
 * **Other changes**
-    * Update to Boost.UT [commit 46a4f2e3f41212dd6db2a77bf7c3795cf461b55e](https://github.com/boost-experimental/ut/commit/46a4f2e3f41212dd6db2a77bf7c3795cf461b55e)
+    * Update to Boost.UT [commit dde2cba5123444faa82e5c17fcd99f68fe991d89](https://github.com/boost-experimental/ut/commit/dde2cba5123444faa82e5c17fcd99f68fe991d89)

doc/UsingUT.md

@@ -14,20 +14,12 @@ To change this file edit the source file and then execute ./run_markdown_templat
 ## Contents
 
   * [Getting Started With \[Boost\].UT](#getting-started-with-boostut)
-    * [Important Note: Issue 87](#important-note-issue-87)
     * [Requirements](#requirements)
     * [Usage examples](#usage-examples)<!-- endtoc -->
 
 
 ## Getting Started With \[Boost\].UT
 
-### Important Note: Issue 87
-
-* As of 2020-01-15, there is a known serious issue with using this test framework with Approval Tests, in that **the test framework does not currently report any Approval Test test failures via the exit status of the test program**.
-* This means that any CI builds or ctest runs will look like they succeeded, whereas they may in fact not have done.
-* For details and progress, please see [issue 87: Boost.UT tests spuriously pass, by returning 0 exit status even after failure](https://github.com/approvals/ApprovalTests.cpp/issues/87).  
----
-
 The [\[Boost\].UT](https://github.com/boost-experimental/ut) test framework works well with Approval Tests.
 
 \[Boost\].UT is a single header/single module, macro-free μ(micro)/Unit Testing Framework that requires C++17 / C++20

doc/mdsource/UsingUT.source.md

@@ -8,13 +8,6 @@ toc
 
 ## Getting Started With \[Boost\].UT
 
-### Important Note: Issue 87
-
-* As of 2020-01-15, there is a known serious issue with using this test framework with Approval Tests, in that **the test framework does not currently report any Approval Test test failures via the exit status of the test program**.
-* This means that any CI builds or ctest runs will look like they succeeded, whereas they may in fact not have done.
-* For details and progress, please see [issue 87: Boost.UT tests spuriously pass, by returning 0 exit status even after failure](https://github.com/approvals/ApprovalTests.cpp/issues/87).  
----
-
 The [\[Boost\].UT](https://github.com/boost-experimental/ut) test framework works well with Approval Tests.
 
 \[Boost\].UT is a single header/single module, macro-free μ(micro)/Unit Testing Framework that requires C++17 / C++20

third_party/ut/include/boost/ut.hpp

@@ -5,7 +5,7 @@
 // (See accompanying file LICENSE_1_0.txt or copy at
 // http://www.boost.org/LICENSE_1_0.txt)
 //
-//git version: 46a4f2e3f41212dd6db2a77bf7c3795cf461b55e
+//git version: dde2cba5123444faa82e5c17fcd99f68fe991d89
 #if defined(__cpp_modules)
 export module boost.ut;
 export import std;
@@ -1145,7 +1145,6 @@ class reporter {
   auto on(events::test_begin test_begin) -> void {
     printer_ << "Running \"" << test_begin.name << "\"...";
     fails_ = asserts_.fail;
-    exception_ = false;
   }
 
   auto on(events::test_run test_run) -> void {
@@ -1158,7 +1157,7 @@ class reporter {
   }
 
   auto on(events::test_end) -> void {
-    if (asserts_.fail > fails_ or exception_) {
+    if (asserts_.fail > fails_) {
       ++tests_.fail;
       printer_ << '\n'
                << printer_.colors().fail << "FAILED" << printer_.colors().none
@@ -1176,11 +1175,10 @@ class reporter {
   }
 
   auto on(events::exception exception) -> void {
-    exception_ = true;
     printer_ << "\n  " << printer_.colors().fail
              << "Unexpected exception with message:\n"
              << exception.what() << printer_.colors().none;
-    ++tests_.except;
+    ++asserts_.fail;
   }
 
   template <class TExpr>
@@ -1239,7 +1237,6 @@ class reporter {
     std::size_t pass{};
     std::size_t fail{};
     std::size_t skip{};
-    std::size_t except{};
   } tests_{};
 
   struct {
@@ -1248,7 +1245,6 @@ class reporter {
   } asserts_{};
 
   std::size_t fails_{};
-  bool exception_{};
 
   TPrinter printer_{};
 };
@@ -1338,19 +1334,18 @@ class runner {
         std::cout << '\n';
       }
 
-      active_exception_ = false;
 #if defined(__cpp_exceptions)
       try {
 #endif
         test();
 #if defined(__cpp_exceptions)
       } catch (const events::fatal_assertion&) {
       } catch (const std::exception& e) {
+        ++fails_;
         reporter_.on(events::exception{e.what()});
-        active_exception_ = true;
       } catch (...) {
+        ++fails_;
         reporter_.on(events::exception{"Unknown exception"});
-        active_exception_ = true;
       }
 #endif
 
@@ -1447,7 +1442,6 @@ class runner {
   std::vector<void (*)()> suites_{};
   std::size_t level_{};
   bool run_{};
-  bool active_exception_{};
   std::size_t fails_{};
   std::array<std::string_view, MaxPathSize> path_{};
   filter filter_{};
@@ -1468,6 +1462,20 @@ extern void on(events::test<utility::function<void()>>);
 extern void on(events::skip<>);
 [[nodiscard]] extern auto on(events::assertion<events::expr>) -> bool;
 extern void on(events::fatal_assertion);
+extern void on(events::log<bool>);
+extern void on(events::log<char>);
+extern void on(events::log<short>);
+extern void on(events::log<int>);
+extern void on(events::log<long>);
+extern void on(events::log<long long>);
+extern void on(events::log<unsigned>);
+extern void on(events::log<unsigned char>);
+extern void on(events::log<unsigned short>);
+extern void on(events::log<unsigned long>);
+extern void on(events::log<float>);
+extern void on(events::log<double>);
+extern void on(events::log<long double>);
+extern void on(events::log<const char*>);
 extern void on(events::log<utility::string_view>);
 #endif
 
@@ -1482,6 +1490,20 @@ void on(events::skip<> skip) { cfg<override>.on(skip); }
   return cfg<override>.on(static_cast<decltype(assertion)&&>(assertion));
 }
 void on(events::fatal_assertion assertion) { cfg<override>.on(assertion); }
+void on(events::log<bool> l) { cfg<override>.on(l); }
+void on(events::log<char> l) { cfg<override>.on(l); }
+void on(events::log<short> l) { cfg<override>.on(l); }
+void on(events::log<int> l) { cfg<override>.on(l); }
+void on(events::log<long> l) { cfg<override>.on(l); }
+void on(events::log<long long> l) { cfg<override>.on(l); }
+void on(events::log<unsigned> l) { cfg<override>.on(l); }
+void on(events::log<unsigned char> l) { cfg<override>.on(l); }
+void on(events::log<unsigned short> l) { cfg<override>.on(l); }
+void on(events::log<unsigned long> l) { cfg<override>.on(l); }
+void on(events::log<float> l) { cfg<override>.on(l); }
+void on(events::log<double> l) { cfg<override>.on(l); }
+void on(events::log<long double> l) { cfg<override>.on(l); }
+void on(events::log<const char*> l) { cfg<override>.on(l); }
 void on(events::log<utility::string_view> l) { cfg<override>.on(l); }
 #endif
 }  // namespace link