Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix order in which values returned by inverse link are captured #11

Open
ajinkya-k opened this issue Mar 23, 2025 · 1 comment
Open

Comments

@ajinkya-k
Copy link

In GLM v 2.0 the order of return values for the function inverselink(<:Link01) was changed for consistency and alignment with documented API. This affects the following lines:

μᵢ, omμᵢ, dμdη = inverselink(link, η[i])

μᵢ, omμᵢ, dμdη = inverselink(link, ηᵢ)

μ, _, dμdη = inverselink(link, η)

This function is also used in precisioninverselink but I don’t think it uses Link01 so it should not be a problem.

I will send a PR to fix these soon

@ajinkya-k
Copy link
Author

ajinkya-k commented Mar 23, 2025

the compat section may need some work. @ararslan I will need help with that part.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant