Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed order of returns for inverselink(::Link01), and other compatibility fixes for GLM2 #12

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ajinkya-k
Copy link

@ajinkya-k ajinkya-k commented Mar 23, 2025

see #11

TODOs:

  • bump version number to v0.2.0
  • bump compat for GLM to GLM >= 2
  • check if version bump is correct per SemVer
  • compat needs work

Before testing using Pkg; Pkg.develop("/path/to/dev/v2/GLM.jl/") must be run

…2, other changed need to make coded compatible with GLM2
@ajinkya-k
Copy link
Author

ajinkya-k commented Mar 23, 2025

How do we modify CI for this PR so that Pkg.develop("/path/to/dev/v2/GLM") can be added?

@ararslan
Copy link
Owner

Hi @ajinkya-k, thanks for the PR (and corresponding issue)! Since GLM 2.0 hasn't been released yet, I'd prefer to keep the compatibility limited to GLM 1.x for now. We can revisit this PR once GLM 2.0 has been released.

@ajinkya-k
Copy link
Author

That makes sense. I should have made it a draft PR, sorry

@ajinkya-k
Copy link
Author

Can we add label/tag to mark it as "future" or "v0.2" or something?

@ararslan ararslan marked this pull request as draft March 24, 2025 19:32
@ararslan
Copy link
Owner

I should have made it a draft PR, sorry

No worries! It can be made into a draft after the fact.

Can we add label/tag to mark it as "future" or "v0.2" or something?

Regarding v0.2, note that the changes made to GLM don't necessarily warrant a breaking release of this package, as this package's API wouldn't change. The fact that it uses GLM internally is an implementation detail in some sense.

@ajinkya-k
Copy link
Author

ajinkya-k commented Mar 24, 2025

right, but we would have to bump up the compat for GLM and the patch number atleast right? because if someone uses this package at 0.1.4 with GLM2 that will break things. I am guesing it can be 0.1.x but we would need a patch release that needs a GLM update

@ararslan
Copy link
Owner

if someone uses this package at 0.1.4 with GLM2 that will break things

They wouldn't be able to do that, since this package currently declares compatibility in Project.toml as GLM = "1", so GLM 2 would not be installable alongside BetaRegression.

I am guesing it can be 0.1.x but we would need a patch release that needs a GLM update

That's right

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants