Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

more efficient scoring iterations #13

Open
ajinkya-k opened this issue Mar 24, 2025 · 1 comment
Open

more efficient scoring iterations #13

ajinkya-k opened this issue Mar 24, 2025 · 1 comment

Comments

@ajinkya-k
Copy link

ajinkya-k commented Mar 24, 2025

Hi @ararslan

I had some ideas on how to speed up the scoring algorithm. Are you alreaady working along these lines? If not, is it okay if I take a crack at it?

@ajinkya-k
Copy link
Author

Some fairly minor tweaks got me some decent speedup!

julia> @be fit!(bm)
Benchmark: 2517 samples with 1 evaluation
 min    31.459 μs (242 allocs: 31.844 KiB)
 median 33.042 μs (242 allocs: 31.844 KiB)
 mean   37.471 μs (242 allocs: 31.844 KiB, 0.19% gc time)
 max    2.274 ms (242 allocs: 31.844 KiB, 97.26% gc time)

julia> @be BetaRegression.fit2!(bm)
Benchmark: 3146 samples with 1 evaluation
 min    26.958 μs (172 allocs: 27.406 KiB)
 median 27.584 μs (172 allocs: 27.406 KiB)
 mean   28.967 μs (172 allocs: 27.406 KiB, 0.15% gc time)
 max    1.844 ms (172 allocs: 27.406 KiB, 97.55% gc time)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant