Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚀 Feature: Modals under one style #1231

Open
1 task done
pabik opened this issue Oct 4, 2024 · 11 comments · May be fixed by #1434
Open
1 task done

🚀 Feature: Modals under one style #1231

pabik opened this issue Oct 4, 2024 · 11 comments · May be fixed by #1434
Assignees
Labels

Comments

@pabik
Copy link
Collaborator

pabik commented Oct 4, 2024

🔖 Feature description

Currently in an app all modals look different. I think it will benefit the UI to have them under one style.
Create new modal in settings/chatbots looks clean and I think should be the base case.
image
However I think an off modal click/tap should close modal.

Here for example what would need to be changed in upload modal.
image

  1. Add x at the top right corner to close.
  2. Remove 'Cancel'
  3. Make 'Train' button inactive by default, similarly to the one in new chatbot modal.
    image
    image
  4. Allow for a click outside modal to close it.

🎤 Why is this feature needed ?

Benefit UI.

✌️ How do you aim to achieve this?

  1. Add click outside modal to close it functionality.
  2. Check other modals to have same structure.

🔄️ Additional Information

No response

👀 Have you spent some time to check if this feature request has been raised before?

  • I checked and didn't find similar issue

Are you willing to submit PR?

None

@pabik pabik added help wanted Extra attention is needed hacktoberfest frontend labels Oct 4, 2024
@JeevaRamanathan
Copy link
Contributor

I noticed that another issue, Updated UI/UX for "Upload new document" modal is already in place. Could having multiple issues focused on updating the upload modal lead to some overlap?

@dartpain
Copy link
Contributor

dartpain commented Oct 4, 2024

Think this one is more about the color of the buttons for consistency.
Other issue is a larger change and we dont expect it to be delivered quickly as this one can.
I do appreciate your careful sift through other issues

@Kritika30032002
Copy link

assign this issue to me, interested to contribute @pabik @dartpain

@uttam282005
Copy link

@dartpain can you assign me this issue. I have explored the codebase and files related to this issue and I think I can work on this.

@utin-francis-peter
Copy link
Contributor

Hi, @Kritika30032002.

Please how's it going with the issue?

@Kritika30032002
Copy link

working on it

@prathamesh424
Copy link
Contributor

@ManishMadan2882 can you assign this issue to me

@AkashJana18
Copy link
Contributor

Hey @dartpain @ManishMadan2882 If this issue still persist I would like to work on it. Please assign it to me. Thank you.

@RohittCodes
Copy link
Contributor

hey @dartpain i see the issue is unassigned. I would like to work on it.

@RohittCodes
Copy link
Contributor

i guess the new upload modal has a few things in place already.

  • Allow for a click outside modal to close it.
  • Make 'Train' button inactive by default, similarly to the one in new chatbot modal.
    are the only 2 things to be done. do you want anything else to be included? @ManishMadan2882

@RohittCodes
Copy link
Contributor

oh sorry, if i understand it correct. the idea is to create a base modal for all the modals??

@RohittCodes RohittCodes linked a pull request Nov 12, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

9 participants