Add public print method that takes va_list instead of a variable number of arguments #41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
per1234
added
type: enhancement
|
Memory usage change @ 1cd099e
Click for full report table
Click for full report CSV |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was tryng to improve SE05X library and get rid of this buffer used only for debugging purpose. To this i wanted to reuse Arduino_DebugUtils library.
SE05X NXP internal library already has builtin debug macros and is written in C so i cannot directly call
Arduino_DebugUtils.printfunction as macro substitution, but i need to create a wrapper CPP function with varargs that calls theArduino_DebugUtils.printmethod.What i've found out is that is not possible to call a function which takes a variable number of arguments and passes them to some other function (which takes a variable number of arguments) so the proposal to add a new method that takes
va_listProbably another option is to use a variadic function template or using __builtin_apply but i did not investigate them and i think the proposed option is more straightforward.