From cdbc4d4ecc5c49bdd7cbf471a256fabe6001736f Mon Sep 17 00:00:00 2001 From: Lucio Rossi Date: Tue, 14 Jan 2025 11:27:06 +0100 Subject: [PATCH 1/2] mod: readSoc & more returning error_val on transmit error --- src/MAX17332.cpp | 10 +++++----- src/MAX17332.h | 1 + 2 files changed, 6 insertions(+), 5 deletions(-) diff --git a/src/MAX17332.cpp b/src/MAX17332.cpp index 6f0703f..ffc9c52 100644 --- a/src/MAX17332.cpp +++ b/src/MAX17332.cpp @@ -270,7 +270,7 @@ float MAX17332::readVCell() uint16_t v_int; if (!readRegisters(MAX17332_VCELLREP_REG, (uint8_t*) &v_int, sizeof(v_int))) { - return 0.0; + return ERROR_VAL; } return (float) v_int * VOLTAGE_LSB; @@ -282,7 +282,7 @@ float MAX17332::readCurrent() uint16_t val; if (!readRegisters(MAX17332_CURRREP_REG, (uint8_t*) &val, sizeof(val))) { - return 0.0; + return ERROR_VAL; } int16_t curr = static_cast(val); @@ -296,7 +296,7 @@ float MAX17332::readRSense() int value = readRegister(MAX17332_RSENSE_REG); if (!value) { - return 0.0; + return ERROR_VAL; } return (float) value * RSENSE_LSB; @@ -308,7 +308,7 @@ float MAX17332::readTemp() uint16_t val; if (!readRegisters(MAX17332_TEMP_REG, (uint8_t*) &val, sizeof(val))) { - return 0.0; + return ERROR_VAL; } int16_t temp = static_cast(val); @@ -322,7 +322,7 @@ float MAX17332::readSoc() uint16_t val; if (!readRegisters(MAX17332_REPSOC_REG, (uint8_t*) &val, sizeof(val))) { - return 0.0; + return ERROR_VAL; } int16_t soc = static_cast(val); diff --git a/src/MAX17332.h b/src/MAX17332.h index bcf363d..cf63cac 100644 --- a/src/MAX17332.h +++ b/src/MAX17332.h @@ -56,6 +56,7 @@ #define RSENSE_DEFAULT 10e-3 #define TEMP_LSB 0.00390625 ///< 1/256°C #define PERC_LSB 0.00390625 ///< 1/256% +#define ERROR_VAL -999.0 // COMMANDS #define COPY_NV_BLOCK_CMD 0xE904 ///< Copy shadow RAM to NVM From f2180504b73a0fc916e314bc58c6672c0c34e159 Mon Sep 17 00:00:00 2001 From: Lucio Rossi Date: Tue, 14 Jan 2025 11:29:35 +0100 Subject: [PATCH 2/2] ver 1.0.2 ready --- library.json | 2 +- library.properties | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/library.json b/library.json index 64b271c..7432cf7 100644 --- a/library.json +++ b/library.json @@ -20,7 +20,7 @@ "maintainer": true } ], - "version": "1.0.1", + "version": "1.0.2", "frameworks": ["arduino"], "platforms": "*", "headers": "Arduino_MAX17332.h" diff --git a/library.properties b/library.properties index 7366e2b..d63bb49 100644 --- a/library.properties +++ b/library.properties @@ -1,5 +1,5 @@ name=Arduino_MAX17332 -version=1.0.1 +version=1.0.2 author=Arduino, Lucio Rossi, Giovanni Bruno maintainer=Arduino sentence=A library for driving MAX17332 BMS.