Skip to content

Commit 6f93f9b

Browse files
authored
Pin Ace* libraries at last compatible version in CI workflow
Due to incompatibilities introduced during the initial ArduinoCore-API incorporation, the author of the AceTime and AceCommon libraries has added an #error directive that is triggered when the libraries are compiled by any version of arduino;samd that uses ArduinoCore-API: - https://github.com/bxparks/AceTime/blob/v1.6/src/AceTime.h#L25-L26 - https://github.com/bxparks/AceCommon/blob/v1.4.3/src/AceCommon.h#L44-L45 Ironically, compilation of the AceTime examples was added specifically to avoid any future breakage of compatibility with that library. Now the shoe is on the other foot.
1 parent f6148c3 commit 6f93f9b

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

.github/workflows/compile-examples.yml

+2-1
Original file line numberDiff line numberDiff line change
@@ -248,7 +248,8 @@ jobs:
248248
- name: LoRa
249249
- name: MKRWAN
250250
- name: WiFiNINA
251-
- name: AceTime
251+
252+
252253
- source-url: https://github.com/vidor-libraries/VidorPeripherals.git
253254
platforms: |
254255
# Use Board Manager to install the latest release of Arduino SAMD Boards to get the toolchain

0 commit comments

Comments
 (0)