Skip to content

Commit 0296899

Browse files
author
Federico Fissore
committed
BUILD_PROPERTIES_SOURCE_PATH was set to main .ino file location, while it must
be set to its container folder. Fixes #24 Signed-off-by: Federico Fissore <[email protected]>
1 parent f10d1b3 commit 0296899

File tree

2 files changed

+3
-2
lines changed

2 files changed

+3
-2
lines changed

src/arduino.cc/builder/setup_build_properties.go

+1
Original file line numberDiff line numberDiff line change
@@ -100,6 +100,7 @@ func (s *SetupBuildProperties) Run(context map[string]interface{}) error {
100100
if err != nil {
101101
return err
102102
}
103+
sourcePath = filepath.Dir(sourcePath)
103104
buildProperties[constants.BUILD_PROPERTIES_SOURCE_PATH] = sourcePath
104105
}
105106

src/arduino.cc/builder/test/setup_build_properties_test.go

+2-2
Original file line numberDiff line numberDiff line change
@@ -95,7 +95,7 @@ func TestSetupBuildProperties(t *testing.T) {
9595
require.Equal(t, Abs(t, "./downloaded_tools/avr-gcc/4.8.1-arduino5"), buildProperties["runtime.tools.avr-gcc.path"])
9696
require.Equal(t, Abs(t, "./downloaded_tools/avr-gcc/4.8.1-arduino5"), buildProperties["runtime.tools.avr-gcc-4.8.1-arduino5.path"])
9797

98-
require.Equal(t, Abs(t, filepath.Join("sketch1", "sketch.ino")), buildProperties[constants.BUILD_PROPERTIES_SOURCE_PATH])
98+
require.Equal(t, Abs(t, "sketch1"), buildProperties[constants.BUILD_PROPERTIES_SOURCE_PATH])
9999

100100
require.True(t, utils.MapStringStringHas(buildProperties, constants.BUILD_PROPERTIES_EXTRA_TIME_UTC))
101101
require.True(t, utils.MapStringStringHas(buildProperties, constants.BUILD_PROPERTIES_EXTRA_TIME_LOCAL))
@@ -236,7 +236,7 @@ func TestSetupBuildPropertiesWithMissingPropsFromParentPlatformTxtFiles(t *testi
236236
require.Equal(t, Abs(t, "./downloaded_tools/avr-gcc/4.8.1-arduino5"), buildProperties["runtime.tools.avr-gcc.path"])
237237
require.Equal(t, Abs(t, "./downloaded_tools/avr-gcc/4.8.1-arduino5"), buildProperties["runtime.tools.avr-gcc-4.8.1-arduino5.path"])
238238

239-
require.Equal(t, Abs(t, filepath.Join("sketch1", "sketch.ino")), buildProperties[constants.BUILD_PROPERTIES_SOURCE_PATH])
239+
require.Equal(t, Abs(t, "sketch1"), buildProperties[constants.BUILD_PROPERTIES_SOURCE_PATH])
240240

241241
require.True(t, utils.MapStringStringHas(buildProperties, constants.BUILD_PROPERTIES_EXTRA_TIME_UTC))
242242
require.True(t, utils.MapStringStringHas(buildProperties, constants.BUILD_PROPERTIES_EXTRA_TIME_LOCAL))

0 commit comments

Comments
 (0)