Use utils.ExecCommand for running ctags

matthijskooijman · matthijskooijman · commit f5dc854035c8 · 2017-06-16T21:13:38.000+02:00
This slightly simplifies the code.

Signed-off-by: Matthijs Kooijman &lt;matthijs@stdin.nl&gt;
diff --git a/src/arduino.cc/builder/ctags_runner.go b/src/arduino.cc/builder/ctags_runner.go
@@ -61,12 +61,7 @@ func (s *CTagsRunner) Run(ctx *types.Context) error {
 		return i18n.WrapError(err)
 	}
 
-	verbose := ctx.Verbose
-	if verbose {
-		fmt.Println(commandLine)
-	}
-
-	sourceBytes, err := command.Output()
+	sourceBytes, _, err := utils.ExecCommand(ctx, command, /* stdout */ utils.Capture, /* stderr */ utils.Ignore)
 	if err != nil {
 		return i18n.WrapError(err)
 	}

Original file line number	Diff line number	Diff line change
`@@ -61,12 +61,7 @@ func (s CTagsRunner) Run(ctx types.Context) error {`
`61`	`61`	`return i18n.WrapError(err)`
`62`	`62`	`}`
`63`	`63`
`64`		`- verbose := ctx.Verbose`
`65`		`- if verbose {`
`66`		`- fmt.Println(commandLine)`
`67`		`- }`
`68`		`-`
`69`		`- sourceBytes, err := command.Output()`
	`64`	`+ sourceBytes, _, err := utils.ExecCommand(ctx, command, /* stdout / utils.Capture, / stderr */ utils.Ignore)`
`70`	`65`	`if err != nil {`
`71`	`66`	`return i18n.WrapError(err)`
`72`	`67`	`}`