From 39724ec5024f24d8c742943e8694a292c4c06e34 Mon Sep 17 00:00:00 2001
From: Florian Hofer <info@florianhofer.it>
Date: Tue, 27 Apr 2021 20:41:39 +0200
Subject: [PATCH 01/27] ATSlave at standard return parse at_NetworkJoinStatus

---
 Projects/Multi/Applications/LoRa/AT_Slave/src/at.c | 11 ++++-------
 1 file changed, 4 insertions(+), 7 deletions(-)

diff --git a/Projects/Multi/Applications/LoRa/AT_Slave/src/at.c b/Projects/Multi/Applications/LoRa/AT_Slave/src/at.c
index 070afe92..24e3c31a 100644
--- a/Projects/Multi/Applications/LoRa/AT_Slave/src/at.c
+++ b/Projects/Multi/Applications/LoRa/AT_Slave/src/at.c
@@ -888,14 +888,11 @@ ATEerror_t at_NetworkJoinStatus(const char *param)
 
   mibReq.Type = MIB_NETWORK_JOINED;
   status = LoRaMacMibGetRequestConfirm(&mibReq);
+  CHECK_STATUS(status);
 
-  if (status == LORAMAC_STATUS_OK)
-  {
-	AT_PRINTF("+OK=");
-    print_d(mibReq.Param.IsNetworkJoined ? 1 : 0);
-    return AT_OK;
-  }
-  return AT_ERROR;
+  AT_PRINTF("+OK=");
+  print_d(mibReq.Param.IsNetworkJoined ? 1 : 0);
+  return AT_OK;
 }
 
 ATEerror_t at_SendBinary(const char *param)

From eb2a4945eab195c4a647fd740c6a279a2fa8db8d Mon Sep 17 00:00:00 2001
From: Florian Hofer <info@florianhofer.it>
Date: Tue, 27 Apr 2021 20:42:46 +0200
Subject: [PATCH 02/27] ATSlave: Add missing function declarations Lora.h

---
 .../Applications/LoRa/AT_Slave/inc/lora.h     | 58 ++++++++++++++++++-
 1 file changed, 57 insertions(+), 1 deletion(-)

diff --git a/Projects/Multi/Applications/LoRa/AT_Slave/inc/lora.h b/Projects/Multi/Applications/LoRa/AT_Slave/inc/lora.h
index fc30cd70..da453b41 100644
--- a/Projects/Multi/Applications/LoRa/AT_Slave/inc/lora.h
+++ b/Projects/Multi/Applications/LoRa/AT_Slave/inc/lora.h
@@ -333,10 +333,66 @@ uint8_t *lora_config_appeui_get(void);
 /**
   * @brief  Set Application EUI
   * @param  AppEUI
-  * @retval Nonoe
+  * @retval None
   */
 void lora_config_appeui_set(uint8_t appeui[8]);
 
+/**
+  * @brief  Get device address
+  * @param  None
+  * @retval DevAddr
+  */
+uint32_t lora_config_devaddr_get(void);
+
+/**
+  * @brief  Set device address
+  * @param  DevAddr
+  * @retval None
+  */
+void lora_config_devaddr_set(uint32_t devaddr);
+
+/**
+  * @brief  Set network id
+  * @param  NetId
+  * @retval None
+  */
+void lora_config_networkid_set(uint32_t networkid);
+
+/**
+  * @brief  Get network id
+  * @param  None
+  * @retval NetId
+  */
+uint32_t lora_config_networkid_get(void);
+
+/**
+  * @brief  Get network session key
+  * @param  None
+  * @retval NwkSKey
+  */
+uint8_t *lora_config_nwkskey_get(void);
+
+/**
+  * @brief  Set network session key
+  * @param  NwkSKey
+  * @retval None
+  */
+void lora_config_nwkskey_set(uint8_t nwkSKey[16]);
+
+/**
+  * @brief  Get application session key
+  * @param  None
+  * @retval AppSKey
+  */
+uint8_t *lora_config_appskey_get(void);
+
+/**
+  * @brief  Set application session key
+  * @param  AppSKey
+  * @retval None
+  */
+void lora_config_appskey_set(uint8_t appskey[16]);
+
 /**
   * @brief  Get Application Key
   * @param  None

From 1d8afac2e15914430de383fd4e26980b8c952f3f Mon Sep 17 00:00:00 2001
From: Florian Hofer <info@florianhofer.it>
Date: Tue, 27 Apr 2021 20:43:48 +0200
Subject: [PATCH 03/27] Driver/BSP Sx1276 add missing Reset function
 declaration

---
 Drivers/BSP/Components/sx1276/sx1276.h | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/Drivers/BSP/Components/sx1276/sx1276.h b/Drivers/BSP/Components/sx1276/sx1276.h
index 4c8d1369..472d6744 100644
--- a/Drivers/BSP/Components/sx1276/sx1276.h
+++ b/Drivers/BSP/Components/sx1276/sx1276.h
@@ -271,6 +271,11 @@ void SX1276BoardInit( LoRaBoardCallback_t *callbacks );
  */
 uint32_t SX1276Init( RadioEvents_t *events );
 
+/*!
+ * \brief Resets the SX1276
+ */
+void SX1276Reset( void );
+
 /*!
  * \brief Sets the SX1276 operating mode
  *

From dcf1372e6a07eaec9dd0c8821db90f4326f06d30 Mon Sep 17 00:00:00 2001
From: Florian Hofer <info@florianhofer.it>
Date: Tue, 27 Apr 2021 23:20:14 +0200
Subject: [PATCH 04/27] AT-slave main add missing includes phy chip/radio for
 reset p-through

---
 Drivers/BSP/Components/sx1276/sx1276.h               | 1 +
 Projects/Multi/Applications/LoRa/AT_Slave/src/main.c | 3 ++-
 2 files changed, 3 insertions(+), 1 deletion(-)

diff --git a/Drivers/BSP/Components/sx1276/sx1276.h b/Drivers/BSP/Components/sx1276/sx1276.h
index 472d6744..0f97c267 100644
--- a/Drivers/BSP/Components/sx1276/sx1276.h
+++ b/Drivers/BSP/Components/sx1276/sx1276.h
@@ -53,6 +53,7 @@ Maintainer: Miguel Luis and Gregory Cristian
 
 #include "sx1276Regs-Fsk.h"
 #include "sx1276Regs-LoRa.h"
+#include "radio.h"
 
 /*!
  * Radio wake-up time from sleep
diff --git a/Projects/Multi/Applications/LoRa/AT_Slave/src/main.c b/Projects/Multi/Applications/LoRa/AT_Slave/src/main.c
index 0199308e..57d6d1e5 100644
--- a/Projects/Multi/Applications/LoRa/AT_Slave/src/main.c
+++ b/Projects/Multi/Applications/LoRa/AT_Slave/src/main.c
@@ -66,7 +66,8 @@ Maintainer: Miguel Luis, Gregory Cristian and Wael Guibene
 #include "version.h"
 #include "command.h"
 #include "at.h"
-#include "lora.h"
+//#include "lora.h"
+#include "sx1276.h"
 
 /* Private typedef -----------------------------------------------------------*/
 /* Private define ------------------------------------------------------------*/

From d246fb1b8e01a92618f606b5255ddc00b8be7315 Mon Sep 17 00:00:00 2001
From: Florian Hofer <info@florianhofer.it>
Date: Wed, 28 Apr 2021 01:30:09 +0200
Subject: [PATCH 05/27] ATSlave added missing +OK= prints to *_get calls

---
 Projects/Multi/Applications/LoRa/AT_Slave/src/at.c | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/Projects/Multi/Applications/LoRa/AT_Slave/src/at.c b/Projects/Multi/Applications/LoRa/AT_Slave/src/at.c
index 24e3c31a..8c9a69d0 100644
--- a/Projects/Multi/Applications/LoRa/AT_Slave/src/at.c
+++ b/Projects/Multi/Applications/LoRa/AT_Slave/src/at.c
@@ -669,6 +669,7 @@ ATEerror_t at_Rx2Delay_get(const char *param)
   mib.Type = MIB_RECEIVE_DELAY_2;
   status = LoRaMacMibGetRequestConfirm(&mib);
   CHECK_STATUS(status);
+  AT_PRINTF("+OK=");
   print_u(mib.Param.ReceiveDelay2);
 
   return AT_OK;
@@ -891,7 +892,8 @@ ATEerror_t at_NetworkJoinStatus(const char *param)
   CHECK_STATUS(status);
 
   AT_PRINTF("+OK=");
-  print_d(mibReq.Param.IsNetworkJoined ? 1 : 0);
+  print_d((mibReq.Param.IsNetworkJoined) ? 1 : 0);
+
   return AT_OK;
 }
 
@@ -1090,30 +1092,35 @@ ATEerror_t at_ack_set(const char *param)
 
 ATEerror_t at_ack_get(const char *param)
 {
+  AT_PRINTF("+OK=");
   print_d (((lora_config_reqack_get() == ENABLE) ? 1 : 0));
   return AT_OK;
 }
 
 ATEerror_t at_isack_get(const char *param)
 {
+  AT_PRINTF("+OK=");
   print_d(((lora_config_isack_get() == ENABLE) ? 1 : 0));
   return AT_OK;
 }
 
 ATEerror_t at_snr_get(const char *param)
 {
+  AT_PRINTF("+OK=");
   print_u(lora_config_snr_get());
   return AT_OK;
 }
 
 ATEerror_t at_rssi_get(const char *param)
 {
+  AT_PRINTF("+OK=");
   print_d(lora_config_rssi_get());
   return AT_OK;
 }
 
 ATEerror_t at_bat_get(const char *param)
 {
+  AT_PRINTF("+OK=");
   print_u(HW_GetBatteryLevel());
   return AT_OK;
 }

From aa2b4dfdd679349746acef57ce1114de945449a9 Mon Sep 17 00:00:00 2001
From: Florian Hofer <info@florianhofer.it>
Date: Wed, 28 Apr 2021 17:33:32 +0200
Subject: [PATCH 06/27] Update version info 1.2.4

remove duplicate include main.cpp
---
 Projects/Multi/Applications/LoRa/AT_Slave/inc/version.h | 2 +-
 Projects/Multi/Applications/LoRa/AT_Slave/src/main.c    | 1 -
 2 files changed, 1 insertion(+), 2 deletions(-)

diff --git a/Projects/Multi/Applications/LoRa/AT_Slave/inc/version.h b/Projects/Multi/Applications/LoRa/AT_Slave/inc/version.h
index c66ddb99..321c8209 100644
--- a/Projects/Multi/Applications/LoRa/AT_Slave/inc/version.h
+++ b/Projects/Multi/Applications/LoRa/AT_Slave/inc/version.h
@@ -72,7 +72,7 @@ extern "C" {
 #define TEST_VERSION (uint32_t) 0x00000000  /*1 lsb is always 0 in releases   */
 #define LRWAN_VERSION  (uint32_t) 0x00001120  /*3 next hex is i_cube release*/
 #define VERSION   (uint32_t) (LORA_MAC_VERSION | LRWAN_VERSION | TEST_VERSION)
-#define AT_VERSION_STRING	"1.2.3"
+#define AT_VERSION_STRING	"1.2.4"
 #define AT_DEVICE_STRING	"ARD-078"
 
 /* Exported types ------------------------------------------------------------*/
diff --git a/Projects/Multi/Applications/LoRa/AT_Slave/src/main.c b/Projects/Multi/Applications/LoRa/AT_Slave/src/main.c
index 57d6d1e5..2f337d88 100644
--- a/Projects/Multi/Applications/LoRa/AT_Slave/src/main.c
+++ b/Projects/Multi/Applications/LoRa/AT_Slave/src/main.c
@@ -66,7 +66,6 @@ Maintainer: Miguel Luis, Gregory Cristian and Wael Guibene
 #include "version.h"
 #include "command.h"
 #include "at.h"
-//#include "lora.h"
 #include "sx1276.h"
 
 /* Private typedef -----------------------------------------------------------*/

From f44055655d0cabc5764dc6121d26f4c221d9040c Mon Sep 17 00:00:00 2001
From: Florian Hofer <info@florianhofer.it>
Date: Fri, 30 Apr 2021 00:13:56 +0200
Subject: [PATCH 07/27] ATSlave change to respond with +<CMD>=<VALUE> for
 getters on success

---
 .../Multi/Applications/LoRa/AT_Slave/inc/at.h |  2 +
 .../Multi/Applications/LoRa/AT_Slave/src/at.c | 76 +++++++++----------
 2 files changed, 40 insertions(+), 38 deletions(-)

diff --git a/Projects/Multi/Applications/LoRa/AT_Slave/inc/at.h b/Projects/Multi/Applications/LoRa/AT_Slave/inc/at.h
index b4d45fc4..5a228df0 100644
--- a/Projects/Multi/Applications/LoRa/AT_Slave/inc/at.h
+++ b/Projects/Multi/Applications/LoRa/AT_Slave/inc/at.h
@@ -130,6 +130,8 @@ typedef enum eATEerror
 #define AT_CHANMASK   "+CHANMASK"
 #define AT_CHANDEFMASK "+CHANDEFMASK"
 
+#define AT_EQ		  "="
+
 /* Exported functions ------------------------------------------------------- */
 
 /**
diff --git a/Projects/Multi/Applications/LoRa/AT_Slave/src/at.c b/Projects/Multi/Applications/LoRa/AT_Slave/src/at.c
index 8c9a69d0..6d58f6b1 100644
--- a/Projects/Multi/Applications/LoRa/AT_Slave/src/at.c
+++ b/Projects/Multi/Applications/LoRa/AT_Slave/src/at.c
@@ -182,14 +182,14 @@ ATEerror_t at_reset(const char *param)
 
 ATEerror_t at_DevEUI_get(const char *param)
 {
-  AT_PRINTF("+OK=");
+  AT_PRINTF(AT_DEUI AT_EQ);
   print_8_02x(lora_config_deveui_get());
   return AT_OK;
 }
 
 ATEerror_t at_AppEUI_get(const char *param)
 {
-  AT_PRINTF("+OK=");
+  AT_PRINTF(AT_APPEUI AT_EQ);
   print_8_02x(lora_config_appeui_get());
   return AT_OK;
 }
@@ -220,14 +220,14 @@ ATEerror_t at_DevAddr_set(const char *param)
 ATEerror_t at_DevAddr_get(const char *param)
 {
 
-  AT_PRINTF("+OK=");
+  AT_PRINTF(AT_DADDR AT_EQ);
   print_uint32_as_02x(lora_config_devaddr_get());
   return AT_OK;
 }
 
 ATEerror_t at_NetworkID_get(const char *param)
 {
-  AT_PRINTF("+OK=");
+  AT_PRINTF(AT_NWKID AT_EQ);
   print_uint32_as_02x(lora_config_networkid_get());
   return AT_OK;
 }
@@ -243,7 +243,7 @@ ATEerror_t at_NetworkID_set(const char *param)
 
 ATEerror_t at_AppKey_get(const char *param)
 {
-  AT_PRINTF("+OK=");
+  AT_PRINTF(AT_APPKEY AT_EQ);
   print_16_02x(lora_config_appkey_get());
   return AT_OK;
 }
@@ -264,7 +264,7 @@ ATEerror_t at_AppKey_set(const char *param)
 extern LoRaMacRegion_t globalRegion;
 ATEerror_t at_Band_get(const char *param)
 {
-  AT_PRINTF("+OK=");
+  AT_PRINTF(AT_BAND AT_EQ);
   print_d(globalRegion);
   return AT_OK;
 }
@@ -285,7 +285,7 @@ ATEerror_t at_Band_set(const char *param)
 
 ATEerror_t at_NwkSKey_get(const char *param)
 {
-  AT_PRINTF("+OK=");
+  AT_PRINTF(AT_NWKSKEY AT_EQ);
   print_16_02x(lora_config_nwkskey_get());
   return AT_OK;
 }
@@ -305,7 +305,7 @@ ATEerror_t at_NwkSKey_set(const char *param)
 
 ATEerror_t at_AppSKey_get(const char *param)
 {
-  AT_PRINTF("+OK=");
+  AT_PRINTF(AT_APPSKEY AT_EQ);
   print_16_02x(lora_config_appskey_get());
   return AT_OK;
 }
@@ -337,7 +337,7 @@ ATEerror_t at_ChannelMask_get(const char *param)
   mib.Type = MIB_CHANNELS_MASK;
   status = LoRaMacMibGetRequestConfirm(&mib);
   CHECK_STATUS(status);
-  AT_PRINTF("+OK=");
+  AT_PRINTF(AT_CHANMASK AT_EQ);
   AT_PRINTF("%04x%04x%04x%04x%04x%04x\r",
           mib.Param.ChannelsMask[0], mib.Param.ChannelsMask[1], mib.Param.ChannelsMask[2], mib.Param.ChannelsMask[3],
      mib.Param.ChannelsMask[4], mib.Param.ChannelsMask[5]);
@@ -372,7 +372,7 @@ ATEerror_t at_ChannelDefaultMask_get(const char *param)
   mib.Type = MIB_CHANNELS_DEFAULT_MASK;
   status = LoRaMacMibGetRequestConfirm(&mib);
   CHECK_STATUS(status);
-  AT_PRINTF("+OK=");
+  AT_PRINTF(AT_CHANDEFMASK AT_EQ);
   AT_PRINTF("%04x%04x%04x%04x%04x%04x\r",
           mib.Param.ChannelsDefaultMask[0], mib.Param.ChannelsDefaultMask[1], mib.Param.ChannelsDefaultMask[2], mib.Param.ChannelsDefaultMask[3],
      mib.Param.ChannelsDefaultMask[4], mib.Param.ChannelsDefaultMask[5]);
@@ -408,7 +408,7 @@ ATEerror_t at_ADR_get(const char *param)
   mib.Type = MIB_ADR;
   status = LoRaMacMibGetRequestConfirm(&mib);
   CHECK_STATUS(status);
-  AT_PRINTF("+OK=");
+  AT_PRINTF(AT_ADR AT_EQ);
   print_d(mib.Param.AdrEnable);
 
   return AT_OK;
@@ -444,7 +444,7 @@ ATEerror_t at_TransmitPower_get(const char *param)
   mib.Type = MIB_CHANNELS_TX_POWER;
   status = LoRaMacMibGetRequestConfirm(&mib);
   CHECK_STATUS(status);
-  AT_PRINTF("+OK=");
+  AT_PRINTF(AT_TXP AT_EQ);
   print_d(mib.Param.ChannelsTxPower);
 
   return AT_OK;
@@ -476,7 +476,7 @@ ATEerror_t at_DataRate_get(const char *param)
 
   status = LoRaMacMibGetRequestConfirm(&mib);
   CHECK_STATUS(status);
-  AT_PRINTF("+OK=");
+  AT_PRINTF(AT_DR AT_EQ);
   print_d(mib.Param.ChannelsDatarate);
 
   return AT_OK;
@@ -517,7 +517,7 @@ ATEerror_t at_DutyCycle_set(const char *param)
 
 ATEerror_t at_DutyCycle_get(const char *param)
 {
-  AT_PRINTF("+OK=");
+  AT_PRINTF(AT_DCS AT_EQ);
   if (lora_config_duty_cycle_get() == ENABLE)
     AT_PRINTF("1\r");
   else
@@ -535,7 +535,7 @@ ATEerror_t at_PublicNetwork_get(const char *param)
   mib.Type = MIB_PUBLIC_NETWORK;
   status = LoRaMacMibGetRequestConfirm(&mib);
   CHECK_STATUS(status);
-  AT_PRINTF("+OK=");
+  AT_PRINTF(AT_PNM AT_EQ);
   print_d(mib.Param.EnablePublicNetwork);
 
   return AT_OK;
@@ -570,7 +570,7 @@ ATEerror_t at_Rx2Frequency_get(const char *param)
   mib.Type = MIB_RX2_CHANNEL;
   status = LoRaMacMibGetRequestConfirm(&mib);
   CHECK_STATUS(status);
-  AT_PRINTF("+OK=");
+  AT_PRINTF(AT_RX2FQ AT_EQ);
   print_d(mib.Param.Rx2Channel.Frequency);
 
   return AT_OK;
@@ -604,7 +604,7 @@ ATEerror_t at_Rx2DataRate_get(const char *param)
   mib.Type = MIB_RX2_CHANNEL;
   status = LoRaMacMibGetRequestConfirm(&mib);
   CHECK_STATUS(status);
-  AT_PRINTF("+OK=");
+  AT_PRINTF(AT_RX2DR AT_EQ);
   print_d(mib.Param.Rx2Channel.Datarate);
 
   return AT_OK;
@@ -639,7 +639,7 @@ ATEerror_t at_Rx1Delay_get(const char *param)
   mib.Type = MIB_RECEIVE_DELAY_1;
   status = LoRaMacMibGetRequestConfirm(&mib);
   CHECK_STATUS(status);
-  AT_PRINTF("+OK=");
+  AT_PRINTF(AT_RX1DL AT_EQ);
   print_u(mib.Param.ReceiveDelay1);
 
   return AT_OK;
@@ -669,7 +669,7 @@ ATEerror_t at_Rx2Delay_get(const char *param)
   mib.Type = MIB_RECEIVE_DELAY_2;
   status = LoRaMacMibGetRequestConfirm(&mib);
   CHECK_STATUS(status);
-  AT_PRINTF("+OK=");
+  AT_PRINTF(AT_RX2DL AT_EQ);
   print_u(mib.Param.ReceiveDelay2);
 
   return AT_OK;
@@ -699,7 +699,7 @@ ATEerror_t at_JoinAcceptDelay1_get(const char *param)
   mib.Type = MIB_JOIN_ACCEPT_DELAY_1;
   status = LoRaMacMibGetRequestConfirm(&mib);
   CHECK_STATUS(status);
-  AT_PRINTF("+OK=");
+  AT_PRINTF(AT_JN1DL AT_EQ);
   print_u(mib.Param.JoinAcceptDelay1);
 
   return AT_OK;
@@ -729,7 +729,7 @@ ATEerror_t at_JoinAcceptDelay2_get(const char *param)
   mib.Type = MIB_JOIN_ACCEPT_DELAY_2;
   status = LoRaMacMibGetRequestConfirm(&mib);
   CHECK_STATUS(status);
-  AT_PRINTF("+OK=");
+  AT_PRINTF(AT_JN2DL AT_EQ);
   print_u(mib.Param.JoinAcceptDelay2);
 
   return AT_OK;
@@ -753,7 +753,7 @@ ATEerror_t at_JoinAcceptDelay2_set(const char *param)
 
 ATEerror_t at_NetworkJoinMode_get(const char *param)
 {
-  AT_PRINTF("+OK=");
+  AT_PRINTF(AT_NJM AT_EQ);
   print_d((lora_config_otaa_get() == ENABLE ? 1 : 0));
   return AT_OK;
 }
@@ -786,7 +786,7 @@ ATEerror_t at_UplinkCounter_get(const char *param)
   mib.Type = MIB_UPLINK_COUNTER;
   status = LoRaMacMibGetRequestConfirm(&mib);
   CHECK_STATUS(status);
-  AT_PRINTF("+OK=");
+  AT_PRINTF(AT_FCU AT_EQ);
   print_u(mib.Param.UpLinkCounter);
 
   return AT_OK;
@@ -816,7 +816,7 @@ ATEerror_t at_DownlinkCounter_get(const char *param)
   mib.Type = MIB_DOWNLINK_COUNTER;
   status = LoRaMacMibGetRequestConfirm(&mib);
   CHECK_STATUS(status);
-  AT_PRINTF("+OK=");
+  AT_PRINTF(AT_FCD AT_EQ);
   print_u(mib.Param.DownLinkCounter);
 
   return AT_OK;
@@ -846,7 +846,7 @@ ATEerror_t at_DeviceClass_get(const char *param)
   mib.Type = MIB_DEVICE_CLASS;
   status = LoRaMacMibGetRequestConfirm(&mib);
   CHECK_STATUS(status);
-  AT_PRINTF("+OK=%c\r", 'A' + mib.Param.Class);
+  AT_PRINTF(AT_CLASS AT_EQ "%c\r", 'A' + mib.Param.Class);
 
   return AT_OK;
 }
@@ -891,7 +891,7 @@ ATEerror_t at_NetworkJoinStatus(const char *param)
   status = LoRaMacMibGetRequestConfirm(&mibReq);
   CHECK_STATUS(status);
 
-  AT_PRINTF("+OK=");
+  AT_PRINTF(AT_NJS AT_EQ);
   print_d((mibReq.Param.IsNetworkJoined) ? 1 : 0);
 
   return AT_OK;
@@ -921,7 +921,7 @@ ATEerror_t at_ReceiveBinary(const char *param)
 {
   unsigned i;
 
-  AT_PRINTF("+RECV=");
+  AT_PRINTF(AT_RECVB AT_EQ);
   AT_PRINTF("%d,%d\r\n\n", ReceivedDataPort, ReceivedDataSize);
 
   for (i = 0; i < ReceivedDataSize; i++)
@@ -942,10 +942,9 @@ static uint8_t format_send_v2 = USE_HEX;
 ATEerror_t at_Receive(const char *param)
 {
 
-  AT_PRINTF("+RECV=");
-
   if (format_send_v2==0)
   {
+	  AT_PRINTF(AT_RECV AT_EQ);
 	  AT_PRINTF("%d,%d\r\n\n", ReceivedDataPort, ReceivedDataSize);
 	  for (unsigned i = 0; i < ReceivedDataSize; i++)
 	  {
@@ -954,6 +953,7 @@ ATEerror_t at_Receive(const char *param)
   }
   else
   {
+	  AT_PRINTF(AT_RECVB AT_EQ);
 	  AT_PRINTF("%d,%d\r\n\n", ReceivedDataPort, ReceivedDataSize*2);
 	  for (unsigned i = 0; i < ReceivedDataSize; i++)
 	  {
@@ -1022,7 +1022,7 @@ ATEerror_t at_SendV2Confirmation(const char *param)
 
 ATEerror_t at_Port_get(const char *param)
 {
-  AT_PRINTF("+OK=");
+  AT_PRINTF(AT_PORT AT_EQ);
   print_u(lora_config_application_port_get());
 
   return AT_OK;
@@ -1043,7 +1043,7 @@ ATEerror_t at_Port_set(const char *param)
 
 ATEerror_t at_Format_get(const char *param)
 {
-  AT_PRINTF("+OK=");
+  AT_PRINTF(AT_FORMAT AT_EQ);
   print_u(format_send_v2);
 
   return AT_OK;
@@ -1061,14 +1061,14 @@ ATEerror_t at_Format_set(const char *param)
 
 ATEerror_t at_version_get(const char *param)
 {
-  AT_PRINTF("+OK=");
+  AT_PRINTF(AT_VER AT_EQ);
   AT_PRINTF(AT_VERSION_STRING"\r");
   return AT_OK;
 }
 
 ATEerror_t at_device_get(const char *param)
 {
-  AT_PRINTF("+OK=");
+  AT_PRINTF(AT_DEV AT_EQ);
   AT_PRINTF(AT_DEVICE_STRING"\r");
   return AT_OK;
 }
@@ -1092,35 +1092,35 @@ ATEerror_t at_ack_set(const char *param)
 
 ATEerror_t at_ack_get(const char *param)
 {
-  AT_PRINTF("+OK=");
+  AT_PRINTF(AT_CFM AT_EQ);
   print_d (((lora_config_reqack_get() == ENABLE) ? 1 : 0));
   return AT_OK;
 }
 
 ATEerror_t at_isack_get(const char *param)
 {
-  AT_PRINTF("+OK=");
+  AT_PRINTF(AT_CFS AT_EQ);
   print_d(((lora_config_isack_get() == ENABLE) ? 1 : 0));
   return AT_OK;
 }
 
 ATEerror_t at_snr_get(const char *param)
 {
-  AT_PRINTF("+OK=");
+  AT_PRINTF(AT_SNR AT_EQ);
   print_u(lora_config_snr_get());
   return AT_OK;
 }
 
 ATEerror_t at_rssi_get(const char *param)
 {
-  AT_PRINTF("+OK=");
+  AT_PRINTF(AT_RSSI AT_EQ);
   print_d(lora_config_rssi_get());
   return AT_OK;
 }
 
 ATEerror_t at_bat_get(const char *param)
 {
-  AT_PRINTF("+OK=");
+  AT_PRINTF(AT_BAT AT_EQ);
   print_u(HW_GetBatteryLevel());
   return AT_OK;
 }

From c14491709b56fc896efc6e291c3cc9fb7e46f809 Mon Sep 17 00:00:00 2001
From: Florian Hofer <info@florianhofer.it>
Date: Sun, 2 May 2021 12:55:39 +0200
Subject: [PATCH 08/27] ATSlave add constant definition AT_EVENT

---
 Projects/Multi/Applications/LoRa/AT_Slave/inc/at.h   | 1 +
 Projects/Multi/Applications/LoRa/AT_Slave/src/lora.c | 3 ++-
 Projects/Multi/Applications/LoRa/AT_Slave/src/main.c | 2 +-
 3 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/Projects/Multi/Applications/LoRa/AT_Slave/inc/at.h b/Projects/Multi/Applications/LoRa/AT_Slave/inc/at.h
index 5a228df0..d74108ba 100644
--- a/Projects/Multi/Applications/LoRa/AT_Slave/inc/at.h
+++ b/Projects/Multi/Applications/LoRa/AT_Slave/inc/at.h
@@ -130,6 +130,7 @@ typedef enum eATEerror
 #define AT_CHANMASK   "+CHANMASK"
 #define AT_CHANDEFMASK "+CHANDEFMASK"
 
+#define AT_EVENT	  "+EVENT"
 #define AT_EQ		  "="
 
 /* Exported functions ------------------------------------------------------- */
diff --git a/Projects/Multi/Applications/LoRa/AT_Slave/src/lora.c b/Projects/Multi/Applications/LoRa/AT_Slave/src/lora.c
index 60699718..958c0aa7 100644
--- a/Projects/Multi/Applications/LoRa/AT_Slave/src/lora.c
+++ b/Projects/Multi/Applications/LoRa/AT_Slave/src/lora.c
@@ -64,6 +64,7 @@ Maintainer: Miguel Luis, Gregory Cristian and Wael Guibene
 #include "LoRaMac.h"
 #include "lora.h"
 #include "tiny_sscanf.h"
+#include "at.h"
 
 static lora_configuration_t lora_config = 
 {
@@ -880,7 +881,7 @@ void lora_fsm( LoRaMacRegion_t region )
     }
     case DEVICE_STATE_JOINED:
     {
-      PRINTF("+EVENT=1,1\r");
+      PRINTF(AT_EVENT AT_EQ "1,1\r");
       DeviceState = DEVICE_STATE_SLEEP;
       break;
     }
diff --git a/Projects/Multi/Applications/LoRa/AT_Slave/src/main.c b/Projects/Multi/Applications/LoRa/AT_Slave/src/main.c
index 2f337d88..84c8a4b5 100644
--- a/Projects/Multi/Applications/LoRa/AT_Slave/src/main.c
+++ b/Projects/Multi/Applications/LoRa/AT_Slave/src/main.c
@@ -297,7 +297,7 @@ int main(void)
 
   /* USER CODE BEGIN 1 */
   CMD_Init();
-  PRINTF("+EVENT=0,0");
+  PRINTF(AT_EVENT AT_EQ "0,0");
   /* USER CODE END 1 */
 
   /* Configure the Lora Stack*/

From e88b29a793da7f95b6c37a97bfcda5ae231435cc Mon Sep 17 00:00:00 2001
From: Florian Hofer <info@florianhofer.it>
Date: Sun, 2 May 2021 14:11:46 +0200
Subject: [PATCH 09/27] ATSlave vcom fixed unwanted human readable string in AT
 output

---
 Projects/Multi/Applications/LoRa/AT_Slave/src/vcom.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Projects/Multi/Applications/LoRa/AT_Slave/src/vcom.c b/Projects/Multi/Applications/LoRa/AT_Slave/src/vcom.c
index b3c9f75e..0acb1826 100644
--- a/Projects/Multi/Applications/LoRa/AT_Slave/src/vcom.c
+++ b/Projects/Multi/Applications/LoRa/AT_Slave/src/vcom.c
@@ -341,7 +341,7 @@ void vcom_IRQHandler(void)
 
   if (LL_LPUART_IsActiveFlag_PE(UARTX) || LL_LPUART_IsActiveFlag_FE(UARTX) || LL_LPUART_IsActiveFlag_ORE(UARTX) || LL_LPUART_IsActiveFlag_NE(UARTX))
   {
-    PRINTF("Error when receiving\n");
+    // PRINTF("Error when receiving\n"); Using return code
     /* clear error IT */
     LL_LPUART_ClearFlag_PE(UARTX);
     LL_LPUART_ClearFlag_FE(UARTX);

From b3f2e7289c8bedb4721e67770fdd185bfed666b4 Mon Sep 17 00:00:00 2001
From: Florian Hofer <info@florianhofer.it>
Date: Sun, 2 May 2021 19:00:24 +0200
Subject: [PATCH 10/27] ATSlave at.c fix parameter read for TransmitPower_set

---
 Projects/Multi/Applications/LoRa/AT_Slave/src/at.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Projects/Multi/Applications/LoRa/AT_Slave/src/at.c b/Projects/Multi/Applications/LoRa/AT_Slave/src/at.c
index 6d58f6b1..23d1c31e 100644
--- a/Projects/Multi/Applications/LoRa/AT_Slave/src/at.c
+++ b/Projects/Multi/Applications/LoRa/AT_Slave/src/at.c
@@ -457,7 +457,7 @@ ATEerror_t at_TransmitPower_set(const char *param)
   uint8_t ignored;
 
   mib.Type = MIB_CHANNELS_TX_POWER;
-  if (tiny_sscanf(param, "%hhu,%hhu", &ignored, &mib.Param.ChannelsTxPower) != 1)
+  if (tiny_sscanf(param, "%hhu,%hhu", &ignored, &mib.Param.ChannelsTxPower) != 2)
   {
     return AT_PARAM_ERROR;
   }

From ab564f7ce461cfa04879fe94de3407af1d742aa0 Mon Sep 17 00:00:00 2001
From: Florian Hofer <info@florianhofer.it>
Date: Sun, 2 May 2021 19:01:08 +0200
Subject: [PATCH 11/27] ATSlave at.c add check for correctness Networkid and
 devaddr set

---
 Projects/Multi/Applications/LoRa/AT_Slave/src/at.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/Projects/Multi/Applications/LoRa/AT_Slave/src/at.c b/Projects/Multi/Applications/LoRa/AT_Slave/src/at.c
index 23d1c31e..51f8f522 100644
--- a/Projects/Multi/Applications/LoRa/AT_Slave/src/at.c
+++ b/Projects/Multi/Applications/LoRa/AT_Slave/src/at.c
@@ -211,7 +211,8 @@ ATEerror_t at_AppEUI_set(const char *param)
 ATEerror_t at_DevAddr_set(const char *param)
 {
 	uint32_t DevAddr;
-	sscanf_uint32_as_hhx(param, &DevAddr);
+	if (sscanf_uint32_as_hhx(param, &DevAddr) != 4)
+			return AT_PARAM_ERROR;
 
 	lora_config_devaddr_set(DevAddr);
 	return AT_OK;
@@ -235,7 +236,8 @@ ATEerror_t at_NetworkID_get(const char *param)
 ATEerror_t at_NetworkID_set(const char *param)
 {
   uint32_t NetworkID;
-  sscanf_uint32_as_hhx(param, &NetworkID);
+  if (sscanf_uint32_as_hhx(param, &NetworkID) != 4)
+			return AT_PARAM_ERROR;
 
   lora_config_networkid_set(NetworkID);
   return AT_OK;

From 582875d285336da12779000681fec72be10577d1 Mon Sep 17 00:00:00 2001
From: Florian Hofer <info@florianhofer.it>
Date: Fri, 11 Jun 2021 11:38:10 +0200
Subject: [PATCH 12/27] Add command +MSIZE for the detection of max payload
 size

---
 Projects/Multi/Applications/LoRa/AT_Slave/inc/at.h    |  8 ++++++++
 Projects/Multi/Applications/LoRa/AT_Slave/inc/lora.h  |  7 +++++++
 .../Multi/Applications/LoRa/AT_Slave/inc/version.h    |  2 +-
 Projects/Multi/Applications/LoRa/AT_Slave/src/at.c    |  7 +++++++
 .../Multi/Applications/LoRa/AT_Slave/src/command.c    | 11 +++++++++++
 Projects/Multi/Applications/LoRa/AT_Slave/src/lora.c  |  7 +++++++
 6 files changed, 41 insertions(+), 1 deletion(-)

diff --git a/Projects/Multi/Applications/LoRa/AT_Slave/inc/at.h b/Projects/Multi/Applications/LoRa/AT_Slave/inc/at.h
index d74108ba..b63cb807 100644
--- a/Projects/Multi/Applications/LoRa/AT_Slave/inc/at.h
+++ b/Projects/Multi/Applications/LoRa/AT_Slave/inc/at.h
@@ -129,6 +129,7 @@ typedef enum eATEerror
 #define AT_CERTIF     "+CERTIF"
 #define AT_CHANMASK   "+CHANMASK"
 #define AT_CHANDEFMASK "+CHANDEFMASK"
+#define AT_MSIZE	  "+MSIZE"
 
 #define AT_EVENT	  "+EVENT"
 #define AT_EQ		  "="
@@ -705,6 +706,13 @@ ATEerror_t at_ChannelDefaultMask_get(const char *param);
  */
 ATEerror_t at_ChannelDefaultMask_set(const char *param);
 
+/**
+ * @brief  Gets the current maximum send and receive buffer size
+ * @param  String parameter
+ * @retval AT_OK, or an appropriate AT_xxx error code
+ */
+ATEerror_t at_MaxSize_get(const char *param);
+
 #ifdef __cplusplus
 }
 #endif
diff --git a/Projects/Multi/Applications/LoRa/AT_Slave/inc/lora.h b/Projects/Multi/Applications/LoRa/AT_Slave/inc/lora.h
index da453b41..3d8e217a 100644
--- a/Projects/Multi/Applications/LoRa/AT_Slave/inc/lora.h
+++ b/Projects/Multi/Applications/LoRa/AT_Slave/inc/lora.h
@@ -456,6 +456,13 @@ void lora_config_application_port_set(uint8_t application_port);
  */
 uint8_t lora_config_application_port_get(void);
 
+/**
+ * @brief  Get the maximum payload size for tx/rx
+ * @param  None
+ * @retval Maximum size in bytes (<255)
+ */
+uint8_t lora_config_max_size_get(void);
+
 /**
  * @brief  Launch LoraWan certification tests
  * @param  None
diff --git a/Projects/Multi/Applications/LoRa/AT_Slave/inc/version.h b/Projects/Multi/Applications/LoRa/AT_Slave/inc/version.h
index 321c8209..3ff0dbda 100644
--- a/Projects/Multi/Applications/LoRa/AT_Slave/inc/version.h
+++ b/Projects/Multi/Applications/LoRa/AT_Slave/inc/version.h
@@ -72,7 +72,7 @@ extern "C" {
 #define TEST_VERSION (uint32_t) 0x00000000  /*1 lsb is always 0 in releases   */
 #define LRWAN_VERSION  (uint32_t) 0x00001120  /*3 next hex is i_cube release*/
 #define VERSION   (uint32_t) (LORA_MAC_VERSION | LRWAN_VERSION | TEST_VERSION)
-#define AT_VERSION_STRING	"1.2.4"
+#define AT_VERSION_STRING	"1.2.4a"
 #define AT_DEVICE_STRING	"ARD-078"
 
 /* Exported types ------------------------------------------------------------*/
diff --git a/Projects/Multi/Applications/LoRa/AT_Slave/src/at.c b/Projects/Multi/Applications/LoRa/AT_Slave/src/at.c
index 51f8f522..806185e0 100644
--- a/Projects/Multi/Applications/LoRa/AT_Slave/src/at.c
+++ b/Projects/Multi/Applications/LoRa/AT_Slave/src/at.c
@@ -402,6 +402,13 @@ ATEerror_t at_ChannelDefaultMask_set(const char *param)
   return AT_OK;
 }
 
+ATEerror_t at_MaxSize_get (const char *param)
+{
+  AT_PRINTF(AT_MSIZE AT_EQ);
+  print_u(lora_config_max_size_get());
+  return AT_OK;
+}
+
 ATEerror_t at_ADR_get(const char *param)
 {
   MibRequestConfirm_t mib;
diff --git a/Projects/Multi/Applications/LoRa/AT_Slave/src/command.c b/Projects/Multi/Applications/LoRa/AT_Slave/src/command.c
index cffcdc6a..0555d8a7 100644
--- a/Projects/Multi/Applications/LoRa/AT_Slave/src/command.c
+++ b/Projects/Multi/Applications/LoRa/AT_Slave/src/command.c
@@ -655,6 +655,17 @@ static const struct ATCommand_s ATCommand[] =
     .set = at_ChannelDefaultMask_set,
     .run = at_return_error,
   },
+
+  {
+    .string = AT_MSIZE,
+    .size_string = sizeof(AT_MSIZE) - 1,
+#ifndef NO_HELP
+    .help_string = "AT"AT_MSIZE ": Retreives the actual maximum size for RX/TX messages\r\n",
+#endif
+    .get = at_MaxSize_get,
+    .set = at_return_error,
+    .run = at_return_error,
+  },
 };
 
 
diff --git a/Projects/Multi/Applications/LoRa/AT_Slave/src/lora.c b/Projects/Multi/Applications/LoRa/AT_Slave/src/lora.c
index 958c0aa7..528882db 100644
--- a/Projects/Multi/Applications/LoRa/AT_Slave/src/lora.c
+++ b/Projects/Multi/Applications/LoRa/AT_Slave/src/lora.c
@@ -1088,4 +1088,11 @@ uint8_t lora_config_application_port_get(void)
   return lora_config.application_port;
 }
 
+uint8_t lora_config_max_size_get(void)
+{
+  LoRaMacTxInfo_t txInfo;
+  (void)LoRaMacQueryTxPossible( 0, &txInfo );
+  return txInfo.MaxPossiblePayload;
+}
+
 /************************ (C) COPYRIGHT STMicroelectronics *****END OF FILE****/

From 3e12a242e0c8875fbdb033ab58e6317884e78abb Mon Sep 17 00:00:00 2001
From: Florian Hofer <info@florianhofer.it>
Date: Fri, 11 Jun 2021 13:44:59 +0200
Subject: [PATCH 13/27] ATSlave at/lora Upgrade buffers to allow 242/121 bytes
 send (binary)

---
 Projects/Multi/Applications/LoRa/AT_Slave/src/at.c   | 5 +++--
 Projects/Multi/Applications/LoRa/AT_Slave/src/lora.c | 2 +-
 2 files changed, 4 insertions(+), 3 deletions(-)

diff --git a/Projects/Multi/Applications/LoRa/AT_Slave/src/at.c b/Projects/Multi/Applications/LoRa/AT_Slave/src/at.c
index 806185e0..34a82bbc 100644
--- a/Projects/Multi/Applications/LoRa/AT_Slave/src/at.c
+++ b/Projects/Multi/Applications/LoRa/AT_Slave/src/at.c
@@ -68,6 +68,7 @@
  * @brief Max size of the data that can be received
  */
 #define MAX_RECEIVED_DATA 255
+#define MAX_SEND_DATA	242		// LoRaWan spec 1.0.4
 
 /* Private macro -------------------------------------------------------------*/
 /**
@@ -986,7 +987,7 @@ ATEerror_t at_SendV2(const char *param)
   {
     return AT_PARAM_ERROR;
   }
-  uint8_t data[64];
+  uint8_t data[MAX_SEND_DATA];
   int i = 0;
   // grab other #len bytes from the serial buffer
   while (i<length) {
@@ -1013,7 +1014,7 @@ ATEerror_t at_SendV2Confirmation(const char *param)
   {
 	return AT_PARAM_ERROR;
   }
-  uint8_t data[64];
+  uint8_t data[MAX_SEND_DATA];
   int i = 0;
   // grab other #len bytes from the serial buffer
   while (i<length) {
diff --git a/Projects/Multi/Applications/LoRa/AT_Slave/src/lora.c b/Projects/Multi/Applications/LoRa/AT_Slave/src/lora.c
index 528882db..00fc609c 100644
--- a/Projects/Multi/Applications/LoRa/AT_Slave/src/lora.c
+++ b/Projects/Multi/Applications/LoRa/AT_Slave/src/lora.c
@@ -125,7 +125,7 @@ static uint32_t DevAddr = LORAWAN_DEVICE_ADDRESS;
 /*!
  * User application data buffer size
  */
-#define LORAWAN_APP_DATA_BUFF_SIZE                           64
+#define LORAWAN_APP_DATA_BUFF_SIZE		242	//   max length for transmission LoRaWan 1.0.4
 
 /*!
  * User application data

From 1e42dec4f08096c3284787bf62dc33bf44eaa6bc Mon Sep 17 00:00:00 2001
From: Florian Hofer <info@florianhofer.it>
Date: Sat, 19 Jun 2021 14:56:08 +0200
Subject: [PATCH 14/27] ATSlave lora.c to use last set data rate for non ADR tx
 (was Init = DR0)

---
 .../Applications/LoRa/AT_Slave/inc/lora.h     | 15 ++++++
 .../Applications/LoRa/AT_Slave/inc/version.h  |  2 +-
 .../Multi/Applications/LoRa/AT_Slave/src/at.c | 46 ++++++++++++++++---
 .../Applications/LoRa/AT_Slave/src/lora.c     |  8 ++++
 4 files changed, 64 insertions(+), 7 deletions(-)

diff --git a/Projects/Multi/Applications/LoRa/AT_Slave/inc/lora.h b/Projects/Multi/Applications/LoRa/AT_Slave/inc/lora.h
index 3d8e217a..a55d2f94 100644
--- a/Projects/Multi/Applications/LoRa/AT_Slave/inc/lora.h
+++ b/Projects/Multi/Applications/LoRa/AT_Slave/inc/lora.h
@@ -463,6 +463,21 @@ uint8_t lora_config_application_port_get(void);
  */
 uint8_t lora_config_max_size_get(void);
 
+
+/**
+ * @brief  Get the data rate for non-ADR send
+ * @param  None
+ * @retval Maximum size in bytes (<255)
+ */
+int8_t lora_config_data_rate_get(void);
+
+/**
+ * @brief  Set the data rate for non-ADR send
+ * @param  The data rate to set
+ * @retval None
+ */
+void lora_config_data_rate_set(int8_t data_rate);
+
 /**
  * @brief  Launch LoraWan certification tests
  * @param  None
diff --git a/Projects/Multi/Applications/LoRa/AT_Slave/inc/version.h b/Projects/Multi/Applications/LoRa/AT_Slave/inc/version.h
index 3ff0dbda..321c8209 100644
--- a/Projects/Multi/Applications/LoRa/AT_Slave/inc/version.h
+++ b/Projects/Multi/Applications/LoRa/AT_Slave/inc/version.h
@@ -72,7 +72,7 @@ extern "C" {
 #define TEST_VERSION (uint32_t) 0x00000000  /*1 lsb is always 0 in releases   */
 #define LRWAN_VERSION  (uint32_t) 0x00001120  /*3 next hex is i_cube release*/
 #define VERSION   (uint32_t) (LORA_MAC_VERSION | LRWAN_VERSION | TEST_VERSION)
-#define AT_VERSION_STRING	"1.2.4a"
+#define AT_VERSION_STRING	"1.2.4"
 #define AT_DEVICE_STRING	"ARD-078"
 
 /* Exported types ------------------------------------------------------------*/
diff --git a/Projects/Multi/Applications/LoRa/AT_Slave/src/at.c b/Projects/Multi/Applications/LoRa/AT_Slave/src/at.c
index 34a82bbc..04b780b3 100644
--- a/Projects/Multi/Applications/LoRa/AT_Slave/src/at.c
+++ b/Projects/Multi/Applications/LoRa/AT_Slave/src/at.c
@@ -438,6 +438,13 @@ ATEerror_t at_ADR_set(const char *param)
       mib.Param.AdrEnable = param[0] - '0';
       status = LoRaMacMibSetRequestConfirm(&mib);
       CHECK_STATUS(status);
+
+      if (!mib.Param.AdrEnable){
+    	  mib.Type = MIB_CHANNELS_DEFAULT_DATARATE;
+    	  mib.Param.ChannelsDatarate = lora_config_data_rate_get(); // apply non-ADR data rate as default to MAC layer
+    	  status = LoRaMacMibSetRequestConfirm(&mib);
+    	  CHECK_STATUS(status);
+      }
       break;
     default:
       return AT_PARAM_ERROR;
@@ -482,10 +489,19 @@ ATEerror_t at_DataRate_get(const char *param)
   MibRequestConfirm_t mib;
   LoRaMacStatus_t status;
 
-  mib.Type = MIB_CHANNELS_DATARATE;
-
+  mib.Type = MIB_ADR;
   status = LoRaMacMibGetRequestConfirm(&mib);
   CHECK_STATUS(status);
+
+  if (mib.Param.AdrEnable){
+	  mib.Type = MIB_CHANNELS_DATARATE;
+
+	  status = LoRaMacMibGetRequestConfirm(&mib);
+	  CHECK_STATUS(status);
+  }
+  else
+	  mib.Param.ChannelsDatarate = lora_config_data_rate_get();
+
   AT_PRINTF(AT_DR AT_EQ);
   print_d(mib.Param.ChannelsDatarate);
 
@@ -496,15 +512,33 @@ ATEerror_t at_DataRate_set(const char *param)
 {
   MibRequestConfirm_t mib;
   LoRaMacStatus_t status;
+  uint8_t new_dr=0;
+
 
-  mib.Type = MIB_CHANNELS_DATARATE;
-  if (tiny_sscanf(param, "%hhu", &mib.Param.ChannelsDatarate) != 1)
+  if (tiny_sscanf(param, "%hhu", &new_dr) != 1)
   {
-    return AT_PARAM_ERROR;
+	return AT_PARAM_ERROR;
   }
-  status = LoRaMacMibSetRequestConfirm(&mib);
+
+  mib.Type = MIB_ADR;
+  status = LoRaMacMibGetRequestConfirm(&mib);
   CHECK_STATUS(status);
 
+  if (!mib.Param.AdrEnable){
+	  mib.Type = MIB_CHANNELS_DATARATE;
+	  mib.Param.ChannelsDatarate = new_dr;
+	  status = LoRaMacMibSetRequestConfirm(&mib);
+	  CHECK_STATUS(status);
+  }
+  else {
+	  // Uses MIB_CHANNELS_DEFAULT_DATARATE to test for TX possible with non ADR
+	  mib.Type = MIB_CHANNELS_DEFAULT_DATARATE;
+	  mib.Param.ChannelsDatarate = new_dr;
+	  status = LoRaMacMibSetRequestConfirm(&mib);
+	  CHECK_STATUS(status);
+	  // Set lora_config reference
+	  lora_config_data_rate_set((int8_t)new_dr);
+  }
   return AT_OK;
 }
 
diff --git a/Projects/Multi/Applications/LoRa/AT_Slave/src/lora.c b/Projects/Multi/Applications/LoRa/AT_Slave/src/lora.c
index 00fc609c..624502f3 100644
--- a/Projects/Multi/Applications/LoRa/AT_Slave/src/lora.c
+++ b/Projects/Multi/Applications/LoRa/AT_Slave/src/lora.c
@@ -1095,4 +1095,12 @@ uint8_t lora_config_max_size_get(void)
   return txInfo.MaxPossiblePayload;
 }
 
+int8_t lora_config_data_rate_get(void){
+	return LoRaParamInit->TxDatarate;
+}
+
+void lora_config_data_rate_set(int8_t data_rate){
+	LoRaParamInit->TxDatarate = data_rate;
+}
+
 /************************ (C) COPYRIGHT STMicroelectronics *****END OF FILE****/

From 0f278fe42c95d9b0c759b2547456f316ab9b7c8a Mon Sep 17 00:00:00 2001
From: Florian Hofer <info@florianhofer.it>
Date: Mon, 21 Jun 2021 10:16:17 +0200
Subject: [PATCH 15/27] Remove +ACK print in the sx1276 driver

---
 Drivers/BSP/Components/sx1276/sx1276.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/Drivers/BSP/Components/sx1276/sx1276.c b/Drivers/BSP/Components/sx1276/sx1276.c
index c4b7e562..8f2c6e5e 100644
--- a/Drivers/BSP/Components/sx1276/sx1276.c
+++ b/Drivers/BSP/Components/sx1276/sx1276.c
@@ -1644,8 +1644,6 @@ void SX1276OnDio0Irq( void )
                     if( ( RadioEvents != NULL ) && ( RadioEvents->RxDone != NULL ) )
                     {
                         RadioEvents->RxDone( RxTxBuffer, SX1276.Settings.LoRaPacketHandler.Size, SX1276.Settings.LoRaPacketHandler.RssiValue, SX1276.Settings.LoRaPacketHandler.SnrValue );
-                        PRINTF( "+ACK\r" );
-                        //PRINTF("+RECV=");
                     }
                 }
                 break;

From 9f76e9e974ce441da69f911c3ed1438cd02f4623 Mon Sep 17 00:00:00 2001
From: Florian Hofer <info@florianhofer.it>
Date: Mon, 21 Jun 2021 10:48:17 +0200
Subject: [PATCH 16/27] Update readme

---
 README.md | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/README.md b/README.md
index de37ba0e..a2d1549a 100644
--- a/README.md
+++ b/README.md
@@ -23,13 +23,15 @@ All the code maintains its original license.
 | AT+CERTIF    | Set the module in LoraWan Certification Mode |
 | AT+CFM       | Get or Set the confirmation mode (0-1) |
 | AT+CFS       | Get confirmation status of the last AT+SEND (0-1) |
+| AT+CHANMASK  | Gets the current region's channel mask, note this is reset when changing regions |
+| AT+CHANDEFMASK | Gets the current region's default mask, note this is reset when changing regions |  |
 | AT+CLASS     | Get or Set the Device Class |
 | AT+CTX       | send with confirmation |
 | AT+DEV       | Get the version of the AT_Slave FW |
 | AT+DEVADDR   | Get or Set the Device address |
 | AT+DEVEUI    | Get the Device EUI |
 | AT+DFORMAT   | select hex or binary format |
-| AT+DR        | Get or Set the Data Rate. (0-7 corresponding to DR_X) |
+| AT+DR        | Get or Set the Data Rate. (0-7 corresponding to DR_X). If ADR is off, it sets also the default data rate |
 | AT+DUTYCYCLE | Get or Set the ETSI Duty Cycle setting - 0=disable, 1=enable - Only for testing |
 | AT+FCD       | Get or Set the Frame Counter Downlink |
 | AT+FCU       | Get or Set the Frame Counter Uplink |
@@ -38,6 +40,7 @@ All the code maintains its original license.
 | AT+JN2DL     | Get or Set the Join Accept Delay between the end of the Tx and the Join Rx Window 2 in ms |
 | AT+JOIN      | Join network |
 | AT+MODE      | Get or Set the Network Join Mode. (0: ABP, 1: OTAA) |
+| AT+MSIZE     | Get the maximum send/receive size for the actual data rate |
 | AT+NJS       | Get the join status |
 | AT+NWK       | Get or Set the public network mode. (0: off, 1: on) |
 | AT+NWKSKEY   | Get or Set the Network Session Key |
@@ -62,5 +65,3 @@ All the code maintains its original license.
 | AT+TTONE     | Starts RF Tone test |
 | AT+UTX       | send without confirmation |
 | AT+VER       | Get the version of the AT_Slave FW|
-| AT+CHANMASK  | Gets the current region's channel mask, note this is reset when changing regions |
-| AT+CHANDEFMASK | Gets the current region's default mask, note this is reset when changing regions |  |

From f849548ab7f7f77bdf6179708103a414aaf2efb7 Mon Sep 17 00:00:00 2001
From: Florian Hofer <info@florianhofer.it>
Date: Mon, 21 Jun 2021 12:03:55 +0200
Subject: [PATCH 17/27] ATSlave Fix at_DataRate_set check for ADR inverted

---
 Projects/Multi/Applications/LoRa/AT_Slave/src/at.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Projects/Multi/Applications/LoRa/AT_Slave/src/at.c b/Projects/Multi/Applications/LoRa/AT_Slave/src/at.c
index 04b780b3..fc9bb8f8 100644
--- a/Projects/Multi/Applications/LoRa/AT_Slave/src/at.c
+++ b/Projects/Multi/Applications/LoRa/AT_Slave/src/at.c
@@ -524,7 +524,7 @@ ATEerror_t at_DataRate_set(const char *param)
   status = LoRaMacMibGetRequestConfirm(&mib);
   CHECK_STATUS(status);
 
-  if (!mib.Param.AdrEnable){
+  if (mib.Param.AdrEnable){
 	  mib.Type = MIB_CHANNELS_DATARATE;
 	  mib.Param.ChannelsDatarate = new_dr;
 	  status = LoRaMacMibSetRequestConfirm(&mib);

From 22e5844e6c8a816495e3cbcb362fde2ef5a49b76 Mon Sep 17 00:00:00 2001
From: Florian Hofer <info@florianhofer.it>
Date: Tue, 22 Jun 2021 14:04:17 +0200
Subject: [PATCH 18/27] ATSlave Fix at_DataRate_set patch sequence
 Init/Default/Channel DataRate

---
 .../Multi/Applications/LoRa/AT_Slave/src/at.c  | 18 ++++++------------
 1 file changed, 6 insertions(+), 12 deletions(-)

diff --git a/Projects/Multi/Applications/LoRa/AT_Slave/src/at.c b/Projects/Multi/Applications/LoRa/AT_Slave/src/at.c
index fc9bb8f8..60c2d1b7 100644
--- a/Projects/Multi/Applications/LoRa/AT_Slave/src/at.c
+++ b/Projects/Multi/Applications/LoRa/AT_Slave/src/at.c
@@ -440,7 +440,7 @@ ATEerror_t at_ADR_set(const char *param)
       CHECK_STATUS(status);
 
       if (!mib.Param.AdrEnable){
-    	  mib.Type = MIB_CHANNELS_DEFAULT_DATARATE;
+    	  mib.Type = MIB_CHANNELS_DATARATE;
     	  mib.Param.ChannelsDatarate = lora_config_data_rate_get(); // apply non-ADR data rate as default to MAC layer
     	  status = LoRaMacMibSetRequestConfirm(&mib);
     	  CHECK_STATUS(status);
@@ -524,18 +524,12 @@ ATEerror_t at_DataRate_set(const char *param)
   status = LoRaMacMibGetRequestConfirm(&mib);
   CHECK_STATUS(status);
 
+  mib.Type = MIB_CHANNELS_DATARATE;
+  mib.Param.ChannelsDatarate = new_dr;
+  status = LoRaMacMibSetRequestConfirm(&mib);
+  CHECK_STATUS(status);
+
   if (mib.Param.AdrEnable){
-	  mib.Type = MIB_CHANNELS_DATARATE;
-	  mib.Param.ChannelsDatarate = new_dr;
-	  status = LoRaMacMibSetRequestConfirm(&mib);
-	  CHECK_STATUS(status);
-  }
-  else {
-	  // Uses MIB_CHANNELS_DEFAULT_DATARATE to test for TX possible with non ADR
-	  mib.Type = MIB_CHANNELS_DEFAULT_DATARATE;
-	  mib.Param.ChannelsDatarate = new_dr;
-	  status = LoRaMacMibSetRequestConfirm(&mib);
-	  CHECK_STATUS(status);
 	  // Set lora_config reference
 	  lora_config_data_rate_set((int8_t)new_dr);
   }

From fcbf15e9d19b2bbf231fd69bf2a0c3b92846d1f6 Mon Sep 17 00:00:00 2001
From: Florian Hofer <info@florianhofer.it>
Date: Tue, 22 Jun 2021 14:32:16 +0200
Subject: [PATCH 19/27] ATSlave fix uninitialized port for MAC filler frame

---
 Projects/Multi/Applications/LoRa/AT_Slave/src/lora.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Projects/Multi/Applications/LoRa/AT_Slave/src/lora.c b/Projects/Multi/Applications/LoRa/AT_Slave/src/lora.c
index 624502f3..b0190556 100644
--- a/Projects/Multi/Applications/LoRa/AT_Slave/src/lora.c
+++ b/Projects/Multi/Applications/LoRa/AT_Slave/src/lora.c
@@ -241,6 +241,7 @@ static bool SendFrame( void )
     {
         // Send empty frame in order to flush MAC commands
         mcpsReq.Type = MCPS_UNCONFIRMED;
+        mcpsReq.Req.Unconfirmed.fPort = 0;
         mcpsReq.Req.Unconfirmed.fBuffer = NULL;
         mcpsReq.Req.Unconfirmed.fBufferSize = 0;
         mcpsReq.Req.Unconfirmed.Datarate = LoRaParamInit->TxDatarate;

From 64a8bfa7d405e6837c420d94f75ab663373f521a Mon Sep 17 00:00:00 2001
From: Florian Hofer <info@florianhofer.it>
Date: Tue, 22 Jun 2021 15:06:08 +0200
Subject: [PATCH 20/27] ATSlave Lora lora_send fix app-port set with invalid
 string AT_SEND

---
 .../Multi/Applications/LoRa/AT_Slave/src/lora.c    | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/Projects/Multi/Applications/LoRa/AT_Slave/src/lora.c b/Projects/Multi/Applications/LoRa/AT_Slave/src/lora.c
index b0190556..3a5ab205 100644
--- a/Projects/Multi/Applications/LoRa/AT_Slave/src/lora.c
+++ b/Projects/Multi/Applications/LoRa/AT_Slave/src/lora.c
@@ -654,20 +654,17 @@ LoRaMacStatus_t lora_join(void)
  */
 LoRaMacStatus_t lora_send(const char *buf, unsigned bufSize, unsigned binary, unsigned raw)
 {
+  if (raw == 1)
+	  goto on_raw;
+
   uint32_t appport;
 
-  if (raw == 1) {
-	  goto on_raw;
-  }
   /* read and set the application port */
   if (1 != tiny_sscanf(buf, "%u:", &appport))
   {
     PRINTF("AT+SEND without the application port");
     return LORAMAC_STATUS_PARAMETER_INVALID;
   }
-  
-  /* set the application port to send to */
-  lora_config_application_port_set(appport);
 
   /* skip the application port */
   while (('0' <= buf[0]) && (buf[0] <= '9'))
@@ -682,7 +679,10 @@ LoRaMacStatus_t lora_send(const char *buf, unsigned bufSize, unsigned binary, un
   }
   buf ++;
   bufSize --;
-  
+
+  /* set the application port to send to */
+  lora_config_application_port_set(appport);
+
 on_raw:
   OnSendEvent();
 

From 8805bf3888be917936627c35eb0e43eda6e825d8 Mon Sep 17 00:00:00 2001
From: Florian Hofer <info@florianhofer.it>
Date: Sat, 10 Jul 2021 17:48:56 +0200
Subject: [PATCH 21/27] ATSlave at.c print frequency fix unsigned

---
 Projects/Multi/Applications/LoRa/AT_Slave/src/at.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Projects/Multi/Applications/LoRa/AT_Slave/src/at.c b/Projects/Multi/Applications/LoRa/AT_Slave/src/at.c
index 60c2d1b7..b03359a0 100644
--- a/Projects/Multi/Applications/LoRa/AT_Slave/src/at.c
+++ b/Projects/Multi/Applications/LoRa/AT_Slave/src/at.c
@@ -609,7 +609,7 @@ ATEerror_t at_Rx2Frequency_get(const char *param)
   status = LoRaMacMibGetRequestConfirm(&mib);
   CHECK_STATUS(status);
   AT_PRINTF(AT_RX2FQ AT_EQ);
-  print_d(mib.Param.Rx2Channel.Frequency);
+  print_u(mib.Param.Rx2Channel.Frequency);
 
   return AT_OK;
 }

From 72da24fa95c4492288ed2863413490a9af773ee8 Mon Sep 17 00:00:00 2001
From: Florian Hofer <info@florianhofer.it>
Date: Sun, 25 Jul 2021 17:14:09 +0200
Subject: [PATCH 22/27] ATSlave AT upgrade to 242bytes binary send, HEX cut-off
 to 242

---
 Projects/Multi/Applications/LoRa/AT_Slave/src/at.c | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/Projects/Multi/Applications/LoRa/AT_Slave/src/at.c b/Projects/Multi/Applications/LoRa/AT_Slave/src/at.c
index b03359a0..653b0b4f 100644
--- a/Projects/Multi/Applications/LoRa/AT_Slave/src/at.c
+++ b/Projects/Multi/Applications/LoRa/AT_Slave/src/at.c
@@ -68,7 +68,7 @@
  * @brief Max size of the data that can be received
  */
 #define MAX_RECEIVED_DATA 255
-#define MAX_SEND_DATA	242		// LoRaWan spec 1.0.4
+#define MAX_SEND_DATA	484		// LoRaWan spec 1.0.4 = 242*2 (used for binary send HEX chars)
 
 /* Private macro -------------------------------------------------------------*/
 /**
@@ -1011,7 +1011,8 @@ ATEerror_t at_SendV2(const char *param)
 
   size_t length = 0;
 
-  if (tiny_sscanf(param, "%hhu", &length) != 1)
+  if (tiny_sscanf(param, "%hu", &length) != 1
+		  || length > MAX_SEND_DATA)
   {
     return AT_PARAM_ERROR;
   }
@@ -1038,7 +1039,8 @@ ATEerror_t at_SendV2Confirmation(const char *param)
 
   size_t length = 0;
 
-  if (tiny_sscanf(param, "%hhu", &length) != 1)
+  if (tiny_sscanf(param, "%hu", &length) != 1
+		  || length > MAX_SEND_DATA)
   {
 	return AT_PARAM_ERROR;
   }

From da2917c315a00edbf0183597711c7c062de9e762 Mon Sep 17 00:00:00 2001
From: Florian Hofer <info@florianhofer.it>
Date: Tue, 24 Aug 2021 11:53:16 +0200
Subject: [PATCH 23/27] AT_Slave at merged sendV2/confirmed and added check for
 AT_ERROR_RX_CHAR

---
 .../Multi/Applications/LoRa/AT_Slave/src/at.c | 55 ++++++++-----------
 1 file changed, 24 insertions(+), 31 deletions(-)

diff --git a/Projects/Multi/Applications/LoRa/AT_Slave/src/at.c b/Projects/Multi/Applications/LoRa/AT_Slave/src/at.c
index 653b0b4f..4519511c 100644
--- a/Projects/Multi/Applications/LoRa/AT_Slave/src/at.c
+++ b/Projects/Multi/Applications/LoRa/AT_Slave/src/at.c
@@ -60,6 +60,7 @@
 #include "version.h"
 #include "hw_msp.h"
 #include "test_rf.h"
+#include "command.h"
 
 /* External variables --------------------------------------------------------*/
 /* Private typedef -----------------------------------------------------------*/
@@ -84,6 +85,10 @@
  * @brief Buffer that contains the last received data
  */
 static char ReceivedData[MAX_RECEIVED_DATA];
+/**
+ * @brief Buffer that contains the last send buffer
+ */
+static char SendData[MAX_SEND_DATA];
 
 /**
  * @brief Size if the buffer that contains the last received data
@@ -960,7 +965,7 @@ ATEerror_t at_ReceiveBinary(const char *param)
   unsigned i;
 
   AT_PRINTF(AT_RECVB AT_EQ);
-  AT_PRINTF("%d,%d\r\n\n", ReceivedDataPort, ReceivedDataSize);
+  AT_PRINTF("%u,%u\r\n\n", ReceivedDataPort, ReceivedDataSize);
 
   for (i = 0; i < ReceivedDataSize; i++)
   {
@@ -983,7 +988,7 @@ ATEerror_t at_Receive(const char *param)
   if (format_send_v2==0)
   {
 	  AT_PRINTF(AT_RECV AT_EQ);
-	  AT_PRINTF("%d,%d\r\n\n", ReceivedDataPort, ReceivedDataSize);
+	  AT_PRINTF("%u,%u\r\n\n", ReceivedDataPort, ReceivedDataSize);
 	  for (unsigned i = 0; i < ReceivedDataSize; i++)
 	  {
 		AT_PRINTF("%c", ReceivedData[i]);
@@ -992,7 +997,7 @@ ATEerror_t at_Receive(const char *param)
   else
   {
 	  AT_PRINTF(AT_RECVB AT_EQ);
-	  AT_PRINTF("%d,%d\r\n\n", ReceivedDataPort, ReceivedDataSize*2);
+	  AT_PRINTF("%u,%u\r\n\n", ReceivedDataPort, ReceivedDataSize*2);
 	  for (unsigned i = 0; i < ReceivedDataSize; i++)
 	  {
 	    AT_PRINTF("%02x", ReceivedData[i]);
@@ -1004,60 +1009,48 @@ ATEerror_t at_Receive(const char *param)
   return AT_OK;
 }
 
-ATEerror_t at_SendV2(const char *param)
+ATEerror_t at_SendV2_main(const char *param)
 {
   LoRaMacStatus_t status;
-  at_ack_set("0");
 
   size_t length = 0;
 
-  if (tiny_sscanf(param, "%hu", &length) != 1
+  if (tiny_sscanf(param, "%u", &length) != 1
 		  || length > MAX_SEND_DATA)
   {
     return AT_PARAM_ERROR;
   }
-  uint8_t data[MAX_SEND_DATA];
   int i = 0;
   // grab other #len bytes from the serial buffer
   while (i<length) {
 	if (IsNewCharReceived() == SET) {
-		data[i] = GetNewChar();
+		SendData[i] = GetNewChar();
+	    if (SendData[i] == AT_ERROR_RX_CHAR)
+	    {
+	      return AT_RX_ERROR;
+	    }
 		i++;
     }
   }
 
-  status = lora_send(data, length, format_send_v2, 1);
+  status = lora_send(SendData, length, format_send_v2, 1);
   CHECK_STATUS(status);
 
   return AT_OK;
 }
 
-ATEerror_t at_SendV2Confirmation(const char *param)
+ATEerror_t at_SendV2(const char *param)
 {
-  LoRaMacStatus_t status;
-  at_ack_set("1");
-
-  size_t length = 0;
+  at_ack_set("0");
 
-  if (tiny_sscanf(param, "%hu", &length) != 1
-		  || length > MAX_SEND_DATA)
-  {
-	return AT_PARAM_ERROR;
-  }
-  uint8_t data[MAX_SEND_DATA];
-  int i = 0;
-  // grab other #len bytes from the serial buffer
-  while (i<length) {
-	if (IsNewCharReceived() == SET) {
-		data[i] = GetNewChar();
-		i++;
-    }
-  }
+  return at_SendV2_main(param);
+}
 
-  status = lora_send(data, length, format_send_v2, 1);
-  CHECK_STATUS(status);
+ATEerror_t at_SendV2Confirmation(const char *param)
+{
+  at_ack_set("1");
 
-  return AT_OK;
+  return at_SendV2_main(param);
 }
 
 ATEerror_t at_Port_get(const char *param)

From 8a23f4e0411a064bce4494bbf22b5876d41c7ac2 Mon Sep 17 00:00:00 2001
From: Florian Hofer <info@florianhofer.it>
Date: Sun, 5 Dec 2021 11:27:47 +0100
Subject: [PATCH 24/27] Update README.md

---
 README.md | 27 +++++++++++++++++++++++++--
 1 file changed, 25 insertions(+), 2 deletions(-)

diff --git a/README.md b/README.md
index a2d1549a..3ea6a951 100644
--- a/README.md
+++ b/README.md
@@ -4,12 +4,35 @@ This package contains the firmware for Murata CMWX1ZZABZ-078 module.
 
 It is derived from [I-CUBE-LRWAN](http://www.st.com/en/embedded-software/i-cube-lrwan.html), with some new APIs (like the ability to switch band at runtime, not only at compile time).
 
-The project is provided a [System Workbench for STM32](http://www.openstm32.org/System%2BWorkbench%2Bfor%2BSTM32) project, but can also be compiled in Eclipse after following [this](http://www.openstm32.org/Installing%2BSystem%2BWorkbench%2Bfor%2BSTM32%2Bfrom%2BEclipse#Important_note_about_your_MAC_OSX_host_version) guide
-
 [Releases](https://github.com/bcmi-labs/mkrwan1300-fw/releases) contains the precompiled firmware that can be uploaded either using FWUpdaterBridge or MKRWANFWUpdate_standalone examples from in https://github.com/arduino-libraries/MKRWAN
 
 All the code maintains its original license.
 
+## Compiling the code 
+The project is provided a [System Workbench for STM32](http://www.openstm32.org/System%2BWorkbench%2Bfor%2BSTM32) project, but can also be compiled in Eclipse after following [this](http://www.openstm32.org/Installing%2BSystem%2BWorkbench%2Bfor%2BSTM32%2Bfrom%2BEclipse#Important_note_about_your_MAC_OSX_host_version) guide. A third alternative is using Docker containers. Enter the following in a file called `Dockerfile`
+
+```
+FROM stronglytyped/arm-none-eabi-gcc:latest
+
+#Buildkit for hex file
+RUN apt-get update && \
+	apt install -y xxd \
+	&& rm -rf /var/lib/apt/lists/*
+
+WORKDIR /home
+CMD ["make", "-B"]
+```
+Then you create the new container image by running the build in the directory with `Dockerfile`. Let's name the image `arm-eabi-mkr`.
+```
+docker build . -t arm-eabi-mkr
+```
+Once you built the Docker image you can use the _Docker tooling_ add-on in Eclipse to build the firmware. Open the source code as CDT project and set the build container to `arm-eabi-mkr` in _Properties>C/C++ Build>Settings_.
+Alternatively, enter the source directory and run a container mapping the source directory to home as follows:
+```
+docker run -rm -v "$PWD":/home arm-eabi-mkr 
+```
+The `-rm` option removes the container after execution, while `-v` sets the directory mapping from `$PWD`, i.e., local directory, to `/home` inside the container.
+
 ## AT Command List
 
 | Command      | Description

From 6e67bfca1ce34875721794bdb8ff9ca10a6d2012 Mon Sep 17 00:00:00 2001
From: Florian Hofer <info@florianhofer.it>
Date: Sun, 5 Dec 2021 11:38:59 +0100
Subject: [PATCH 25/27] Update README.md

note about flashing. Backward compatibility
---
 README.md | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/README.md b/README.md
index 3ea6a951..ce8bdc3d 100644
--- a/README.md
+++ b/README.md
@@ -33,6 +33,12 @@ docker run -rm -v "$PWD":/home arm-eabi-mkr
 ```
 The `-rm` option removes the container after execution, while `-v` sets the directory mapping from `$PWD`, i.e., local directory, to `/home` inside the container.
 
+The file `fw.h` contains now the new firmware to be flashed, e.g., with the standalone sketch in the MKRWAN library. Just replace the included file and run the sketch on your device.
+
+## Backwards compatibility
+
+Starting from FW 1.2.4, the modem responds to value requests with the command followed by the value, e.g., `+FCU=3` instead of `+OK=3`.  Thus, to use newer firmware, you need to use a compatible, recent library. 
+
 ## AT Command List
 
 | Command      | Description

From f0cb13e97423b68bba1e99306cb3544f620d0270 Mon Sep 17 00:00:00 2001
From: Florian Hofer <info@florianhofer.it>
Date: Sun, 5 Dec 2021 12:26:07 +0100
Subject: [PATCH 26/27] ATSlave: add carriage return `\r` after reboot with
 `+EVENT=0,0`

---
 Projects/Multi/Applications/LoRa/AT_Slave/src/main.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Projects/Multi/Applications/LoRa/AT_Slave/src/main.c b/Projects/Multi/Applications/LoRa/AT_Slave/src/main.c
index 84c8a4b5..1d811493 100644
--- a/Projects/Multi/Applications/LoRa/AT_Slave/src/main.c
+++ b/Projects/Multi/Applications/LoRa/AT_Slave/src/main.c
@@ -297,7 +297,7 @@ int main(void)
 
   /* USER CODE BEGIN 1 */
   CMD_Init();
-  PRINTF(AT_EVENT AT_EQ "0,0");
+  PRINTF(AT_EVENT AT_EQ "0,0\r");
   /* USER CODE END 1 */
 
   /* Configure the Lora Stack*/

From 8a3d9231d48c9de8bcd5bb9b5d24131443b1d84e Mon Sep 17 00:00:00 2001
From: Florian Hofer <info@florianhofer.it>
Date: Mon, 7 Mar 2022 13:46:54 +0100
Subject: [PATCH 27/27] Update README.md

Co-authored-by: mactkg <mactkg@gmail.com>
---
 README.md | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/README.md b/README.md
index ce8bdc3d..da5b084b 100644
--- a/README.md
+++ b/README.md
@@ -29,7 +29,7 @@ docker build . -t arm-eabi-mkr
 Once you built the Docker image you can use the _Docker tooling_ add-on in Eclipse to build the firmware. Open the source code as CDT project and set the build container to `arm-eabi-mkr` in _Properties>C/C++ Build>Settings_.
 Alternatively, enter the source directory and run a container mapping the source directory to home as follows:
 ```
-docker run -rm -v "$PWD":/home arm-eabi-mkr 
+docker run --rm -v "$PWD":/home arm-eabi-mkr 
 ```
 The `-rm` option removes the container after execution, while `-v` sets the directory mapping from `$PWD`, i.e., local directory, to `/home` inside the container.