Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Kustomize patches #356

Open
dorsegal opened this issue Nov 29, 2023 · 2 comments · May be fixed by #360
Open

Support Kustomize patches #356

dorsegal opened this issue Nov 29, 2023 · 2 comments · May be fixed by #360
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Community help wanted!

Comments

@dorsegal
Copy link

Argocd allow to define patches in application CRD
https://argo-cd.readthedocs.io/en/stable/user-guide/kustomize/#patches

According to latest version I don't see patches as one of the attributes
https://registry.terraform.io/providers/oboukili/argocd/latest/docs/resources/application#nestedblock--spec--source--kustomize

It will be much helpful to implement this.

@dorsegal dorsegal added the enhancement New feature or request label Nov 29, 2023
@onematchfox onematchfox added help wanted Community help wanted! good first issue Good for newcomers labels Nov 29, 2023
@chidambaram27
Copy link

planned to have the patches attribute like the mentioned example

kustomize {
  patches {
	  target {
		  kind = "Deployment"
		  name = "the-deployment"
	  }
	  patch = <<-EOT
	        - op: replace
		  path: /spec/template/spec/containers/0/name
		  value: the-container-1
	  EOT
       }
 }

This block can be repeated in case multiple patches needed

@agray-ctm
Copy link

I would also like this feature. Today found out the hard way that this is not supported.


│ Error: Unsupported argument

│ on .terraform/modules/kong-global/main.tf line 29, in resource "argocd_application" "kong-global":
│ 29: patches = [

│ An argument named "patches" is not expected here.

  kustomize {
    patches = [
      {
        target = {
          kind = "Deployment"
          name = "kong-mesh"
        }
        patch = <<-EOF ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Community help wanted!
Projects
None yet
4 participants