lint command should optionally validate existence of referenced resources

[crenshaw-dev]

Summary

Although Argo Rollouts' lint command will lint non-Rollouts resources if they are provided, it will not verify that all referenced resources are provided.

The lint command should accept a manifest YAML and, if you specify something like --require-references, it should verify that all referenced resources are actually present.

Use Cases

So, for example, if the provided Rollout itself is invalid or if the provided VirtualService is invalid, the lint command will throw an error. But if the Rollout references a VirtualService which is not provided, the linter will not throw an error.

How

The controller validation code has a pre-validation step to retrieve referenced resources. The k8s client calls should be wrapped in an interface that's also implemented by a staticResourceProvider which just pulls the resource from the provided manifest. The controller validation could use the k8s implementation, and the CLI could use the static implementation.

---

Message from the maintainers:

Impacted by this bug? Give it a 👍. We prioritize the issues with the most 👍.