fix: set argo-rollouts-notification-secret in metadata.name in the description of Store Oauth access token
#3943
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3943 +/- ##
==========================================
+ Coverage 82.66% 82.68% +0.01%
==========================================
Files 163 163
Lines 22895 22895
==========================================
+ Hits 18927 18931 +4
+ Misses 3092 3089 -3
+ Partials 876 875 -1 ☔ View full report in Codecov by Sentry. |
Published E2E Test Results 4 files 4 suites 3h 16m 26s ⏱️ For more details on these failures, see this check. Results for commit e3169ce. ♻️ This comment has been updated with latest results. |
Published Unit Test Results2 280 tests 2 280 ✅ 2m 59s ⏱️ Results for commit e3169ce. ♻️ This comment has been updated with latest results. |
Signed-off-by: chansuke <[email protected]>
Signed-off-by: chansuke <[email protected]>
chansuke
force-pushed
the
fix/secret-name
branch
from
4944cb7
to
e3169ce
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3942
Checklist:
"fix(controller): Updates such and such. Fixes #1234".