New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Version Check as String. #53

Open

sriram-fastly opened this issue Aug 10, 2022 · 0 comments

sriram-fastly commented Aug 10, 2022

Please refer to https://github.com/aristanetworks/goeapi/blob/master/module/users.go#L371

The condition to check if the version is < "4.23" is questionable.

For eg.,

4.10 < 4.23
4.20 < 4.23
4.3 > 4.23.
4.03 < 4.23

Please confirm if this check will hold with the versioning scheme used by Arista.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment