Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UMD distribution needed #5

Open
ajssd opened this issue Apr 27, 2023 · 3 comments
Open

UMD distribution needed #5

ajssd opened this issue Apr 27, 2023 · 3 comments

Comments

@ajssd
Copy link

ajssd commented Apr 27, 2023

The PhotoSwipe 5 distribution includes support for non-ESM (that is, UMD) uses here.

Is it possible for this add-on to also include a UMD build, for those of us that cannot (yet) move to ESM?

@arnowelzel
Copy link
Owner

Sorry, at the moment I just don't have the time to support an additional UMD version based on the ESM version.

Can you be a bit more specific about "cannot (yet) move to ESM"? ESM is more or less supported by all current browsers according to https://caniuse.com/?search=ESM. Only IE and Opera Mini don't support that. What is the usecase of the UMD version here?

@ajssd
Copy link
Author

ajssd commented Apr 27, 2023

Thanks for the quick reply. I know all browsers support ESM; the issue is that we have a very large product based on RequireJS and similar (older) technology, with complex build process, etc. We'll get there eventually. For now, I'll just write some custom code to support full-screen mode, using the hints I see here.

@arnowelzel
Copy link
Owner

arnowelzel commented Apr 27, 2023

Any assistance in creating a UMD version is welcome. I just can't do it for the time being due to the lack of time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants