Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: All MD5 checksum files are improperly formatted #1903

Open
abcdev opened this issue Feb 6, 2025 · 1 comment
Open

bug: All MD5 checksum files are improperly formatted #1903

abcdev opened this issue Feb 6, 2025 · 1 comment
Labels

Comments

@abcdev
Copy link

abcdev commented Feb 6, 2025

Describe the Bug

All MD5 checksum files are appear to be improperly formatted as the file name is missing after the actual checksum within the .md5 files.

Because of this this md5sum will output md5sum: WARNING: 1 line is improperly formatted every time one verifies the files.
In security conscious environments where md5sum --strict is required the md5 check will fail, resulting asdf being uninstallable.

Simple fix: Adhere to md5sum file format

Steps to Reproduce

  1. Download a binary release file archive and its corresponding .md5 file into a directory of your choice
  2. In that directory call md5sum -c $theChecksumFilename

Expected Behaviour

All binary release file archives should be verifiable with md5sum without a problem/warning/error

Actual Behaviour

Verifying a any asdf binary release file archive leads to the warning md5sum: WARNING: 1 line is improperly formatted

Environment

Irrelevant as this problem arises before the installation.

asdf plugins affected (if relevant)

No response

@abcdev abcdev added the bug label Feb 6, 2025
@AlfredoRamos
Copy link
Contributor

This should be reported on the wangyoucao577/go-release-action GitHub Action, since it intentionally removes everything after the hash 1.

Footnotes

  1. https://github.com/wangyoucao577/go-release-action/blob/8dbc9990292b456ae78e728c7cf7b857b821faac/release.sh#L195

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants