Skip to content

Commit a661a6a

Browse files
authored
Fix symbol uploads (#43)
* Fix parameter order * Do not preserve address offset * Do not pass explicit symbol ID
1 parent 3ed1266 commit a661a6a

1 file changed

Lines changed: 3 additions & 3 deletions

File tree

extension/extension.cpp

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -565,17 +565,17 @@ class UploadThread: public IThread
565565
};
566566

567567
std::ostringstream outputStream;
568-
google_breakpad::DumpOptions options(ALL_SYMBOL_DATA, true, true, true);
568+
google_breakpad::DumpOptions options(ALL_SYMBOL_DATA, true, true, false);
569569

570570
{
571571
StderrInhibitor stdrrInhibitor;
572572

573-
if (!WriteSymbolFile(debugFile, debugFile, debugFile, "Linux", debug_dirs, options, outputStream)) {
573+
if (!WriteSymbolFile(debugFile, debugFile, "Linux", "", debug_dirs, options, outputStream)) {
574574
outputStream.str("");
575575
outputStream.clear();
576576

577577
// Try again without debug dirs.
578-
if (!WriteSymbolFile(debugFile, debugFile, debugFile, "Linux", {}, options, outputStream)) {
578+
if (!WriteSymbolFile(debugFile, debugFile, "Linux", "", {}, options, outputStream)) {
579579
if (log) fprintf(log, "Failed to process symbol file\n");
580580
if (log) fflush(log);
581581
return false;

0 commit comments

Comments
 (0)