Added a rule to check if packages are built in release configuration

ajaybhargavb · ajaybhargavb · commit 2c830d81a35d · 2016-03-31T10:26:24.000-07:00
diff --git a/src/NuGetPackageVerifier/CompositeRules/AdxVerificationCompositeRule.cs b/src/NuGetPackageVerifier/CompositeRules/AdxVerificationCompositeRule.cs
@@ -15,6 +15,7 @@ public class AdxVerificationCompositeRule : IPackageVerifierRule
             new AssemblyHasCommitHashAttributeRule(),
             new AssemblyHasCompanyAttributeRule(),
             new AssemblyHasCopyrightAttributeRule(),
+            new AssemblyHasCorrectBuildConfigurationRule(),
             new AssemblyHasCorrectJsonNetVersionRule(),
             new AssemblyHasDocumentFileRule(),
             new AssemblyHasNeutralResourcesLanguageAttributeRule(),
diff --git a/src/NuGetPackageVerifier/CompositeRules/DefaultCompositeRule.cs b/src/NuGetPackageVerifier/CompositeRules/DefaultCompositeRule.cs
@@ -15,6 +15,7 @@ public class DefaultCompositeRule : IPackageVerifierRule
             new AssemblyHasCommitHashAttributeRule(),
             new AssemblyHasCompanyAttributeRule(),
             new AssemblyHasCopyrightAttributeRule(),
+            new AssemblyHasCorrectBuildConfigurationRule(),
             new AssemblyHasCorrectJsonNetVersionRule(),
             new AssemblyHasDocumentFileRule(),
             new AssemblyHasDescriptionAttributeRule(),
diff --git a/src/NuGetPackageVerifier/IssueReport.cs b/src/NuGetPackageVerifier/IssueReport.cs
@@ -10,7 +10,7 @@ public class IssueReport
         public IssueReport(PackageVerifierIssue packageIssue, bool ignore, string ignoreJustification)
         {
             PackageIssue = packageIssue;
-            IssueLevel = ignore ? LogLevel.Info : packageIssue.Level == MyPackageIssueLevel.Warning ? LogLevel.Warning : LogLevel.Error;
+            IssueLevel = ignore ? LogLevel.Info : packageIssue.Level == PackageIssueLevel.Warning ? LogLevel.Warning : LogLevel.Error;
             IgnoreJustification = ignoreJustification;
         }
 
diff --git a/src/NuGetPackageVerifier/PackageIssueFactory.cs b/src/NuGetPackageVerifier/PackageIssueFactory.cs
@@ -16,7 +16,7 @@ public static PackageVerifierIssue AssemblyMissingServicingAttribute(string asse
                 string.Format(
                     @"The managed assembly '{0}' in this package is missing the '[assembly: AssemblyMetadata(""Serviceable"", ""True"")]' attribute.",
                     assemblyPath),
-                MyPackageIssueLevel.Error);
+                PackageIssueLevel.Error);
         }
 
         public static PackageVerifierIssue AssemblyMissingHashAttribute(string assemblyPath)
@@ -27,7 +27,16 @@ public static PackageVerifierIssue AssemblyMissingHashAttribute(string assemblyP
                 string.Format(
                     @"The managed assembly '{0}' in this package is missing the '[assembly: AssemblyMetadata(""CommitHash"", ""<text>"")]' attribute.",
                     assemblyPath),
-                MyPackageIssueLevel.Error);
+                PackageIssueLevel.Error);
+        }
+
+        public static PackageVerifierIssue AssemblyHasIncorrectBuildConfiguration(string assemblyPath)
+        {
+            return new PackageVerifierIssue(
+                "WRONG_BUILD_CONFIGURATION",
+                assemblyPath,
+                string.Format("The assembly '{0}' was not built using 'Release' configuration.", assemblyPath),
+                PackageIssueLevel.Error);
         }
 
         public static PackageVerifierIssue AssemblyMissingNeutralResourcesLanguageAttribute(string assemblyPath)
@@ -38,7 +47,7 @@ public static PackageVerifierIssue AssemblyMissingNeutralResourcesLanguageAttrib
                 string.Format(
                     @"The managed assembly '{0}' in this package is missing the '[assembly: NeutralResourcesLanguage(""en-us"")]' attribute.",
                     assemblyPath),
-                MyPackageIssueLevel.Error);
+                PackageIssueLevel.Error);
         }
 
         public static PackageVerifierIssue AssemblyMissingCopyrightAttribute(string assemblyPath)
@@ -49,7 +58,7 @@ public static PackageVerifierIssue AssemblyMissingCopyrightAttribute(string asse
                 string.Format(
                     @"The managed assembly '{0}' in this package is missing the 'AssemblyCopyright' attribute.",
                     assemblyPath),
-                MyPackageIssueLevel.Error);
+                PackageIssueLevel.Error);
         }
 
         public static PackageVerifierIssue AssemblyMissingCompanyAttribute(string assemblyPath)
@@ -60,7 +69,7 @@ public static PackageVerifierIssue AssemblyMissingCompanyAttribute(string assemb
                 string.Format(
                     @"The managed assembly '{0}' in this package is missing the 'AssemblyCompany' attribute.",
                     assemblyPath),
-                MyPackageIssueLevel.Error);
+                PackageIssueLevel.Error);
         }
 
         public static PackageVerifierIssue AssemblyMissingProductAttribute(string assemblyPath)
@@ -71,7 +80,7 @@ public static PackageVerifierIssue AssemblyMissingProductAttribute(string assemb
                 string.Format(
                     @"The managed assembly '{0}' in this package is missing the 'AssemblyProduct' attribute.",
                     assemblyPath),
-                MyPackageIssueLevel.Error);
+                PackageIssueLevel.Error);
         }
 
         public static PackageVerifierIssue AssemblyMissingDescriptionAttribute(string assemblyPath)
@@ -82,7 +91,7 @@ public static PackageVerifierIssue AssemblyMissingDescriptionAttribute(string as
                 string.Format(
                     @"The managed assembly '{0}' in this package is missing the 'AssemblyDescription' attribute.",
                     assemblyPath),
-                MyPackageIssueLevel.Error);
+                PackageIssueLevel.Error);
         }
 
         public static PackageVerifierIssue AssemblyMissingFileVersionAttribute(string assemblyPath)
@@ -97,99 +106,99 @@ public static PackageVerifierIssue AssemblyMissingInformationalVersionAttribute(
 
         private static PackageVerifierIssue AssemblyMissingVersionAttributeCore(string issueId, string assemblyPath, string attributeName)
         {
-            return new PackageVerifierIssue(issueId, assemblyPath, string.Format("The managed assembly '{0}' in this package is missing the '{1}' attribute.", assemblyPath, attributeName), MyPackageIssueLevel.Error);
+            return new PackageVerifierIssue(issueId, assemblyPath, string.Format("The managed assembly '{0}' in this package is missing the '{1}' attribute.", assemblyPath, attributeName), PackageIssueLevel.Error);
         }
 
         public static PackageVerifierIssue AssemblyNotStrongNameSigned(string assemblyPath, int hResult)
         {
             // TODO: Translate common HRESULTS http://blogs.msdn.com/b/yizhang/
-            return new PackageVerifierIssue("SIGN_STRONGNAME", assemblyPath, string.Format("The managed assembly '{0}' in this package is either not signed or is delay signed. HRESULT=0x{1:X}", assemblyPath, hResult), MyPackageIssueLevel.Error);
+            return new PackageVerifierIssue("SIGN_STRONGNAME", assemblyPath, string.Format("The managed assembly '{0}' in this package is either not signed or is delay signed. HRESULT=0x{1:X}", assemblyPath, hResult), PackageIssueLevel.Error);
         }
 
         public static PackageVerifierIssue AssemblyHasWrongPublicKeyToken(string assemblyPath, string expectedToken)
         {
-            return new PackageVerifierIssue("WRONG_PUBLICKEYTOKEN", assemblyPath, string.Format("The managed assembly '{0}' in this package does not have the expected public key token ({1}).", assemblyPath, expectedToken), MyPackageIssueLevel.Error);
+            return new PackageVerifierIssue("WRONG_PUBLICKEYTOKEN", assemblyPath, string.Format("The managed assembly '{0}' in this package does not have the expected public key token ({1}).", assemblyPath, expectedToken), PackageIssueLevel.Error);
         }
 
         public static PackageVerifierIssue NotSemanticVersion(SemanticVersion version)
         {
             return new PackageVerifierIssue("VERSION_NOTSEMANTIC",
-                    string.Format("Version '{0}' does not follow semantic versioning guidelines.", version), MyPackageIssueLevel.Error);
+                    string.Format("Version '{0}' does not follow semantic versioning guidelines.", version), PackageIssueLevel.Error);
         }
 
         public static PackageVerifierIssue Satellite_PackageSummaryNotLocalized()
         {
-            return new PackageVerifierIssue("LOC_SUMMARY", "Package summary is not localized correctly", MyPackageIssueLevel.Error);
+            return new PackageVerifierIssue("LOC_SUMMARY", "Package summary is not localized correctly", PackageIssueLevel.Error);
         }
 
         public static PackageVerifierIssue Satellite_PackageTitleNotLocalized()
         {
-            return new PackageVerifierIssue("LOC_TITLE", "Package title is not localized correctly", MyPackageIssueLevel.Error);
+            return new PackageVerifierIssue("LOC_TITLE", "Package title is not localized correctly", PackageIssueLevel.Error);
         }
 
         public static PackageVerifierIssue Satellite_PackageDescriptionNotLocalized()
         {
-            return new PackageVerifierIssue("LOC_DESC", "Package description is not localized correctly", MyPackageIssueLevel.Error);
+            return new PackageVerifierIssue("LOC_DESC", "Package description is not localized correctly", PackageIssueLevel.Error);
         }
 
         public static PackageVerifierIssue RequiredCopyright()
         {
-            return RequiredCore("NUSPEC_COPYRIGHT", "Copyright", MyPackageIssueLevel.Error);
+            return RequiredCore("NUSPEC_COPYRIGHT", "Copyright", PackageIssueLevel.Error);
         }
 
         public static PackageVerifierIssue RequiredLicenseUrl()
         {
-            return RequiredCore("NUSPEC_LICENSEURL", "License Url", MyPackageIssueLevel.Error);
+            return RequiredCore("NUSPEC_LICENSEURL", "License Url", PackageIssueLevel.Error);
         }
 
         public static PackageVerifierIssue RequiredIconUrl()
         {
-            return RequiredCore("NUSPEC_ICONURL", "Icon Url", MyPackageIssueLevel.Warning);
+            return RequiredCore("NUSPEC_ICONURL", "Icon Url", PackageIssueLevel.Warning);
         }
 
         public static PackageVerifierIssue RequiredTags()
         {
-            return RequiredCore("NUSPEC_TAGS", "Tags", MyPackageIssueLevel.Warning);
+            return RequiredCore("NUSPEC_TAGS", "Tags", PackageIssueLevel.Warning);
         }
 
         public static PackageVerifierIssue RequiredTitle()
         {
-            return RequiredCore("NUSPEC_TITLE", "Title", MyPackageIssueLevel.Error);
+            return RequiredCore("NUSPEC_TITLE", "Title", PackageIssueLevel.Error);
         }
 
         public static PackageVerifierIssue RequiredSummary()
         {
-            return RequiredCore("NUSPEC_SUMMARY", "Summary", MyPackageIssueLevel.Warning);
+            return RequiredCore("NUSPEC_SUMMARY", "Summary", PackageIssueLevel.Warning);
         }
 
         public static PackageVerifierIssue RequiredProjectUrl()
         {
-            return RequiredCore("NUSPEC_PROJECTURL", "Project Url", MyPackageIssueLevel.Warning);
+            return RequiredCore("NUSPEC_PROJECTURL", "Project Url", PackageIssueLevel.Warning);
         }
 
         public static PackageVerifierIssue RequiredRequireLicenseAcceptanceTrue()
         {
-            return new PackageVerifierIssue("NUSPEC_ACCEPTLICENSE", string.Format("NuSpec Require License Acceptance is not set to true"), MyPackageIssueLevel.Error);
+            return new PackageVerifierIssue("NUSPEC_ACCEPTLICENSE", string.Format("NuSpec Require License Acceptance is not set to true"), PackageIssueLevel.Error);
         }
 
-        private static PackageVerifierIssue RequiredCore(string issueId, string attributeName, MyPackageIssueLevel issueLevel)
+        private static PackageVerifierIssue RequiredCore(string issueId, string attributeName, PackageIssueLevel issueLevel)
         {
             return new PackageVerifierIssue(issueId, string.Format("NuSpec {0} attribute is missing", attributeName), issueLevel);
         }
 
         public static PackageVerifierIssue PowerShellScriptNotSigned(string scriptPath)
         {
-            return new PackageVerifierIssue("SIGN_POWERSHELL", scriptPath, string.Format("The PowerShell script '{0}' is not signed.", scriptPath), MyPackageIssueLevel.Error);
+            return new PackageVerifierIssue("SIGN_POWERSHELL", scriptPath, string.Format("The PowerShell script '{0}' is not signed.", scriptPath), PackageIssueLevel.Error);
         }
 
         public static PackageVerifierIssue PEFileNotAuthenticodeSigned(string assemblyPath)
         {
-            return new PackageVerifierIssue("SIGN_AUTHENTICODE", assemblyPath, string.Format("The PE file '{0}' in this package is not authenticode signed.", assemblyPath), MyPackageIssueLevel.Error);
+            return new PackageVerifierIssue("SIGN_AUTHENTICODE", assemblyPath, string.Format("The PE file '{0}' in this package is not authenticode signed.", assemblyPath), PackageIssueLevel.Error);
         }
 
         public static PackageVerifierIssue AssemblyHasNoDocFile(string assemblyPath)
         {
-            return new PackageVerifierIssue("DOC_MISSING", assemblyPath, string.Format("The assembly '{0}' doesn't have a corresponding XML document file.", assemblyPath), MyPackageIssueLevel.Warning);
+            return new PackageVerifierIssue("DOC_MISSING", assemblyPath, string.Format("The assembly '{0}' doesn't have a corresponding XML document file.", assemblyPath), PackageIssueLevel.Warning);
         }
 
         public static PackageVerifierIssue AssemblyHasWrongJsonNetVersion(string assemblyPath, string targetFramework, string currentVersion)
@@ -198,7 +207,7 @@ public static PackageVerifierIssue AssemblyHasWrongJsonNetVersion(string assembl
                 "WRONG_JSONNET_VERSION",
                 string.Format("{0}; {1}", assemblyPath, targetFramework),
                 string.Format("The assembly '{0}' references the wrong Json.NET version. Current version '{1}'; Expected version '8.0.2'.", assemblyPath, currentVersion),
-                MyPackageIssueLevel.Error);
+                PackageIssueLevel.Error);
         }
     }
 }
diff --git a/src/NuGetPackageVerifier/PackageIssueLevel.cs b/src/NuGetPackageVerifier/PackageIssueLevel.cs
@@ -3,7 +3,7 @@
 
 namespace NuGetPackageVerifier
 {
-    public enum MyPackageIssueLevel
+    public enum PackageIssueLevel
     {
         Warning,
         Error
diff --git a/src/NuGetPackageVerifier/PackageVerifierIssue.cs b/src/NuGetPackageVerifier/PackageVerifierIssue.cs
@@ -5,20 +5,20 @@ namespace NuGetPackageVerifier
 {
     public class PackageVerifierIssue
     {
-        public PackageVerifierIssue(string issueId, string issue, MyPackageIssueLevel level)
+        public PackageVerifierIssue(string issueId, string issue, PackageIssueLevel level)
             : this(issueId, instance: null, issue: issue, level: level)
         {
         }
 
-        public PackageVerifierIssue(string issueId, string instance, string issue, MyPackageIssueLevel level)
+        public PackageVerifierIssue(string issueId, string instance, string issue, PackageIssueLevel level)
         {
             Instance = instance;
             IssueId = issueId;
             Issue = issue;
             Level = level;
         }
 
-        public MyPackageIssueLevel Level
+        public PackageIssueLevel Level
         {
             get;
             private set;
diff --git a/src/NuGetPackageVerifier/Rules/AssemblyHasCorrectBuildConfigurationRule.cs b/src/NuGetPackageVerifier/Rules/AssemblyHasCorrectBuildConfigurationRule.cs
@@ -0,0 +1,41 @@
+﻿// Copyright (c) .NET Foundation. All rights reserved.
+// Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information.
+
+using System.Collections.Generic;
+using System.Diagnostics;
+using System.Linq;
+using Mono.Cecil;
+using Mono.Collections.Generic;
+
+namespace NuGetPackageVerifier.Rules
+{
+    public class AssemblyHasCorrectBuildConfigurationRule : AssemblyHasAttributeRuleBase
+    {
+        public override IEnumerable<PackageVerifierIssue> ValidateAttribute(string currentFilePath, Collection<CustomAttribute> assemblyAttributes)
+        {
+            if (!HasReleaseConfiguration(assemblyAttributes))
+            {
+                yield return PackageIssueFactory.AssemblyHasIncorrectBuildConfiguration(currentFilePath);
+            }
+        }
+
+        private static bool HasReleaseConfiguration(Collection<CustomAttribute> assemblyAttributes)
+        {
+            var foundAttr = assemblyAttributes.SingleOrDefault(attr => attr.AttributeType.FullName == typeof(DebuggableAttribute).FullName);
+            if (foundAttr == null)
+            {
+                return false;
+            }
+
+            var foundAttrArg = foundAttr.ConstructorArguments.SingleOrDefault();
+            var attrValue = (DebuggableAttribute.DebuggingModes)foundAttrArg.Value;
+            if (attrValue.HasFlag(DebuggableAttribute.DebuggingModes.Default) ||
+                attrValue.HasFlag(DebuggableAttribute.DebuggingModes.DisableOptimizations))
+            {
+                return false;
+            }
+
+            return true;
+        }
+    }
+}

Original file line number	Diff line number	Diff line change
`@@ -10,7 +10,7 @@ public class IssueReport`
`10`	`10`	`public IssueReport(PackageVerifierIssue packageIssue, bool ignore, string ignoreJustification)`
`11`	`11`	`{`
`12`	`12`	`PackageIssue = packageIssue;`
`13`		`- IssueLevel = ignore ? LogLevel.Info : packageIssue.Level == MyPackageIssueLevel.Warning ? LogLevel.Warning : LogLevel.Error;`
	`13`	`+ IssueLevel = ignore ? LogLevel.Info : packageIssue.Level == PackageIssueLevel.Warning ? LogLevel.Warning : LogLevel.Error;`
`14`	`14`	`IgnoreJustification = ignoreJustification;`
`15`	`15`	`}`
`16`	`16`
Original file line number	Diff line number	Diff line change
`@@ -16,7 +16,7 @@ public static PackageVerifierIssue AssemblyMissingServicingAttribute(string asse`
`16`	`16`	`string.Format(`
`17`	`17`	`@"The managed assembly '{0}' in this package is missing the '[assembly: AssemblyMetadata(""Serviceable"", ""True"")]' attribute.",`
`18`	`18`	`assemblyPath),`
`19`		`- MyPackageIssueLevel.Error);`
	`19`	`+ PackageIssueLevel.Error);`
`20`	`20`	`}`
`21`	`21`
`22`	`22`	`public static PackageVerifierIssue AssemblyMissingHashAttribute(string assemblyPath)`
`@@ -27,7 +27,16 @@ public static PackageVerifierIssue AssemblyMissingHashAttribute(string assemblyP`
`27`	`27`	`string.Format(`
`28`	`28`	`@"The managed assembly '{0}' in this package is missing the '[assembly: AssemblyMetadata(""CommitHash"", ""<text>"")]' attribute.",`
`29`	`29`	`assemblyPath),`
`30`		`- MyPackageIssueLevel.Error);`
	`30`	`+ PackageIssueLevel.Error);`
	`31`	`+ }`
	`32`	`+`
	`33`	`+ public static PackageVerifierIssue AssemblyHasIncorrectBuildConfiguration(string assemblyPath)`
	`34`	`+ {`
	`35`	`+ return new PackageVerifierIssue(`
	`36`	`+ "WRONG_BUILD_CONFIGURATION",`
	`37`	`+ assemblyPath,`
	`38`	`+ string.Format("The assembly '{0}' was not built using 'Release' configuration.", assemblyPath),`
	`39`	`+ PackageIssueLevel.Error);`
`31`	`40`	`}`
`32`	`41`
`33`	`42`	`public static PackageVerifierIssue AssemblyMissingNeutralResourcesLanguageAttribute(string assemblyPath)`
`@@ -38,7 +47,7 @@ public static PackageVerifierIssue AssemblyMissingNeutralResourcesLanguageAttrib`
`38`	`47`	`string.Format(`
`39`	`48`	`@"The managed assembly '{0}' in this package is missing the '[assembly: NeutralResourcesLanguage(""en-us"")]' attribute.",`
`40`	`49`	`assemblyPath),`
`41`		`- MyPackageIssueLevel.Error);`
	`50`	`+ PackageIssueLevel.Error);`
`42`	`51`	`}`
`43`	`52`
`44`	`53`	`public static PackageVerifierIssue AssemblyMissingCopyrightAttribute(string assemblyPath)`
`@@ -49,7 +58,7 @@ public static PackageVerifierIssue AssemblyMissingCopyrightAttribute(string asse`
`49`	`58`	`string.Format(`
`50`	`59`	`@"The managed assembly '{0}' in this package is missing the 'AssemblyCopyright' attribute.",`
`51`	`60`	`assemblyPath),`
`52`		`- MyPackageIssueLevel.Error);`
	`61`	`+ PackageIssueLevel.Error);`
`53`	`62`	`}`
`54`	`63`
`55`	`64`	`public static PackageVerifierIssue AssemblyMissingCompanyAttribute(string assemblyPath)`
`@@ -60,7 +69,7 @@ public static PackageVerifierIssue AssemblyMissingCompanyAttribute(string assemb`
`60`	`69`	`string.Format(`
`61`	`70`	`@"The managed assembly '{0}' in this package is missing the 'AssemblyCompany' attribute.",`
`62`	`71`	`assemblyPath),`
`63`		`- MyPackageIssueLevel.Error);`
	`72`	`+ PackageIssueLevel.Error);`
`64`	`73`	`}`
`65`	`74`
`66`	`75`	`public static PackageVerifierIssue AssemblyMissingProductAttribute(string assemblyPath)`
`@@ -71,7 +80,7 @@ public static PackageVerifierIssue AssemblyMissingProductAttribute(string assemb`
`71`	`80`	`string.Format(`
`72`	`81`	`@"The managed assembly '{0}' in this package is missing the 'AssemblyProduct' attribute.",`
`73`	`82`	`assemblyPath),`
`74`		`- MyPackageIssueLevel.Error);`
	`83`	`+ PackageIssueLevel.Error);`
`75`	`84`	`}`
`76`	`85`
`77`	`86`	`public static PackageVerifierIssue AssemblyMissingDescriptionAttribute(string assemblyPath)`
`@@ -82,7 +91,7 @@ public static PackageVerifierIssue AssemblyMissingDescriptionAttribute(string as`
`82`	`91`	`string.Format(`
`83`	`92`	`@"The managed assembly '{0}' in this package is missing the 'AssemblyDescription' attribute.",`
`84`	`93`	`assemblyPath),`
`85`		`- MyPackageIssueLevel.Error);`
	`94`	`+ PackageIssueLevel.Error);`
`86`	`95`	`}`
`87`	`96`
`88`	`97`	`public static PackageVerifierIssue AssemblyMissingFileVersionAttribute(string assemblyPath)`
`@@ -97,99 +106,99 @@ public static PackageVerifierIssue AssemblyMissingInformationalVersionAttribute(`
`97`	`106`
`98`	`107`	`private static PackageVerifierIssue AssemblyMissingVersionAttributeCore(string issueId, string assemblyPath, string attributeName)`
`99`	`108`	`{`
`100`		`- return new PackageVerifierIssue(issueId, assemblyPath, string.Format("The managed assembly '{0}' in this package is missing the '{1}' attribute.", assemblyPath, attributeName), MyPackageIssueLevel.Error);`
	`109`	`+ return new PackageVerifierIssue(issueId, assemblyPath, string.Format("The managed assembly '{0}' in this package is missing the '{1}' attribute.", assemblyPath, attributeName), PackageIssueLevel.Error);`
`101`	`110`	`}`
`102`	`111`
`103`	`112`	`public static PackageVerifierIssue AssemblyNotStrongNameSigned(string assemblyPath, int hResult)`
`104`	`113`	`{`
`105`	`114`	`// TODO: Translate common HRESULTS http://blogs.msdn.com/b/yizhang/`
`106`		`- return new PackageVerifierIssue("SIGN_STRONGNAME", assemblyPath, string.Format("The managed assembly '{0}' in this package is either not signed or is delay signed. HRESULT=0x{1:X}", assemblyPath, hResult), MyPackageIssueLevel.Error);`
	`115`	`+ return new PackageVerifierIssue("SIGN_STRONGNAME", assemblyPath, string.Format("The managed assembly '{0}' in this package is either not signed or is delay signed. HRESULT=0x{1:X}", assemblyPath, hResult), PackageIssueLevel.Error);`
`107`	`116`	`}`
`108`	`117`
`109`	`118`	`public static PackageVerifierIssue AssemblyHasWrongPublicKeyToken(string assemblyPath, string expectedToken)`
`110`	`119`	`{`
`111`		`- return new PackageVerifierIssue("WRONG_PUBLICKEYTOKEN", assemblyPath, string.Format("The managed assembly '{0}' in this package does not have the expected public key token ({1}).", assemblyPath, expectedToken), MyPackageIssueLevel.Error);`
	`120`	`+ return new PackageVerifierIssue("WRONG_PUBLICKEYTOKEN", assemblyPath, string.Format("The managed assembly '{0}' in this package does not have the expected public key token ({1}).", assemblyPath, expectedToken), PackageIssueLevel.Error);`
`112`	`121`	`}`
`113`	`122`
`114`	`123`	`public static PackageVerifierIssue NotSemanticVersion(SemanticVersion version)`
`115`	`124`	`{`
`116`	`125`	`return new PackageVerifierIssue("VERSION_NOTSEMANTIC",`
`117`		`- string.Format("Version '{0}' does not follow semantic versioning guidelines.", version), MyPackageIssueLevel.Error);`
	`126`	`+ string.Format("Version '{0}' does not follow semantic versioning guidelines.", version), PackageIssueLevel.Error);`
`118`	`127`	`}`
`119`	`128`
`120`	`129`	`public static PackageVerifierIssue Satellite_PackageSummaryNotLocalized()`
`121`	`130`	`{`
`122`		`- return new PackageVerifierIssue("LOC_SUMMARY", "Package summary is not localized correctly", MyPackageIssueLevel.Error);`
	`131`	`+ return new PackageVerifierIssue("LOC_SUMMARY", "Package summary is not localized correctly", PackageIssueLevel.Error);`
`123`	`132`	`}`
`124`	`133`
`125`	`134`	`public static PackageVerifierIssue Satellite_PackageTitleNotLocalized()`
`126`	`135`	`{`
`127`		`- return new PackageVerifierIssue("LOC_TITLE", "Package title is not localized correctly", MyPackageIssueLevel.Error);`
	`136`	`+ return new PackageVerifierIssue("LOC_TITLE", "Package title is not localized correctly", PackageIssueLevel.Error);`
`128`	`137`	`}`
`129`	`138`
`130`	`139`	`public static PackageVerifierIssue Satellite_PackageDescriptionNotLocalized()`
`131`	`140`	`{`
`132`		`- return new PackageVerifierIssue("LOC_DESC", "Package description is not localized correctly", MyPackageIssueLevel.Error);`
	`141`	`+ return new PackageVerifierIssue("LOC_DESC", "Package description is not localized correctly", PackageIssueLevel.Error);`
`133`	`142`	`}`
`134`	`143`
`135`	`144`	`public static PackageVerifierIssue RequiredCopyright()`
`136`	`145`	`{`
`137`		`- return RequiredCore("NUSPEC_COPYRIGHT", "Copyright", MyPackageIssueLevel.Error);`
	`146`	`+ return RequiredCore("NUSPEC_COPYRIGHT", "Copyright", PackageIssueLevel.Error);`
`138`	`147`	`}`
`139`	`148`
`140`	`149`	`public static PackageVerifierIssue RequiredLicenseUrl()`
`141`	`150`	`{`
`142`		`- return RequiredCore("NUSPEC_LICENSEURL", "License Url", MyPackageIssueLevel.Error);`
	`151`	`+ return RequiredCore("NUSPEC_LICENSEURL", "License Url", PackageIssueLevel.Error);`
`143`	`152`	`}`
`144`	`153`
`145`	`154`	`public static PackageVerifierIssue RequiredIconUrl()`
`146`	`155`	`{`
`147`		`- return RequiredCore("NUSPEC_ICONURL", "Icon Url", MyPackageIssueLevel.Warning);`
	`156`	`+ return RequiredCore("NUSPEC_ICONURL", "Icon Url", PackageIssueLevel.Warning);`
`148`	`157`	`}`
`149`	`158`
`150`	`159`	`public static PackageVerifierIssue RequiredTags()`
`151`	`160`	`{`
`152`		`- return RequiredCore("NUSPEC_TAGS", "Tags", MyPackageIssueLevel.Warning);`
	`161`	`+ return RequiredCore("NUSPEC_TAGS", "Tags", PackageIssueLevel.Warning);`
`153`	`162`	`}`
`154`	`163`
`155`	`164`	`public static PackageVerifierIssue RequiredTitle()`
`156`	`165`	`{`
`157`		`- return RequiredCore("NUSPEC_TITLE", "Title", MyPackageIssueLevel.Error);`
	`166`	`+ return RequiredCore("NUSPEC_TITLE", "Title", PackageIssueLevel.Error);`
`158`	`167`	`}`
`159`	`168`
`160`	`169`	`public static PackageVerifierIssue RequiredSummary()`
`161`	`170`	`{`
`162`		`- return RequiredCore("NUSPEC_SUMMARY", "Summary", MyPackageIssueLevel.Warning);`
	`171`	`+ return RequiredCore("NUSPEC_SUMMARY", "Summary", PackageIssueLevel.Warning);`
`163`	`172`	`}`
`164`	`173`
`165`	`174`	`public static PackageVerifierIssue RequiredProjectUrl()`
`166`	`175`	`{`
`167`		`- return RequiredCore("NUSPEC_PROJECTURL", "Project Url", MyPackageIssueLevel.Warning);`
	`176`	`+ return RequiredCore("NUSPEC_PROJECTURL", "Project Url", PackageIssueLevel.Warning);`
`168`	`177`	`}`
`169`	`178`
`170`	`179`	`public static PackageVerifierIssue RequiredRequireLicenseAcceptanceTrue()`
`171`	`180`	`{`
`172`		`- return new PackageVerifierIssue("NUSPEC_ACCEPTLICENSE", string.Format("NuSpec Require License Acceptance is not set to true"), MyPackageIssueLevel.Error);`
	`181`	`+ return new PackageVerifierIssue("NUSPEC_ACCEPTLICENSE", string.Format("NuSpec Require License Acceptance is not set to true"), PackageIssueLevel.Error);`
`173`	`182`	`}`
`174`	`183`
`175`		`- private static PackageVerifierIssue RequiredCore(string issueId, string attributeName, MyPackageIssueLevel issueLevel)`
	`184`	`+ private static PackageVerifierIssue RequiredCore(string issueId, string attributeName, PackageIssueLevel issueLevel)`
`176`	`185`	`{`
`177`	`186`	`return new PackageVerifierIssue(issueId, string.Format("NuSpec {0} attribute is missing", attributeName), issueLevel);`
`178`	`187`	`}`
`179`	`188`
`180`	`189`	`public static PackageVerifierIssue PowerShellScriptNotSigned(string scriptPath)`
`181`	`190`	`{`
`182`		`- return new PackageVerifierIssue("SIGN_POWERSHELL", scriptPath, string.Format("The PowerShell script '{0}' is not signed.", scriptPath), MyPackageIssueLevel.Error);`
	`191`	`+ return new PackageVerifierIssue("SIGN_POWERSHELL", scriptPath, string.Format("The PowerShell script '{0}' is not signed.", scriptPath), PackageIssueLevel.Error);`
`183`	`192`	`}`
`184`	`193`
`185`	`194`	`public static PackageVerifierIssue PEFileNotAuthenticodeSigned(string assemblyPath)`
`186`	`195`	`{`
`187`		`- return new PackageVerifierIssue("SIGN_AUTHENTICODE", assemblyPath, string.Format("The PE file '{0}' in this package is not authenticode signed.", assemblyPath), MyPackageIssueLevel.Error);`
	`196`	`+ return new PackageVerifierIssue("SIGN_AUTHENTICODE", assemblyPath, string.Format("The PE file '{0}' in this package is not authenticode signed.", assemblyPath), PackageIssueLevel.Error);`
`188`	`197`	`}`
`189`	`198`
`190`	`199`	`public static PackageVerifierIssue AssemblyHasNoDocFile(string assemblyPath)`
`191`	`200`	`{`
`192`		`- return new PackageVerifierIssue("DOC_MISSING", assemblyPath, string.Format("The assembly '{0}' doesn't have a corresponding XML document file.", assemblyPath), MyPackageIssueLevel.Warning);`
	`201`	`+ return new PackageVerifierIssue("DOC_MISSING", assemblyPath, string.Format("The assembly '{0}' doesn't have a corresponding XML document file.", assemblyPath), PackageIssueLevel.Warning);`
`193`	`202`	`}`
`194`	`203`
`195`	`204`	`public static PackageVerifierIssue AssemblyHasWrongJsonNetVersion(string assemblyPath, string targetFramework, string currentVersion)`
`@@ -198,7 +207,7 @@ public static PackageVerifierIssue AssemblyHasWrongJsonNetVersion(string assembl`
`198`	`207`	`"WRONG_JSONNET_VERSION",`
`199`	`208`	`string.Format("{0}; {1}", assemblyPath, targetFramework),`
`200`	`209`	`string.Format("The assembly '{0}' references the wrong Json.NET version. Current version '{1}'; Expected version '8.0.2'.", assemblyPath, currentVersion),`
`201`		`- MyPackageIssueLevel.Error);`
	`210`	`+ PackageIssueLevel.Error);`
`202`	`211`	`}`
`203`	`212`	`}`
`204`	`213`	`}`
Original file line number	Diff line number	Diff line change
`@@ -3,7 +3,7 @@`
`3`	`3`
`4`	`4`	`namespace NuGetPackageVerifier`
`5`	`5`	`{`
`6`		`- public enum MyPackageIssueLevel`
	`6`	`+ public enum PackageIssueLevel`
`7`	`7`	`{`
`8`	`8`	`Warning,`
`9`	`9`	`Error`
Original file line number	Diff line number	Diff line change
`@@ -5,20 +5,20 @@ namespace NuGetPackageVerifier`
`5`	`5`	`{`
`6`	`6`	`public class PackageVerifierIssue`
`7`	`7`	`{`
`8`		`- public PackageVerifierIssue(string issueId, string issue, MyPackageIssueLevel level)`
	`8`	`+ public PackageVerifierIssue(string issueId, string issue, PackageIssueLevel level)`
`9`	`9`	`: this(issueId, instance: null, issue: issue, level: level)`
`10`	`10`	`{`
`11`	`11`	`}`
`12`	`12`
`13`		`- public PackageVerifierIssue(string issueId, string instance, string issue, MyPackageIssueLevel level)`
	`13`	`+ public PackageVerifierIssue(string issueId, string instance, string issue, PackageIssueLevel level)`
`14`	`14`	`{`
`15`	`15`	`Instance = instance;`
`16`	`16`	`IssueId = issueId;`
`17`	`17`	`Issue = issue;`
`18`	`18`	`Level = level;`
`19`	`19`	`}`
`20`	`20`
`21`		`- public MyPackageIssueLevel Level`
	`21`	`+ public PackageIssueLevel Level`
`22`	`22`	`{`
`23`	`23`	`get;`
`24`	`24`	`private set;`