Fix bug in the Visual Studio requirement check on non-Windows

Author: Nate McMaster

modules/KoreBuild.Tasks/GetToolsets.cs

@@ -81,7 +81,7 @@ private void GetVisualStudio(KoreBuildSettings.VisualStudioToolset vsToolset)
         {
             if (!RuntimeInformation.IsOSPlatform(OSPlatform.Windows))
             {
-                if ((vsToolset.Required & KoreBuildSettings.RequiredPlatforms.Windows) != 0)
+                if ((vsToolset.Required & ~KoreBuildSettings.RequiredPlatforms.Windows) != 0)
                 {
                     Log.LogError("Visual Studio is not available on non-Windows. Change korebuild.json to 'required: [\"windows\"]'.");
                 }

test/KoreBuild.Tasks.Tests/GetToolsetsTests.cs

@@ -0,0 +1,77 @@
+// Copyright (c) .NET Foundation. All rights reserved.
+// Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information.
+
+using System;
+using System.IO;
+using System.Runtime.InteropServices;
+using BuildTools.Tasks.Tests;
+using Xunit;
+
+namespace KoreBuild.Tasks.Tests
+{
+    public class GetToolsetsTests : IDisposable
+    {
+        private readonly string _configFile;
+
+        public GetToolsetsTests()
+        {
+            _configFile = Path.Combine(Path.GetTempPath(), Path.GetRandomFileName());
+        }
+
+        public void Dispose()
+        {
+            if (File.Exists(_configFile))
+            {
+                File.Delete(_configFile);
+            }
+        }
+
+        [Fact]
+        public void GetsToolsetsEvenNotRequired()
+        {
+            File.WriteAllText(_configFile, @"
+{
+  ""toolsets"": {
+    ""visualstudio"": {
+      ""required"": false
+    },
+    ""nodejs"": {
+      ""required"": false
+    }
+  }
+}");
+            var task = new GetToolsets
+            {
+                BuildEngine = new MockEngine(),
+                ConfigFile = _configFile,
+            };
+
+            Assert.True(task.Execute(), "Task is expected to pass");
+        }
+
+        [Fact]
+        public void FailsIfVsIsRequiredOnNonWindows()
+        {
+            if (RuntimeInformation.IsOSPlatform(OSPlatform.Windows))
+            {
+                return;
+            }
+
+            File.WriteAllText(_configFile, @"
+{
+  ""toolsets"": {
+    ""visualstudio"": {
+      ""required"": [""macos"", ""linux""]
+    }
+  }
+}");
+            var task = new GetToolsets
+            {
+                BuildEngine = new MockEngine { ContinueOnError = true },
+                ConfigFile = _configFile,
+            };
+
+            Assert.False(task.Execute(), "Task is expected to fail");
+        }
+    }
+}