Skip to content

Improve extend docs #21135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 31, 2025
Merged

Improve extend docs #21135

merged 3 commits into from
Oct 31, 2025
+12 −5

Conversation

@chirizxc
Copy link
Contributor

Summary

Closes #21073

@github-actions
Copy link
Contributor

github-actions bot commented Oct 30, 2025 •
edited
Loading

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

@amyreese amyreese added the documentation Improvements or additions to documentation label Oct 30, 2025
@amyreese amyreese requested a review from ntBre October 30, 2025 23:54
@amyreese amyreese changed the title [ruff] Fix extend docs [ruff] Improve extend docs Oct 30, 2025
@MichaReiser MichaReiser changed the title [ruff] Improve extend docs Improve extend docs Oct 31, 2025
MichaReiser
MichaReiser reviewed Oct 31, 2025
View reviewed changes
crates/ruff_workspace/src/options.rs
/// establishes a new baseline rule set and the parent's `lint.ignore`
/// rules are discarded; if the child configuration omits `lint.select`,
/// the parent's rule selection is inherited and both parent and child
/// `lint.ignore` rules are accumulated together.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed the priority part as it is somewhat unrelated to extend itself.

@MichaReiser
Copy link
Member

Thank you

@MichaReiser MichaReiser merged commit 9d7da91 into astral-sh:main Oct 31, 2025
37 checks passed
@chirizxc chirizxc deleted the settings-exclude branch October 31, 2025 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MichaReiser MichaReiser MichaReiser left review comments

@amyreese amyreese amyreese approved these changes

@ntBre ntBre ntBre approved these changes

@carljm carljm Awaiting requested review from carljm

@sharkdp sharkdp Awaiting requested review from sharkdp

@dcreager dcreager Awaiting requested review from dcreager

Assignees

No one assigned

Labels

documentation Improvements or additions to documentation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Documentation for extend doesn't accurately describe lint.ignore and lint.select behavior

4 participants

@chirizxc @MichaReiser @amyreese @ntBre