Skip to content

[ty] Update Salsa to reduce common memo revision storage#25773

Closed
MichaReiser wants to merge 1 commit into
mainfrom
micha/salsa-pr1108-codspeed
Closed

[ty] Update Salsa to reduce common memo revision storage#25773
MichaReiser wants to merge 1 commit into
mainfrom
micha/salsa-pr1108-codspeed

Conversation

@MichaReiser

Copy link
Copy Markdown
Member

No description provided.

@astral-sh-bot

astral-sh-bot Bot commented Jun 9, 2026

Copy link
Copy Markdown

Typing conformance results

No changes detected ✅

Current numbers
The percentage of diagnostics emitted that were expected errors held steady at 92.23%. The percentage of expected errors that received a diagnostic held steady at 87.42%. The number of fully passing files held steady at 92/134.

@astral-sh-bot

astral-sh-bot Bot commented Jun 9, 2026

Copy link
Copy Markdown

Memory usage report

Summary

Project Old New Diff Outcome
flake8 35.37MB 34.06MB -3.70% (1.31MB) ⬇️
trio 87.84MB 82.03MB -6.62% (5.81MB) ⬇️
sphinx 207.60MB 188.81MB -9.05% (18.79MB) ⬇️
prefect 564.52MB 511.65MB -9.37% (52.88MB) ⬇️

Significant changes

Click to expand detailed breakdown

flake8

Name Old New Diff Outcome
infer_definition_types 1.57MB 1.31MB -16.77% (270.20kB) ⬇️
infer_expression_types_impl 974.05kB 746.79kB -23.33% (227.25kB) ⬇️
infer_scope_types_impl 788.72kB 662.12kB -16.05% (126.60kB) ⬇️
member_lookup_with_policy_inner 404.40kB 292.20kB -27.74% (112.20kB) ⬇️
infer_deferred_types 428.26kB 336.23kB -21.49% (92.03kB) ⬇️
Type<'db>::class_member_with_policy_ 316.53kB 231.97kB -26.71% (84.56kB) ⬇️
StaticClassLiteral<'db>::try_mro_ 291.81kB 247.30kB -15.25% (44.51kB) ⬇️
Type<'db>::apply_specialization_inner_ 181.69kB 143.90kB -20.80% (37.79kB) ⬇️
place_by_id 141.45kB 113.90kB -19.48% (27.55kB) ⬇️
FunctionType<'db>::signature_ 278.53kB 254.84kB -8.51% (23.69kB) ⬇️
when_constraint_set_assignable_to_owned_impl 159.03kB 136.91kB -13.91% (22.12kB) ⬇️
function_known_decorators 146.02kB 125.70kB -13.91% (20.32kB) ⬇️
cached_protocol_interface 56.44kB 39.10kB -30.72% (17.34kB) ⬇️
is_redundant_with_impl 76.27kB 59.02kB -22.62% (17.25kB) ⬇️
overloads_and_implementation_inner 79.38kB 64.77kB -18.41% (14.62kB) ⬇️
... 66 more

trio

Name Old New Diff Outcome
infer_expression_types_impl 6.57MB 4.98MB -24.24% (1.59MB) ⬇️
infer_definition_types 6.61MB 5.46MB -17.33% (1.14MB) ⬇️
infer_scope_types_impl 3.78MB 3.15MB -16.66% (644.09kB) ⬇️
member_lookup_with_policy_inner 1.42MB 1.03MB -27.39% (397.02kB) ⬇️
infer_deferred_types 1.72MB 1.35MB -21.06% (370.14kB) ⬇️
Type<'db>::class_member_with_policy_ 1.15MB 862.16kB -26.60% (312.50kB) ⬇️
Type<'db>::apply_specialization_inner_ 557.27kB 438.89kB -21.24% (118.38kB) ⬇️
place_by_id 568.00kB 454.80kB -19.93% (113.20kB) ⬇️
StaticClassLiteral<'db>::try_mro_ 715.82kB 605.77kB -15.37% (110.05kB) ⬇️
all_narrowing_constraints_for_expression 1012.84kB 913.16kB -9.84% (99.68kB) ⬇️
FunctionType<'db>::signature_ 746.04kB 666.06kB -10.72% (79.98kB) ⬇️
FunctionType<'db>::last_definition_raw_signature_ 789.26kB 710.03kB -10.04% (79.23kB) ⬇️
overloads_and_implementation_inner 327.13kB 266.62kB -18.50% (60.51kB) ⬇️
when_constraint_set_assignable_to_owned_impl 401.74kB 353.77kB -11.94% (47.98kB) ⬇️
resolve_module_query 147.66kB 102.52kB -30.57% (45.14kB) ⬇️
... 74 more

sphinx

Name Old New Diff Outcome
infer_expression_types_impl 20.49MB 15.46MB -24.54% (5.03MB) ⬇️
infer_definition_types 20.72MB 16.84MB -18.73% (3.88MB) ⬇️
infer_scope_types_impl 12.55MB 10.63MB -15.28% (1.92MB) ⬇️
member_lookup_with_policy_inner 5.64MB 4.06MB -28.05% (1.58MB) ⬇️
Type<'db>::class_member_with_policy_ 4.63MB 3.38MB -26.99% (1.25MB) ⬇️
infer_deferred_types 3.88MB 3.06MB -21.26% (845.72kB) ⬇️
all_narrowing_constraints_for_expression 4.11MB 3.74MB -9.12% (384.07kB) ⬇️
StaticClassLiteral<'db>::try_mro_ 2.23MB 1.89MB -15.44% (352.88kB) ⬇️
Type<'db>::apply_specialization_inner_ 1.52MB 1.20MB -21.03% (326.36kB) ⬇️
place_by_id 1.38MB 1.11MB -19.48% (276.14kB) ⬇️
FunctionType<'db>::last_definition_raw_signature_ 2.92MB 2.67MB -8.68% (259.88kB) ⬇️
when_constraint_set_assignable_to_owned_impl 1.50MB 1.28MB -14.71% (225.71kB) ⬇️
is_redundant_with_impl 919.57kB 719.61kB -21.75% (199.96kB) ⬇️
FunctionType<'db>::signature_ 1.79MB 1.63MB -8.91% (163.31kB) ⬇️
StaticClassLiteral<'db>::implicit_attribute_inner_ 699.14kB 537.84kB -23.07% (161.31kB) ⬇️
... 82 more

prefect

Name Old New Diff Outcome
infer_definition_types 75.88MB 61.69MB -18.69% (14.18MB) ⬇️
infer_expression_types_impl 55.21MB 42.33MB -23.32% (12.88MB) ⬇️
infer_scope_types_impl 47.64MB 40.69MB -14.59% (6.95MB) ⬇️
member_lookup_with_policy_inner 13.53MB 9.77MB -27.81% (3.76MB) ⬇️
Type<'db>::class_member_with_policy_ 10.02MB 7.40MB -26.07% (2.61MB) ⬇️
infer_deferred_types 8.75MB 7.00MB -20.01% (1.75MB) ⬇️
all_narrowing_constraints_for_expression 13.21MB 12.19MB -7.70% (1.02MB) ⬇️
place_by_id 5.04MB 4.05MB -19.77% (1020.86kB) ⬇️
Type<'db>::apply_specialization_inner_ 3.18MB 2.49MB -21.64% (704.26kB) ⬇️
StaticClassLiteral<'db>::try_mro_ 4.33MB 3.68MB -15.00% (665.04kB) ⬇️
function_known_decorators 3.92MB 3.32MB -15.47% (621.73kB) ⬇️
overloads_and_implementation_inner 2.63MB 2.15MB -18.24% (490.47kB) ⬇️
FunctionType<'db>::last_definition_raw_signature_ 5.89MB 5.42MB -7.99% (481.65kB) ⬇️
is_redundant_with_impl 1.99MB 1.54MB -22.47% (457.12kB) ⬇️
when_constraint_set_assignable_to_owned_impl 3.05MB 2.64MB -13.39% (417.70kB) ⬇️
... 78 more

@astral-sh-bot

astral-sh-bot Bot commented Jun 9, 2026

Copy link
Copy Markdown

ecosystem-analyzer results

No diagnostic changes detected ✅

Full report with detailed diff (timing results)

@codspeed-hq

codspeed-hq Bot commented Jun 9, 2026

Copy link
Copy Markdown

Merging this PR will improve performance by 4.85%

⚡ 4 improved benchmarks
✅ 123 untouched benchmarks

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Memory ty_check_file[incremental] 137 KB 129.2 KB +6.05%
Memory ty_micro[typevar_mapping_small_accumulations] 13.7 MB 13.1 MB +4.85%
Memory anyio 64.4 MB 61.7 MB +4.37%
Memory hydra-zen 57.3 MB 55 MB +4.13%

Tip

Curious why this is faster? Use the CodSpeed MCP and ask your agent.


Comparing micha/salsa-pr1108-codspeed (b6e2259) with main (267af00)

Open in CodSpeed

@astral-sh-bot

astral-sh-bot Bot commented Jun 9, 2026

Copy link
Copy Markdown

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

Formatter (stable)

✅ ecosystem check detected no format changes.

Formatter (preview)

ℹ️ ecosystem check encountered format errors. (no format changes; 1 project error)

apache/airflow (error)

ruff format --preview

warning: Detected debug build without --no-cache.
error: Encountered error: No such file or directory (os error 2)
error: Encountered error: No such file or directory (os error 2)
error: Encountered error: No such file or directory (os error 2)
error: Encountered error: No such file or directory (os error 2)
error: Encountered error: No such file or directory (os error 2)
error: Encountered error: No such file or directory (os error 2)
error: Encountered error: No such file or directory (os error 2)
error: Encountered error: No such file or directory (os error 2)
error: Encountered error: No such file or directory (os error 2)
error: Encountered error: No such file or directory (os error 2)
error: Encountered error: No such file or directory (os error 2)

@MichaReiser

Copy link
Copy Markdown
Member Author

This has merged upstream and we'll pull this in with the next salsa update

@MichaReiser MichaReiser closed this Jun 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant