Skip to content

fix: update broken git-workflow.md link in welcome message - #391

Merged
asyncapi-bot merged 9 commits into
asyncapi:masterfrom
Varadraj75:fix/update-git-workflow-link
Jun 8, 2026
Merged

fix: update broken git-workflow.md link in welcome message#391
asyncapi-bot merged 9 commits into
asyncapi:masterfrom
Varadraj75:fix/update-git-workflow-link

Conversation

@Varadraj75

Copy link
Copy Markdown
Contributor

Description

  • Updated the broken link in the GitHub Actions welcome message workflow
  • The old link git-workflow.md was returning a 404 as the file no longer exists
  • Replaced with the correct updated path docs/010-contribution-guidelines/tools-and-setup.md

Related issue(s)

Resolves asyncapi/community#2264

Copilot AI review requested due to automatic review settings March 9, 2026 13:39

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the “basic recommended setup” link in the first-time contributor welcome message workflow to point to the current documentation location in asyncapi/community, fixing a 404.

Changes:

  • Replaced the obsolete git-workflow.md URL with docs/010-contribution-guidelines/tools-and-setup.md in the issue welcome message.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

@Florence-Njeri Florence-Njeri left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Varadraj75 thank you for contributing to AsyncAPI!

I just checked and the bot link is indeed broken, however I think this might be the correct link: https://github.com/asyncapi/community/blob/master/docs/010-contribution-guidelines/git-workflow.md

cc: @thulieblack please confirm. The link seems to have been broken by this PR: asyncapi/community#1833

@thulieblack

Copy link
Copy Markdown
Member

Yes thats correct, thanks Florence

Comment thread .github/workflows/welcome-first-time-contrib.yml Outdated
Co-authored-by: Florence Njeri <40742916+Florence-Njeri@users.noreply.github.com>
@ksaini-web

Copy link
Copy Markdown

Hi @Varadraj75 👋

I noticed from the review that the correct link should point to docs/010-contribution-guidelines/git-workflow.md.

Happy to help update this if needed. Let me know if I can assist 🙂

@Varadraj75

Copy link
Copy Markdown
Contributor Author

hey @ksaini-web , i have already done the requested changes , waiting for the reivew.
thank you so much for showing your interest.

@Shurtu-gal Shurtu-gal left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Varadraj75. LGTM 🚀

@Shurtu-gal

Copy link
Copy Markdown
Collaborator

/rtm

@github-actions

Copy link
Copy Markdown

Hello, @Shurtu-gal! 👋🏼
This PR is not up to date with the base branch and can't be merged.
Please update your branch manually with the latest version of the base branch.
PRO-TIP: To request an update from the upstream branch, simply comment /u or /update and our bot will handle the update operation promptly.

       The only requirement for this to work is to enable [Allow edits from maintainers](https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/allowing-changes-to-a-pull-request-branch-created-from-a-fork) option in your PR. Also the update will not work if your fork is located in an organization, not under your personal profile.
       Thanks 😄

@Shurtu-gal

Copy link
Copy Markdown
Collaborator

Workflows are working 👍🏻

@derberg

derberg commented May 7, 2026

Copy link
Copy Markdown
Member

@Florence-Njeri since you technically requested changes, you need to approve after changes from contributor, otherwise we cannot merge

@Florence-Njeri

Copy link
Copy Markdown
Collaborator

/rtm

@asyncapi-bot
asyncapi-bot merged commit b57fee0 into asyncapi:master Jun 8, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Broken link to git-workflow.md in GitHub Actions bot message

9 participants