Skip to content

Conversation

@lightning-sagar
Copy link

Description

  • This PR fixes a SonarCloud issue related to mutable static fields (TypeScript rule S1444).
  • Made public static fields readonly in src/apps/cli/commands/config/auth/add.ts

Related issue(s)
Part 1 - fixing #1881

@changeset-bot
Copy link

changeset-bot bot commented Oct 27, 2025

🦋 Changeset detected

Latest commit: 5be245f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@asyncapi/cli Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

@lightning-sagar lightning-sagar changed the title Fix sonarcloud issue making readonly fix sonarcloud issue making readonly Oct 27, 2025
@lightning-sagar lightning-sagar changed the title fix sonarcloud issue making readonly fix: make static properties readonly to resolve SonarCloud issue S1444 Oct 27, 2025
@github-actions
Copy link
Contributor

Changeset has been generated for this PR as part of auto-changeset workflow.

Please review the changeset before merging the PR.
---
'@asyncapi/cli': patch
---

fix: make static properties readonly to resolve SonarCloud issue S1444

- 0955372: fix: make static properties readonly to resolve SonarCloud issue S1444
- d066eee: fix: make static properties readonly to resolve SonarCloud issue S1444

If you are a maintainer or the author of the PR, you can change the changeset by clicking here

Tip

If you don't want auto-changeset to run on this PR, you can add the label skip-changeset to the PR or remove the changeset and change PR title to something other than fix: or feat:.

@sonarqubecloud
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: To Triage

Development

Successfully merging this pull request may close these issues.

1 participant