feat(pyatlan_v9): sync models from atlanhq/models BLDX-1206 [ PART-1069 ]#947
Merged
Conversation
Regenerates pyatlan_v9 from the rebased BLDX-1206 branch of atlanhq/models (PR #1960), which is master + renderer/toolkit/workflow improvements. Brings in master content not yet reflected in pyatlan_v9: - Unstructured asset hierarchy from atlanhq/models#1958 (Unstructured, UnstructuredContainer, UnstructuredFolder, UnstructuredObject) — final no-suffix form after master's V-suffix drop - Shared summary attributes propagated to every asset (assetSummaryProvider, assetSummary, assetSummaryFilterTokens) - SapErpFioriApp and SAP BW asset hierarchy (sapbw, sapbwadso, sapbw_data_source/info_*/query/transformation, etc.) - Agent and agent_related typedefs - SnowflakeListing and SnowflakeShare - Context repositories relation across all assets - Coalesce SQL attributes on Snowflake Removed orphaned V2-suffix files now superseded by the unsuffixed generation: unstructured_v2*.py, _init_unstructured_v2.py. Generation uses BLDX-1206's renderer fixes (semantic field on Entity, validate/minimize/relate overlay support, regularizeRelationships, Knowledge typedef fix) which produce a leaner, more stable output than master alone. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
prateek11rai
changed the title
The renderer on atlanhq/models#1960 mis-rewrites `_validate_connector_type_value` (a v8 helper in pyatlan/model/assets/connection.py) as an import from pyatlan_v9.model.assets.connection — i.e. the file imports from itself, causing a circular ImportError that breaks tests_v9/unit/ collection. Restore the original v8 import path. Inline comment marks this as a hand-patch to be reverted when the renderer is fixed upstream. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Collaborator
Author
|
Note: one file was hand-patched — The BLDX-1206 renderer mis-rewrites I restored the original v8 import path and added an inline comment marking the line as a hand-patch to be reverted when the upstream renderer is fixed. Surfaced upstream as a comment on atlanhq/models#1960. |
Aryamanz29
approved these changes
Jun 1, 2026
Member
Aryamanz29
left a comment
Aryamanz29
left a comment
There was a problem hiding this comment.
LGTM - thanks! @prateek11rai 🚀
Aryamanz29
added
feature
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Regenerates
pyatlan_v9from the rebasedBLDX-1206branch ofatlanhq/models, which ismaster+ renderer/toolkit/workflow improvements.What's new (brought in from
models@master)Unstructured,UnstructuredContainer,UnstructuredFolder,UnstructuredObject+ related — final no-suffix form after master's V-suffix dropassetSummaryProvider,assetSummary,assetSummaryFilterTokenssapbw,sapbwadso,sapbw_data_source,sapbw_info_*,sapbw_query,sapbw_transformation,sapbwdtp, etc.sap_column_process,sap_erp_fiori_app,sap_processsnowflake_listing,snowflake_share, plus Coalesce SQL attributes onSnowflakeagent,agent_relatedWhat's removed
unstructured_v2*.pyand_init_unstructured_v2.py— superseded by the unsuffixed regeneration, no remaining imports in the codebaseGenerator-level improvements (from BLDX-1206 renderer fixes)
Generation used atlanhq/models#1960's renderer commits on top of master:
semanticfield added toEntitybase classvalidate()/minimize()/relate()SDK methods via overlay systemregularizeRelationshipsfor cleaner Atlas JSONtype_namedefaults toUNSETfor correct serializationNumbers
+32,131/-1,254)unstructured_v2*orphans)Context
🤖 Generated with Claude Code