Confluence: limit args does not work in get_all_pages_from_space function

[banziyeoh]

Results length returned from the API will not trigger break if it equals to limit.

In line 677:

     if len(results) < limit:
                break

I am setting limit to 1 and results returned with size 1 will not meet this condition and causing additional API calls, even thought the limit has reached.

The fix:

     if len(results) <= limit:
                break

[mattinm]

This is not the fix to this problem. If there are multiple pages len(results) == limit is expected, as you would get the limit amount per page. This would stop pagination entirely.

As far as I can tell, the only real way to stop pagination against Confluence REST API is to make on additional call as you aren't given the total back like you are with Jira.