Skip to content

Commit 91b51e0

Browse files
committed
fix: pass /EHsc on windows
1 parent 37754d1 commit 91b51e0

File tree

2 files changed

+3
-2
lines changed

2 files changed

+3
-2
lines changed

binding.gyp

+2-1
Original file line numberDiff line numberDiff line change
@@ -133,11 +133,12 @@
133133
],
134134
"msvs_settings": {
135135
"VCCLCompilerTool": {
136-
'ExceptionHandling': 0, # /EHsc
137136
'MultiProcessorCompilation': 'true',
138137
"AdditionalOptions": [
139138
# C++ standard
140139
"/std:c++<(STANDARD)",
140+
141+
"/EHsc" # C++ exception handling
141142
]
142143
}
143144
}

package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
"build:node": "node-gyp rebuild",
99
"build:browser": "bash -c script/build-browser-version.sh || echo 'the browser build is unsupported'",
1010
"build": "npm run build:node && npm run build:browser",
11-
"test:native": "node-gyp rebuild --debug --tests && node script/test-native.js",
11+
"test:native": "node-gyp configure --debug --tests && node-gyp build --debug --tests && node script/test-native.js",
1212
"test:node": "mocha test/js/*.js",
1313
"test:browser": "cross-env SUPERSTRING_USE_BROWSER_VERSION=1 mocha test/js/*.js || echo 'the browser tests are unsupported'",
1414
"test": "npm run test:node && npm run test:native && npm run test:browser",

0 commit comments

Comments
 (0)