Skip to content

Commit c28018d

Browse files
committed
fix: pass /EHsc on windows
1 parent a6b6334 commit c28018d

File tree

2 files changed

+3
-2
lines changed

2 files changed

+3
-2
lines changed

binding.gyp

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -131,11 +131,12 @@
131131
],
132132
"msvs_settings": {
133133
"VCCLCompilerTool": {
134-
'ExceptionHandling': 0, # /EHsc
135134
'MultiProcessorCompilation': 'true',
136135
"AdditionalOptions": [
137136
# C++ standard
138137
"/std:c++<(STANDARD)",
138+
139+
"/EHsc" # C++ exception handling
139140
]
140141
}
141142
}

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
"build:node": "node-gyp rebuild",
99
"build:browser": "bash -c script/build-browser-version.sh || echo 'the browser build is unsupported'",
1010
"build": "npm run build:node && npm run build:browser",
11-
"test:native": "node-gyp rebuild --debug --tests && node script/test-native.js",
11+
"test:native": "node-gyp configure --debug --tests && node-gyp build --debug --tests && node script/test-native.js",
1212
"test:node": "mocha test/js/*.js",
1313
"test:browser": "cross-env SUPERSTRING_USE_BROWSER_VERSION=1 mocha test/js/*.js || echo 'the browser tests are unsupported'",
1414
"test": "npm run test:node && npm run test:native && npm run test:browser",

0 commit comments

Comments
 (0)