Explicit refresh button

[smashwilson]

We'd explicitly omitted this in #1523 in favor of fetching PR data on git fetch or push, but... I think it does feel a little too "magical" and hidden to me.

The only reason I wanted to see what it was like without one is because when I see a refresh icon I can't help but jam it compulsively. ...Especially when I'm watching build statuses. Maybe that doesn't actually matter?

Do we have any ideas about how we could let users refresh, but not trigger that tic? Or am I the only one who does that?

/cc @simurai

[simurai]

how could we let users refresh, but not trigger that tic?

Option 1

@sguthals + @donokuda had a good idea: Show when it was last refreshed.

Would that help in saying: "Calm down, @smashwilson, you already refreshed 2 minutes ago". 😆

Downside: UI clutter. Might not help with the tic.

Option 2

Have the option to refresh only from a context menu. Then it's there if you really need it, but might not trigger constant "jamming" because it takes 2 clicks. To make it a bit more discoverable, add a ... icon to the right that opens a context-menu with a left-click.

Downside: We don't have a left-click drop-down menu and would need to first create one. Or maybe it's possible to open a "native" context-menu when left-clicking on the icon?

[smashwilson]

Do we want a refresh button for each accordion list? I was thinking of having just one for the whole DockItem. Or maybe we can show one on each list header, but any of them refresh all of the lists? 🤔

Show when it was last refreshed.

I like this 👍

Downside: UI clutter.

Yah. We could use our short timeago snippets to help this a little maybe?

[Arcanemagus]

I believe ac4d3a1 was meant to be a PR for this issue.

[simurai]

I believe ac4d3a1 was meant to be a PR for this issue.

That 👻 ghost commit was for the PR detail pane. Before, that refresh button was next to the "Checkout" button:

Do we want a refresh button for each accordion list? I was thinking of having just one for the whole DockItem.

Or at the bottom, kinda like a dock-item status-bar:

At the top it feels a bit odd, like it's not important enough. Maybe if there is something else, like a search/filter input? Then the refresh button could be on the right.