block/crypto: Fix memory leak in create error path

kevmw · kevmw · commit 0b68589d17ef · 2018-07-05T10:29:19.000+02:00
Fixes: Coverity CID 1393782
Signed-off-by: Kevin Wolf &lt;kwolf@redhat.com&gt;
Reviewed-by: Daniel P. Berrangé &lt;berrange@redhat.com&gt;
diff --git a/block/crypto.c b/block/crypto.c
@@ -551,7 +551,7 @@ static int coroutine_fn block_crypto_co_create_opts_luks(const char *filename,
     /* Create protocol layer */
     ret = bdrv_create_file(filename, opts, errp);
     if (ret < 0) {
-        return ret;
+        goto fail;
     }
 
     bs = bdrv_open(filename, NULL, NULL,

Original file line number	Diff line number	Diff line change
`@@ -551,7 +551,7 @@ static int coroutine_fn block_crypto_co_create_opts_luks(const char *filename,`
`551`	`551`	`/* Create protocol layer */`
`552`	`552`	`ret = bdrv_create_file(filename, opts, errp);`
`553`	`553`	`if (ret < 0) {`
`554`		`- return ret;`
	`554`	`+ goto fail;`
`555`	`555`	`}`
`556`	`556`
`557`	`557`	`bs = bdrv_open(filename, NULL, NULL,`