Skip to content

Commit 8f0a371

Browse files
author
Markus Armbruster
committed
Clean up includes
Clean up includes so that osdep.h is included first and headers which it implies are not included manually. This commit was created with scripts/clean-includes, with the change to target/s390x/gen-features.c manually reverted, and blank lines around deletions collapsed. Reviewed-by: Eric Blake <[email protected]> Reviewed-by: Thomas Huth <[email protected]> Reviewed-by: Philippe Mathieu-Daudé <[email protected]> Signed-off-by: Markus Armbruster <[email protected]> Message-Id: <[email protected]>
1 parent d8e39b7 commit 8f0a371

30 files changed

+9
-51
lines changed

block/parallels.h

-1
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,6 @@
3232
#ifndef BLOCK_PARALLELS_H
3333
#define BLOCK_PARALLELS_H
3434
#include "qemu/coroutine.h"
35-
#include "qemu/typedefs.h"
3635

3736
#define HEADS_NUMBER 16
3837
#define SEC_IN_CYL 32

hw/block/vhost-user-blk.c

-1
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,6 @@
1919
#include "qemu/osdep.h"
2020
#include "qapi/error.h"
2121
#include "qemu/error-report.h"
22-
#include "qemu/typedefs.h"
2322
#include "qemu/cutils.h"
2423
#include "qom/object.h"
2524
#include "hw/qdev-core.h"

hw/nvram/eeprom_at24c.c

+1-2
Original file line numberDiff line numberDiff line change
@@ -7,9 +7,8 @@
77
* the LICENSE file in the top-level directory.
88
*/
99

10-
#include <string.h>
11-
1210
#include "qemu/osdep.h"
11+
1312
#include "qapi/error.h"
1413
#include "hw/hw.h"
1514
#include "hw/i2c/i2c.h"

hw/tpm/tpm_emulator.c

-5
Original file line numberDiff line numberDiff line change
@@ -40,11 +40,6 @@
4040
#include "qapi/clone-visitor.h"
4141
#include "chardev/char-fe.h"
4242

43-
#include <fcntl.h>
44-
#include <sys/types.h>
45-
#include <sys/stat.h>
46-
#include <stdio.h>
47-
4843
#define DEBUG_TPM 0
4944

5045
#define DPRINTF(fmt, ...) do { \

hw/tpm/tpm_int.h

-2
Original file line numberDiff line numberDiff line change
@@ -12,8 +12,6 @@
1212
#ifndef TPM_TPM_INT_H
1313
#define TPM_TPM_INT_H
1414

15-
#include "qemu/osdep.h"
16-
1715
#define TPM_STANDARD_CMDLINE_OPTS \
1816
{ \
1917
.name = "type", \

hw/tpm/tpm_ioctl.h

-2
Original file line numberDiff line numberDiff line change
@@ -8,9 +8,7 @@
88
#ifndef _TPM_IOCTL_H_
99
#define _TPM_IOCTL_H_
1010

11-
#include <stdint.h>
1211
#include <sys/uio.h>
13-
#include <sys/types.h>
1412
#include <sys/ioctl.h>
1513

1614
/*

hw/xtensa/xtensa_memory.h

-1
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,6 @@
2828
#ifndef _XTENSA_MEMORY_H
2929
#define _XTENSA_MEMORY_H
3030

31-
#include "qemu/osdep.h"
3231
#include "qemu-common.h"
3332
#include "cpu.h"
3433
#include "exec/memory.h"

include/exec/tb-lookup.h

-2
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,6 @@
77
#ifndef EXEC_TB_LOOKUP_H
88
#define EXEC_TB_LOOKUP_H
99

10-
#include "qemu/osdep.h"
11-
1210
#ifdef NEED_CPU_H
1311
#include "cpu.h"
1412
#else

include/hw/intc/xlnx-pmu-iomod-intc.h

-1
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,6 @@
2525
#ifndef XLNX_PMU_IO_INTC_H
2626
#define XLNX_PMU_IO_INTC_H
2727

28-
#include "qemu/osdep.h"
2928
#include "hw/sysbus.h"
3029
#include "hw/register.h"
3130

include/hw/intc/xlnx-zynqmp-ipi.h

-1
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,6 @@
2525
#ifndef XLNX_ZYNQMP_IPI_H
2626
#define XLNX_ZYNQMP_IPI_H
2727

28-
#include "qemu/osdep.h"
2928
#include "hw/sysbus.h"
3029
#include "hw/register.h"
3130

include/hw/nvram/fw_cfg.h

-1
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
#ifndef FW_CFG_H
22
#define FW_CFG_H
33

4-
#include "qemu/typedefs.h"
54
#include "exec/hwaddr.h"
65
#include "hw/nvram/fw_cfg_keys.h"
76
#include "hw/sysbus.h"

include/hw/pci-bridge/simba.h

-1
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,6 @@
2424
* THE SOFTWARE.
2525
*/
2626

27-
#include "qemu/osdep.h"
2827
#include "hw/pci/pci_bridge.h"
2928

3029

include/hw/xtensa/xtensa-isa.h

-2
Original file line numberDiff line numberDiff line change
@@ -25,8 +25,6 @@
2525
#ifndef XTENSA_LIBISA_H
2626
#define XTENSA_LIBISA_H
2727

28-
#include <stdint.h>
29-
3028
#ifdef __cplusplus
3129
extern "C" {
3230
#endif

include/qapi/clone-visitor.h

-1
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@
1111
#ifndef QAPI_CLONE_VISITOR_H
1212
#define QAPI_CLONE_VISITOR_H
1313

14-
#include "qemu/typedefs.h"
1514
#include "qapi/visitor.h"
1615
#include "qapi-visit.h"
1716

include/sysemu/hvf.h

-2
Original file line numberDiff line numberDiff line change
@@ -12,8 +12,6 @@
1212
#ifndef _HVF_H
1313
#define _HVF_H
1414

15-
#include "config-host.h"
16-
#include "qemu/osdep.h"
1715
#include "qemu-common.h"
1816
#include "qemu/bitops.h"
1917
#include "exec/memory.h"

include/ui/console.h

-1
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@
55
#include "qom/object.h"
66
#include "qapi/qmp/qdict.h"
77
#include "qemu/notify.h"
8-
#include "qemu/typedefs.h"
98
#include "qapi-types.h"
109
#include "qemu/error-report.h"
1110
#include "qapi/error.h"

io/channel-websock.c

-3
Original file line numberDiff line numberDiff line change
@@ -26,9 +26,6 @@
2626
#include "trace.h"
2727
#include "qemu/iov.h"
2828

29-
#include <time.h>
30-
31-
3229
/* Max amount to allow in rawinput/encoutput buffers */
3330
#define QIO_CHANNEL_WEBSOCK_MAX_BUFFER 8192
3431

linux-user/syscall.c

-1
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,6 @@
4444
#include <sys/shm.h>
4545
#include <sys/sem.h>
4646
#include <sys/statfs.h>
47-
#include <time.h>
4847
#include <utime.h>
4948
#include <sys/sysinfo.h>
5049
#include <sys/signalfd.h>

scsi/pr-helper.h

-2
Original file line numberDiff line numberDiff line change
@@ -26,8 +26,6 @@
2626
#ifndef QEMU_PR_HELPER_H
2727
#define QEMU_PR_HELPER_H 1
2828

29-
#include <stdint.h>
30-
3129
#define PR_HELPER_CDB_SIZE 16
3230
#define PR_HELPER_SENSE_SIZE 96
3331
#define PR_HELPER_DATA_SIZE 8192

target/i386/hvf/vmx.h

-1
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,6 @@
2525
#ifndef VMX_H
2626
#define VMX_H
2727

28-
#include <stdint.h>
2928
#include <Hypervisor/hv.h>
3029
#include <Hypervisor/hv_vmx.h>
3130
#include "vmcs.h"

target/i386/hvf/x86hvf.c

-3
Original file line numberDiff line numberDiff line change
@@ -29,11 +29,8 @@
2929

3030
#include "hw/i386/apic_internal.h"
3131

32-
#include <stdio.h>
33-
#include <stdlib.h>
3432
#include <Hypervisor/hv.h>
3533
#include <Hypervisor/hv_vmx.h>
36-
#include <stdint.h>
3734

3835
void hvf_set_segment(struct CPUState *cpu, struct vmx_segment *vmx_seg,
3936
SegmentCache *qseg, bool is_tr)

target/xtensa/core-dc232b/xtensa-modules.c

+1
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@
1818
Foundation, Inc., 51 Franklin Street - Fifth Floor, Boston, MA
1919
02110-1301, USA. */
2020

21+
#include "qemu/osdep.h"
2122
#include "xtensa-isa.h"
2223
#include "xtensa-isa-internal.h"
2324

target/xtensa/core-dc233c/xtensa-modules.c

+1
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@
2121
TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE
2222
SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE. */
2323

24+
#include "qemu/osdep.h"
2425
#include "xtensa-isa.h"
2526
#include "xtensa-isa-internal.h"
2627

target/xtensa/core-de212/xtensa-modules.c

+1
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@
2121
TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE
2222
SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE. */
2323

24+
#include "qemu/osdep.h"
2425
#include "xtensa-isa.h"
2526
#include "xtensa-isa-internal.h"
2627

target/xtensa/core-fsf/xtensa-modules.c

+1
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@
1818
Foundation, Inc., 51 Franklin Street - Fifth Floor, Boston, MA
1919
02110-1301, USA. */
2020

21+
#include "qemu/osdep.h"
2122
#include "xtensa-isa.h"
2223
#include "xtensa-isa-internal.h"
2324

target/xtensa/core-sample_controller/xtensa-modules.c

+1
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@
2121
TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE
2222
SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE. */
2323

24+
#include "qemu/osdep.h"
2425
#include "xtensa-isa.h"
2526
#include "xtensa-isa-internal.h"
2627

target/xtensa/xtensa-isa.c

+1-3
Original file line numberDiff line numberDiff line change
@@ -22,9 +22,7 @@
2222
* SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
2323
*/
2424

25-
#include <stdio.h>
26-
#include <stdlib.h>
27-
#include <string.h>
25+
#include "qemu/osdep.h"
2826
#include "xtensa-isa.h"
2927
#include "xtensa-isa-internal.h"
3028

tests/migration/stress.c

+1-9
Original file line numberDiff line numberDiff line change
@@ -17,21 +17,13 @@
1717
* License along with this library; if not, see <http://www.gnu.org/licenses/>.
1818
*/
1919

20-
#include <stdio.h>
20+
#include "qemu/osdep.h"
2121
#include <getopt.h>
22-
#include <string.h>
23-
#include <stdlib.h>
24-
#include <errno.h>
25-
#include <unistd.h>
2622
#include <sys/reboot.h>
2723
#include <sys/syscall.h>
2824
#include <linux/random.h>
29-
#include <sys/time.h>
3025
#include <pthread.h>
31-
#include <fcntl.h>
3226
#include <sys/mount.h>
33-
#include <sys/stat.h>
34-
#include <sys/mman.h>
3527

3628
const char *argv0;
3729

tests/ptimer-test.c

+1-1
Original file line numberDiff line numberDiff line change
@@ -8,9 +8,9 @@
88
*
99
*/
1010

11+
#include "qemu/osdep.h"
1112
#include <glib/gprintf.h>
1213

13-
#include "qemu/osdep.h"
1414
#include "qemu/main-loop.h"
1515
#include "hw/ptimer.h"
1616

trace/control-internal.h

-2
Original file line numberDiff line numberDiff line change
@@ -10,8 +10,6 @@
1010
#ifndef TRACE__CONTROL_INTERNAL_H
1111
#define TRACE__CONTROL_INTERNAL_H
1212

13-
#include <stddef.h> /* size_t */
14-
1513
#include "qom/cpu.h"
1614

1715

0 commit comments

Comments
 (0)