Support for dark mode

[amotl]

Dear @attakei,

@simonprickett reviewed the docs page ¹ where we are enumerating a few use case examples of oEmbedPy/Sphinx. Within our Sphinx theme, which is building upon sphinx-basic-ng and Furo, users can choose to select dark mode for display.

In this mode, it becomes apparent that oEmbedPy's HTML/CSS output might not consider dark mode, yet.

Would it be something that could be improved?

With kind regards,
Andreas.

/cc @msbt

Footnotes

1. https://crate-docs-theme.readthedocs.io/en/latest/myst/oembed.html ↩

[attakei]

I don't know for this and think that it is difficult.
Because your pages and embedded contents are from different origin, then we cannot almost control contents as far as I know.

It maybe can handle by outside depending to format, but responded html are not same, and it is hard to support all.

[amotl]

Hi Kazuya,

thanks for your reply. I see that it may become difficult. Maybe @msbt has a good idea?

With kind regards,
Andreas.

[msbt]

For some embeds it's easy enough to just add a &theme=dark parameter, like reddit. Twitter/X comes with &theme=light by default, so this would need to be found and replaced. Bluesky doesn't seem to have a dark-mode just yet. So in theory we could whip up some js magic to check which data-theme is set on html/body and attach that value to the iframe. Not the cleanest solution (because it requires re-rendering after the page was loaded), but it could be a start:

Unrelated: No idea why X has those white borders