CP-12379: Add xpub to avalanche get accounts #3291
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
B0Y3R-AVA
requested review from
atn4z7,
bogdandobritoiu,
onghwan and
ruijialin-avalabs
as code owners
atn4z7
reviewed
Oct 16, 2025
Comment on lines
35
to
43
| const getXpubXP = async ( | ||
| walletId: string, | ||
| walletType: WalletType | ||
| ): Promise<string | undefined> => { | ||
| try { | ||
| // Only mnemonic and keystone wallets support xpubXP | ||
| if ( | ||
| walletType === WalletType.MNEMONIC || | ||
| walletType === WalletType.KEYSTONE | ||
| ) { | ||
| return await WalletService.getRawXpubXP({ walletId, walletType }) | ||
| } | ||
| return undefined | ||
| } catch (error) { | ||
| Logger.warn(`Failed to get xpubXP for wallet ${walletId}:`, error) | ||
| return undefined | ||
| } | ||
| }) | ||
| } |
There was a problem hiding this comment.
you should now be able to just call WalletService.getRawXpubXP() and fall back to undefined when it throws error. no need to check the wallet type here.
B0Y3R-AVA
force-pushed
the
boyer/CP-12379
branch
from
8437323 to
80807ec
Compare
atn4z7
approved these changes
Oct 16, 2025
B0Y3R-AVA
force-pushed
the
boyer/CP-12379
branch
from
80807ec to
316ec87
Compare
ruijialin-avalabs
approved these changes
Oct 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Ticket: CP-12379
Please provide:
Added logic to fetch xpub and add it to response for
avalanche_getAccountsScreenshots/Videos
Include relevant screenshots or screen recordings of iOS and Android.
Testing
Dev Testing (if applicable)
avalance_getAccountsrpc call in dropdown select and fire it offQA Testing (if applicable)
Checklist
Please check all that apply (if applicable)