-
Notifications
You must be signed in to change notification settings - Fork 602
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Validate deployment files #3884
Open
kddejong
wants to merge
14
commits into
aws-cloudformation:main
Choose a base branch
from
kddejong:fix/issue/3721
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12cf66e
to
d623724
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3884 +/- ##
==========================================
+ Coverage 93.89% 94.03% +0.13%
==========================================
Files 375 390 +15
Lines 12975 13317 +342
Branches 2550 2613 +63
==========================================
+ Hits 12183 12522 +339
Misses 438 438
- Partials 354 357 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
9494437
to
6c18ed7
Compare
7e57f0f
to
1e79c52
Compare
839feec
to
16af481
Compare
9517058
to
4274877
Compare
ed1e408
to
fe9bc2c
Compare
bea498f
to
e45a126
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
fix #3721
Description of changes:
E2900
to validate parameters in a deployment file match the parameters in a templatePattern
matchesAllowedValues
match the parameter valueDefault
value the value is required in the deployment file--deployment-files
that will take a list of deployment files to validate--parameter-files
that will take a list of strings (or glob pattern) to read parameter files from. You can only provide one template when using this parameter.--template-parameters
that will accept the parameters for the template being run. You can only provide one template when using this parameter.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.