chore(log): format log output from build job (#81)

* Update build command to output text instead of binary for correct formatting of stdout and stderr
* Update tests to account for newlines

Co-authored-by: Kevin DeJong <[email protected]>

Author: mmaeng

python/rpdk/typescript/codegen.py

@@ -235,7 +235,7 @@ def _remove_build_artifacts(deps_path):
     @staticmethod
     def _make_build_command(base_path, build_command=None):
         command = (
-            "npm install --optional "
+            "npm install --include=optional "
             + f"&& sam build --debug --build-dir {os.path.join(base_path, 'build')}"
         )
         if build_command is not None:
@@ -268,6 +268,7 @@ def _build(self, base_path):
                     stderr=PIPE,
                     cwd=base_path,
                     check=True,
+                    universal_newlines=True,
                 )
             else:  # pragma: no cover
                 # On all other OS use default shell in subprocess to run build command
@@ -278,6 +279,7 @@ def _build(self, base_path):
                     cwd=base_path,
                     check=True,
                     shell=True,
+                    universal_newlines=True,
                 )
 
         except (FileNotFoundError, CalledProcessError) as e:

tests/plugin/codegen_test.py

@@ -1,4 +1,6 @@
 # pylint: disable=redefined-outer-name,protected-access
+from __future__ import unicode_literals
+
 import os
 import sys
 from subprocess import CalledProcessError
@@ -197,6 +199,7 @@ def test__build_docker(plugin: TypescriptLanguagePlugin):
             cwd=sentinel.base_path,
             stderr=-1,
             stdout=-1,
+            universal_newlines=True,
         )
     else:
         mock_subprocess_run.assert_called_once_with(
@@ -206,4 +209,5 @@ def test__build_docker(plugin: TypescriptLanguagePlugin):
             stderr=-1,
             stdout=-1,
             shell=True,
+            universal_newlines=True,
         )