Skip to content

Provide stackId in ResourceHandlerRequest #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sihil opened this issue Sep 8, 2021 · 1 comment
Open

Provide stackId in ResourceHandlerRequest #59

sihil opened this issue Sep 8, 2021 · 1 comment

Comments

@sihil
Copy link

sihil commented Sep 8, 2021

It would be really useful to have the stackId in the ResourceHandlerRequest alongside the logicalResourceIdentifier. This also allows us to track where a resource is created so that if someone in a different stack tries to create the same resource we can provide an error saying that a different stack has it, and which one.

The ARN is available on create and update events in the systemTags, but not delete events. We need to tidy up our resource ownership registry when a resource is deleted so also need it at that point.

We've worked around its absence by copying chunks of this library into our own project and switching out the BaseResource for our own copy but it would be much easier if it were in the base library.

@jabalsad
Copy link

Also useful to have the stackName in order to auto-generate physical IDs that are scoped to the stack the resource is created in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants