Skip to content

Commit 39cb41c

Browse files
authored
Fix comparison type mismatch in deployment template (#518)
This commit addresses the `incompatible types for comparison` error ncountered during the deployment process (using helm). The issue was caused by the incorrect comparison of a integer against a float This patch fixesd the issues describe above by casting the `reconcile.defaultResyncPeriod` value to an integerer before performing the comparison. Signed-off-by: Amine Hilaly <[email protected]> By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
1 parent 0208d82 commit 39cb41c

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

templates/helm/templates/deployment.yaml.tpl

+2-2
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,7 @@ spec:
6464
- --leader-election-namespace
6565
- "$(LEADER_ELECTION_NAMESPACE)"
6666
{{ "{{- end }}" }}
67-
{{ "{{- if gt .Values.reconcile.defaultResyncPeriod 0.0 }}" }}
67+
{{ "{{- if gt (int .Values.reconcile.defaultResyncPeriod) 0 }}" }}
6868
- --reconcile-default-resync-seconds
6969
- "$(RECONCILE_DEFAULT_RESYNC_SECONDS)"
7070
{{ "{{- end }}" }}
@@ -99,7 +99,7 @@ spec:
9999
value: {{ "{{ .Values.log.level | quote }}" }}
100100
- name: ACK_RESOURCE_TAGS
101101
value: {{ "{{ join \",\" .Values.resourceTags | quote }}" }}
102-
{{ "{{- if gt .Values.reconcile.defaultResyncPeriod 0.0 }}" }}
102+
{{ "{{- if gt (int .Values.reconcile.defaultResyncPeriod) 0 }}" }}
103103
- name: RECONCILE_DEFAULT_RESYNC_SECONDS
104104
value: {{ "{{ .Values.reconcile.defaultResyncPeriod | quote }}" }}
105105
{{ "{{- end }}" }}

0 commit comments

Comments
 (0)