Fixing support for existing_sso_users

[novekm]

Fixing pipeline issues from initial PR

[novekm]

Hi @artur-bolt, I moved this to a new PR as I was working to fix the pipeline errors. One was a minor one around Terraform docs that I pushed a fix for. The other failure is a functional test failure due to using a null in a for expression:

Error: �[0m�[0m�[1mIteration over null value�[0m
613 | �[31m│�[0m �[0m
614 | �[31m│�[0m �[0m�[0m  on locals.tf line 20, in locals:
615 | �[31m│�[0m �[0m  19:     for this_existing_user in keys(var.existing_sso_users) : [
616 | �[31m│�[0m �[0m  20:       for group in �[4mvar.existing_sso_users[this_existing_user].group_membership�[0m : {
617 | �[31m│�[0m �[0m  21:         user_name  = var.existing_sso_users[this_existing_user].user_name
618 | �[31m│�[0m �[0m  22:         group_name = group
619 | �[31m│�[0m �[0m  23:       }
620 | �[31m│�[0m �[0m  24:     ]�[0m
621 | �[31m│�[0m �[0m    �[90m├────────────────�[0m
622 | �[31m│�[0m �[0m�[0m    �[90m│�[0m �[1mvar.existing_sso_users�[0m is map of object with 1 element
623 | �[31m│�[0m �[0m�[0m
624 | �[31m│�[0m �[0mA null value cannot be used as the collection in a 'for' expression.
625

Can you look into this and resolve?

[novekm]

/do-e2e-tests

[aws-ia-automator-prod]

End to end test has been scheduled

[aws-ia-automator-prod]

E2E tests in progress

[aws-ia-automator-prod]

E2E tests in progress

[aws-ia-automator-prod]

E2E test has completed with errors. If you are an external contributor, please contact the project maintainers for more information.

[novekm]

Hi @artur-bolt,

Following up with this - the PR you submitted has errors related to your usage of a null value in a for loop. Would you like to resolve? We're happy to review and merge the PR if all is well, however currently this PR will break functionality of the module.

[alexandertgtalbot]

I've attempted a simpler approach that should hopefully clear e2e tests: #60.