Skip to content
This repository was archived by the owner on Oct 4, 2024. It is now read-only.

Gitlab Project Id #36

Open
josjaf opened this issue Jul 10, 2019 · 1 comment
Open

Gitlab Project Id #36

josjaf opened this issue Jul 10, 2019 · 1 comment

Comments

@josjaf
Copy link
Contributor

josjaf commented Jul 10, 2019

Hi - I'm going through the web hook POST requests from Gitlab and I noticed we need a slight tweak.

The key event['body-json']['project_id'] exists in a push request, but not a merge request, so the lambda caught a KeyError with a merge. Below is my propose solution, let me know if you want a PR.

Thanks!

#project_id = event['body-json']['project_id']
# project_id key works in push events, but not merge requests
project_id = event['body-json']['project']['id']
@jaymccon
Copy link
Contributor

Thanks for reporting this @josjaf . A pr would be great. Just keep in mind that the ['body-json']['project_id'] is still valid in some cases, so it should not be commented out and rather use conditional logic or try->except.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants