You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Oct 4, 2024. It is now read-only.
Hi - I'm going through the web hook POST requests from Gitlab and I noticed we need a slight tweak.
The key event['body-json']['project_id'] exists in a push request, but not a merge request, so the lambda caught a KeyError with a merge. Below is my propose solution, let me know if you want a PR.
Thanks!
#project_id = event['body-json']['project_id']# project_id key works in push events, but not merge requestsproject_id=event['body-json']['project']['id']
The text was updated successfully, but these errors were encountered:
Thanks for reporting this @josjaf . A pr would be great. Just keep in mind that the ['body-json']['project_id'] is still valid in some cases, so it should not be commented out and rather use conditional logic or try->except.
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Hi - I'm going through the web hook POST requests from Gitlab and I noticed we need a slight tweak.
The key
event['body-json']['project_id']
exists in a push request, but not a merge request, so the lambda caught a KeyError with a merge. Below is my propose solution, let me know if you want a PR.Thanks!
The text was updated successfully, but these errors were encountered: