Skip to content

Commit 8849339

Browse files
committed
fix(build): include web subscriptions in approvals aggregate deploy
The approvals Makefile's deploy target ran deploy-domain deploy-service deploy-schema deploy-contracts-subscriptions, omitting deploy-web-subscriptions. Without it, unicorn-web-subscriptions.yaml (the rule forwarding PublicationApprovalRequested from the Web bus to the Approvals bus) is never deployed, so the approval workflow's state machine never starts from a request_approval call. Added deploy-web-subscriptions to the aggregate target and documented its dependency on the Web service's domain stack (WebEventBusArn SSM parameter) for standalone use outside the full workshop deployment order.
1 parent 325f860 commit 8849339

1 file changed

Lines changed: 4 additions & 1 deletion

File tree

unicorn_approvals/Makefile

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -92,7 +92,10 @@ delete-web-subscriptions: ## Deploy web event subscriptions
9292
@aws cloudformation wait stack-delete-complete --stack-name $(STACK_PREFIX)-approvals-web-subscriptions --region $(REGION) || true
9393
@echo "Done"
9494

95-
deploy: deploy-domain deploy-service deploy-schema deploy-contracts-subscriptions ## Deploy all infrastructure and application
95+
# deploy-web-subscriptions depends on the Web service's domain stack (WebEventBusArn SSM
96+
# parameter); deploy that first if running this standalone rather than as part of the full
97+
# workshop deployment order.
98+
deploy: deploy-domain deploy-service deploy-schema deploy-contracts-subscriptions deploy-web-subscriptions ## Deploy all infrastructure and application
9699

97100
test: ## Run tests
98101
@echo "Running tests..."

0 commit comments

Comments
 (0)