Update classic histogram datapoint definitions #617
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dricross
changed the title
dricross
force-pushed
the
dricross/classichistograms
branch
3 times, most recently
from
c3465ec to
6ba4b80
Compare
dricross
force-pushed
the
dricross/classichistograms
branch
from
6ba4b80 to
d9e9b47
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the issue
With the new classic histogram mapping algorithm in the agent, invalid OTel histograms are dropped. The current histogram test sends invalid OTel histograms as it uses an equal number of buckets and counts. For OTel histograms, #counts should be #buckets + 1.
Description of changes
Update the classic histogram metrics that are sent to the agent as part of the integration test to include an extra bucket count. Update the expected metric values.
License
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Tests
Integ test run with updated agent: https://github.com/aws/amazon-cloudwatch-agent/actions/runs/18923198676