fix

Author: Yiyuanzzz

ecs-agent/tcs/client/client_test.go

@@ -1015,168 +1015,3 @@ func TestInvalidFormatMessageOnChannel(t *testing.T) {
 	// verify no request was made from the two ill-formed message
 	conn.EXPECT().WriteMessage(gomock.Any(), gomock.Any()).Times(0)
 }
-func TestCopyTaskMetrics(t *testing.T) {
-	testCases := []struct {
-		name     string
-		metrics  []types.TaskMetric
-		expected int
-	}{
-		{
-			name:     "empty metrics",
-			metrics:  []types.TaskMetric{},
-			expected: 0,
-		},
-		{
-			name: "single task metric",
-			metrics: []types.TaskMetric{
-				{
-					TaskArn: aws.String("task-arn-1"),
-				},
-			},
-			expected: 1,
-		},
-		{
-			name: "multiple task metrics",
-			metrics: []types.TaskMetric{
-				{
-					TaskArn: aws.String("task-arn-1"),
-				},
-				{
-					TaskArn: aws.String("task-arn-2"),
-				},
-				{
-					TaskArn: aws.String("task-arn-3"),
-				},
-			},
-			expected: 3,
-		},
-	}
-
-	for _, tc := range testCases {
-		t.Run(tc.name, func(t *testing.T) {
-			// Create a copy of the metrics
-			copiedMetrics := copyTaskMetrics(tc.metrics)
-
-			// Verify the length is correct
-			assert.Equal(t, tc.expected, len(copiedMetrics), "Expected copied metrics to have length %d, got %d", tc.expected, len(copiedMetrics))
-
-			// For non-empty slices, verify contents are the same
-			if tc.expected > 0 {
-				for i, metric := range tc.metrics {
-					assert.Equal(t, *metric.TaskArn, *copiedMetrics[i].TaskArn, "TaskArn mismatch at index %d", i)
-				}
-
-				// Verify that changing the copy doesn't affect the original
-				if tc.expected > 0 {
-					// Modify the copy
-					newArn := "modified-arn"
-					copiedMetrics[0].TaskArn = &newArn
-
-					// Verify original is unchanged
-					assert.NotEqual(t, *copiedMetrics[0].TaskArn, *tc.metrics[0].TaskArn,
-						"Expected changes to copied metrics not to affect original")
-				}
-			}
-
-			// Verify that the returned slice is a new slice
-			if tc.expected > 0 {
-				// Get the original pointers
-				originalPtr := fmt.Sprintf("%p", &tc.metrics)
-				copiedPtr := fmt.Sprintf("%p", &copiedMetrics)
-
-				// They should be different
-				assert.NotEqual(t, originalPtr, copiedPtr, "Expected copied slice to have different memory address")
-			}
-		})
-	}
-}
-
-func TestCopyTaskMetricsWithComplexData(t *testing.T) {
-	// Create task metrics with container metrics
-	originalMetrics := []types.TaskMetric{
-		{
-			TaskArn: aws.String("task-1"),
-			ContainerMetrics: []types.ContainerMetric{
-				{
-					ContainerName: aws.String("container-1"),
-					CpuStatsSet: &types.CWStatsSet{
-						Max:         1.0,
-						Min:         0.1,
-						SampleCount: 10,
-						Sum:         5.5,
-					},
-				},
-			},
-		},
-	}
-
-	// Copy metrics
-	copiedMetrics := copyTaskMetrics(originalMetrics)
-
-	// Test that the container metrics were copied correctly
-	assert.Equal(t, *originalMetrics[0].ContainerMetrics[0].ContainerName,
-		*copiedMetrics[0].ContainerMetrics[0].ContainerName)
-	assert.Equal(t, originalMetrics[0].ContainerMetrics[0].CpuStatsSet.Max,
-		copiedMetrics[0].ContainerMetrics[0].CpuStatsSet.Max)
-
-	// Modify the copied metrics
-	newName := "modified-container"
-	copiedMetrics[0].ContainerMetrics[0].ContainerName = &newName
-	copiedMetrics[0].ContainerMetrics[0].CpuStatsSet.Max = 2.0
-
-	// Verify the original wasn't changed (this checks if it's a deep copy)
-	assert.Equal(t, "container-1", *originalMetrics[0].ContainerMetrics[0].ContainerName)
-	assert.Equal(t, 1.0, originalMetrics[0].ContainerMetrics[0].CpuStatsSet.Max)
-}
-
-func TestCopyTaskMetricsWithServiceConnectMetrics(t *testing.T) {
-	// Create task metrics with Service Connect metrics
-	dimensionKey := "ClusterName"
-	dimensionValue := "TestCluster"
-	metricName := "HTTPCode_Target_2XX_Count"
-
-	originalMetrics := []types.TaskMetric{
-		{
-			TaskArn: aws.String("task-1"),
-			ServiceConnectMetricsWrapper: []types.GeneralMetricsWrapper{
-				{
-					MetricType: types.MetricType("2"),
-					Dimensions: []types.Dimension{
-						{
-							Key:   &dimensionKey,
-							Value: &dimensionValue,
-						},
-					},
-					GeneralMetrics: []types.GeneralMetric{
-						{
-							MetricName:   &metricName,
-							MetricValues: []float64{3.0},
-							MetricCounts: []int64{1},
-						},
-					},
-				},
-			},
-		},
-	}
-
-	// Copy metrics
-	copiedMetrics := copyTaskMetrics(originalMetrics)
-
-	// Test that service connect metrics were copied correctly
-	assert.Equal(t, originalMetrics[0].ServiceConnectMetricsWrapper[0].MetricType,
-		copiedMetrics[0].ServiceConnectMetricsWrapper[0].MetricType)
-	assert.Equal(t, *originalMetrics[0].ServiceConnectMetricsWrapper[0].Dimensions[0].Key,
-		*copiedMetrics[0].ServiceConnectMetricsWrapper[0].Dimensions[0].Key)
-	assert.Equal(t, *originalMetrics[0].ServiceConnectMetricsWrapper[0].GeneralMetrics[0].MetricName,
-		*copiedMetrics[0].ServiceConnectMetricsWrapper[0].GeneralMetrics[0].MetricName)
-
-	// Modify copied metrics
-	newDimensionValue := "ModifiedCluster"
-	copiedMetrics[0].ServiceConnectMetricsWrapper[0].Dimensions[0].Value = &newDimensionValue
-	newMetricValue := 5.0
-	copiedMetrics[0].ServiceConnectMetricsWrapper[0].GeneralMetrics[0].MetricValues[0] = newMetricValue
-
-	// Original shouldn't change
-	assert.Equal(t, "TestCluster", *originalMetrics[0].ServiceConnectMetricsWrapper[0].Dimensions[0].Value)
-	assert.Equal(t, 3.0, originalMetrics[0].ServiceConnectMetricsWrapper[0].GeneralMetrics[0].MetricValues[0])
-}