Skip to content

Commit ba0aaf8

Browse files
committed
chore: add logs
1 parent 9956a48 commit ba0aaf8

File tree

2 files changed

+4
-2
lines changed

2 files changed

+4
-2
lines changed

aws_advanced_python_wrapper/failover_plugin.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -289,11 +289,13 @@ def _failover_reader(self, failed_host: Optional[HostInfo]):
289289
context.set_success(True)
290290
context.set_exception(fse)
291291
self._failover_reader_success_counter.inc()
292+
logger.info("FailoverSuccessError thrown", exc_info=fse)
292293
raise fse
293294
except Exception as ex:
294295
context.set_success(False)
295296
context.set_exception(ex)
296297
self._failover_reader_failed_counter.inc()
298+
logger.info("encountered error during reader failover", exc_info=ex)
297299
raise ex
298300
finally:
299301
context.close_context()

tests/integration/container/test_read_write_splitting.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -543,9 +543,9 @@ def test_pooled_connection__failover_failed(
543543
provider = SqlAlchemyPooledConnectionProvider(lambda _, __: {"pool_size": 1}, None, lambda host_info, props: writer_host in host_info.host)
544544
ConnectionProviderManager.set_connection_provider(provider)
545545

546-
WrapperProperties.FAILOVER_TIMEOUT_SEC.set(proxied_failover_props, "1")
546+
WrapperProperties.FAILOVER_TIMEOUT_SEC.set(proxied_failover_props, "3")
547547
WrapperProperties.FAILURE_DETECTION_TIME_MS.set(proxied_failover_props, "1000")
548-
WrapperProperties.FAILURE_DETECTION_COUNT.set(proxied_failover_props, "1")
548+
WrapperProperties.FAILURE_DETECTION_COUNT.set(proxied_failover_props, "3")
549549
WrapperProperties.PLUGINS.set(proxied_failover_props, plugins)
550550

551551
target_driver_connect = DriverHelper.get_connect_func(test_driver)

0 commit comments

Comments
 (0)