feat(autoscaling): add includeSignalCommand option to control cfn-sig… #35970
+1,690
−630
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nal in init Key changes: - Add includeSignalCommand property to ApplyCloudFormationInitOptions - Add includeSignalCommand property to AttachInitOptions - Update CloudFormationInit.attach() to conditionally include cfn-signal - Update AutoScalingGroup.applyCloudFormationInit() to pass through option - Add comprehensive test coverage for both Linux and Windows platforms - Update documentation with usage examples The option defaults to true to maintain backward compatibility. Fixes aws#34847 Signed-off-by: SACHIN KUMAR <[email protected]>
github-actions
bot
added
the
beginning-contributor
github-actions
bot
added
effort/medium
aws-cdk-automation
requested changes
Nov 6, 2025
Collaborator
There was a problem hiding this comment.
The pull request linter fails with the following errors:
❌ Features must contain a change to an integration test file and the resulting snapshot.
If you believe this pull request should receive an exemption, please comment and provide a justification. A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed, add Clarification Request to a comment.
✅ A exemption request has been requested. Please wait for a maintainer's review.
Author
Exemption RequestThis PR adds a configuration flag (
|
aws-cdk-automation
added
the
pr-linter/exemption-requested
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue # (if applicable)
Closes #34847 - [AutoScalingGroup]: Add flag to remove automatic cfn-signal addition to userdata when using init property
Reason for this change
When using CloudFormation Init with AutoScalingGroups, cfn-signal is automatically called immediately after cfn-init, causing instances to signal "ready" before applications are fully initialized. This leads to premature instance replacement during updates.
Description of changes
Added includeSignalCommand option to ApplyCloudFormationInitOptions to allow users to disable automatic cfn-signal addition and manage signaling manually.
Key changes:
Description of how you validated changes
Checklist