-
Notifications
You must be signed in to change notification settings - Fork 4.3k
feat(kms): add bypassPolicyLockoutSafetyCheck property #35973
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
go-to-k
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution. Left some minor comments
|
Thank you for the review. I'll make the suggested changes and commit them shortly. |
Co-authored-by: Kenta Goto <[email protected]>
f4fd1b0 to
7a8d97d
Compare
|
I’ve committed all three suggested changes. Thank you again for the feedback. |
go-to-k
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes.
|
This PR cannot be merged because it has conflicts. Please resolve them. The PR will be considered stale and closed if it remains in an unmergeable state. |
Issue # (if applicable)
None
Reason for this change
AWS KMS supports bypassing the key policy lockout safety check via the
BypassPolicyLockoutSafetyCheckparameter (Link).This feature was not previously configurable in the AWS CDK L2 construct.
Description of changes
bypassPolicyLockoutSafetyChecktoKeyPropsand threaded it through toCfnKey.Describe any new or updated permissions being added
None – This property only affects how AWS KMS performs its key policy lockout safety check, and does not introduce any new permissions or access scope changes.
Description of how you validated changes
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license