ci(integ-test-deployment): use integ runner with strict flag #35974
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abidhasan-aws
force-pushed
the
abidhasan/use-integ-runner-with-strict-flag
branch
from
c66c237 to
8720c4c
Compare
Abogical
requested changes
Nov 11, 2025
Member
Abogical
left a comment
Abogical
left a comment
There was a problem hiding this comment.
Separate the snapshot change into a different PR. This change should not be marked under a ci commit, and if something went wrong we can revert that snapshot change only more easily.
abidhasan-aws
force-pushed
the
abidhasan/use-integ-runner-with-strict-flag
branch
2 times, most recently
from
aa7e1e8 to
f37763c
Compare
Abogical
approved these changes
Nov 11, 2025
Contributor
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Contributor
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Contributor
|
Comments on closed issues and PRs are hard for our team to see. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for this change
Previously
integration-test-deploymentwas passing in silent if some of the test were not found.We want to make sure that all the changed integ tests in a PR ran, or workflow should fail.
Change
integration-test-deploymentto useinteg-runnerwith--strictflag so that workflow fails in case of test not found.Testing
Test run on fork: https://github.com/Abogical/aws-cdk/actions/runs/19229944532/job/54965890882?pr=19
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license