Skip to content

Commit 40589ff

Browse files
committed
Fix usage of clang-tidy-review
1 parent 32e73b3 commit 40589ff

File tree

4 files changed

+7
-8
lines changed

4 files changed

+7
-8
lines changed

.clang-tidy

-1
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,5 @@ Checks: '
1111
modernize-*,
1212
performance-*,
1313
portability-*,
14-
readability-*
1514
'
1615
WarningsAsErrors: ''

.github/workflows/clang-tidy-post.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ jobs:
1010
build:
1111
runs-on: ubuntu-latest
1212
steps:
13-
- uses: ZedThree/clang-tidy-review/post@v0.21.0
13+
- uses: justsmth/clang-tidy-review/post@e8b24ea1d3ecfaa960525cd4bd417913987ab304
1414
with:
1515
lgtm_comment_body: '' # An empty string means it won't post a LGTM message
1616
annotations: false

.github/workflows/clang-tidy-review.yml

+5-5
Original file line numberDiff line numberDiff line change
@@ -9,10 +9,10 @@ jobs:
99
- uses: actions/setup-go@v4
1010
with:
1111
go-version: '>=1.18'
12-
- name: Build Project
13-
run: ./util/build_compilation_database.sh
14-
- uses: ZedThree/[email protected]
12+
# Fork that avoid unnecessary filtering of clang-tidy output
13+
- uses: justsmth/clang-tidy-review@e8b24ea1d3ecfaa960525cd4bd417913987ab304
1514
with:
1615
split_workflow: true
17-
18-
- uses: ZedThree/clang-tidy-review/[email protected]
16+
clang_tidy_version: 19
17+
install_commands: /github/workspace/util/build_compilation_database.sh
18+
- uses: justsmth/clang-tidy-review/upload@e8b24ea1d3ecfaa960525cd4bd417913987ab304

util/build_compilation_database.sh

+1-1
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ TMP_DIR=`mktemp -d`
88
echo ${TMP_DIR}
99
AWS_LC_BUILD="${TMP_DIR}/AWS-LC-BUILD"
1010

11-
MY_CMAKE_FLAGS=("-GNinja" "-DCMAKE_BUILD_TYPE=Debug" "-DCMAKE_EXPORT_COMPILE_COMMANDS=ON")
11+
MY_CMAKE_FLAGS=("-DCMAKE_BUILD_TYPE=Debug" "-DCMAKE_EXPORT_COMPILE_COMMANDS=ON" "-DDISABLE_GO=ON")
1212

1313
mkdir -p "${AWS_LC_BUILD}"
1414

0 commit comments

Comments
 (0)